From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: ARC-Seal: i=1; a=rsa-sha256; t=1516829388; cv=none; d=google.com; s=arc-20160816; b=X6zYncOWX+9xcbYmqcGfhFIXRLxMDOEW0tdIr/ZXp0EnDAaf6pLh4+Y2XaIxRniJuD U8+uqPgoNAfgicJCuA1eQ2IDOA7zen3Mficr/S0VN/tCdGIhzPj2HR0/C1L1oxt+Wwq4 QqzRrHWvlbTfNlvoA1zjXwlKg/fgVhFQhI6boahMFys+jwdftyQd9IdnE9cqBwYTLi0K bGn8dPMS7MO0OvrYD2ZV7FX7bJng8NvnBP8AKL3RX1V+VJcD3YNMu8yENlynqE+RYXZ3 /Cab7DWHKn0+kX/KQiZq3B7QSoDZMNo7/HZVdn8gzdUi/eHxFq1yLlMNvvJvjuxYHJbV VrKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:sender:dkim-signature :arc-authentication-results; bh=RKtzSTNoyGXgCppMXzvizR1UqPujYlWC2OaDGDKvt4Q=; b=Pn1u4AG0DHSDK5Okwu7QffZnqEukHBnrFExivZy2csuI6epuPILMIYQ8OAO2Oq1vIf D1fRzkVuoRRMJtKQz3L16DlWcFPE1HXp1OrMMzIDdWqJXFilsbPElyGT5DfJ5ZRmbvtE mBbVwiuZdvObUfCyfojCMMkX2x20jVWIXnP3pbk1X8fKJ3NlJPQLwLyJ+0jU5Kvg1Ys/ hFRpsWYCgPZLGByVXg6waBEWoD/LDuDjEJ8nYqUNqYoAGdhNqLPytY9jAwILCGrJVTMO Yp15+dawpK2w9qt+fuJ5N6L52EqUDHXCt7zOJhMviUy7NhTqC+gGMhE984EHoiSEd0+N Mm7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=pUYcqExq; spf=pass (google.com: domain of mingo.kernel.org@gmail.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=mingo.kernel.org@gmail.com Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=pUYcqExq; spf=pass (google.com: domain of mingo.kernel.org@gmail.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=mingo.kernel.org@gmail.com X-Google-Smtp-Source: AH8x227tw/CVuhp6Trt9Jsja4i9ZYhWgee8Ovd08ijOaQSqRHfJyf0I1M2JUlQEoshcwHcvytow17A== Sender: Ingo Molnar Date: Wed, 24 Jan 2018 22:29:45 +0100 From: Ingo Molnar To: Greg KH Cc: David Woodhouse , arjan@linux.intel.com, tglx@linutronix.de, karahmed@amazon.de, x86@kernel.org, linux-kernel@vger.kernel.org, tim.c.chen@linux.intel.com, bp@alien8.de, peterz@infradead.org, pbonzini@redhat.com, ak@linux.intel.com, torvalds@linux-foundation.org, dave.hansen@intel.com, gnomes@lxorguk.ukuu.org.uk Subject: Re: [PATCH v3 6/6] x86/cpufeature: Blacklist SPEC_CTRL on early Spectre v2 microcodes Message-ID: <20180124212945.ikfzxdxah2shqiis@gmail.com> References: <1516813025-10794-1-git-send-email-dwmw@amazon.co.uk> <1516813025-10794-7-git-send-email-dwmw@amazon.co.uk> <20180124172931.GG16646@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180124172931.GG16646@kroah.com> User-Agent: NeoMutt/20170609 (1.8.3) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1590493767497033665?= X-GMAIL-MSGID: =?utf-8?q?1590510892773453009?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: > On Wed, Jan 24, 2018 at 04:57:05PM +0000, David Woodhouse wrote: > > +static const struct sku_microcode spectre_bad_microcodes[] = { > > + { INTEL_FAM6_KABYLAKE_DESKTOP, 0x0B, 0x80 }, > > + /* Corrected typo in Intel doc */ > > + { INTEL_FAM6_KABYLAKE_DESKTOP, 0x0A, 0x80 }, > > + { INTEL_FAM6_KABYLAKE_MOBILE, 0x0A, 0x80 }, > > + { INTEL_FAM6_KABYLAKE_MOBILE, 0x09, 0x80 }, > > + { INTEL_FAM6_KABYLAKE_DESKTOP, 0x09, 0x80 }, > > + { INTEL_FAM6_SKYLAKE_X, 0x04, 0x0200003C }, > > + { INTEL_FAM6_SKYLAKE_MOBILE, 0x03, 0x000000C2 }, > > + { INTEL_FAM6_SKYLAKE_DESKTOP, 0x03, 0x000000C2 }, > > + { INTEL_FAM6_BROADWELL_CORE, 0x04, 0x28 }, > > + { INTEL_FAM6_BROADWELL_GT3E, 0x01, 0x0000001B }, > > + { INTEL_FAM6_HASWELL_ULT, 0x01, 0x21 }, > > + { INTEL_FAM6_HASWELL_GT3E, 0x01, 0x18 }, > > + { INTEL_FAM6_HASWELL_CORE, 0x03, 0x23 }, > > + { INTEL_FAM6_IVYBRIDGE_X, 0x04, 0x42a }, > > + { INTEL_FAM6_HASWELL_X, 0x02, 0x3b }, > > + { INTEL_FAM6_HASWELL_X, 0x04, 0x10 }, > > + { INTEL_FAM6_HASWELL_CORE, 0x03, 0x23 }, > > + { INTEL_FAM6_BROADWELL_XEON_D, 0x02, 0x14 }, > > + { INTEL_FAM6_BROADWELL_XEON_D, 0x03, 0x7000011 }, > > + { INTEL_FAM6_BROADWELL_GT3E, 0x01, 0x0000001B }, > > + { INTEL_FAM6_BROADWELL_X, 0x01, 0x0b000025 }, > > + /* Dropped repeat of KBL Desktop 906E9, 0x80 */ > > + { INTEL_FAM6_SKYLAKE_X, 0x03, 0x0100013e }, > > + /* Dropped repeat of SKX 50654, 0x200003c */ Could we please also get better tabulation of this array, so that the general layout of the values is easier to see? It's also prettier: { INTEL_FAM6_KABYLAKE_DESKTOP, 0x09, 0x00000080 }, { INTEL_FAM6_SKYLAKE_X, 0x04, 0x0200003C }, { INTEL_FAM6_SKYLAKE_MOBILE, 0x03, 0x000000C2 }, { INTEL_FAM6_SKYLAKE_DESKTOP, 0x03, 0x000000C2 }, Note the vertical spacing and the fixed length of each column. (We can ignore the col80 for things like this.) Thanks, Ingo