From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751297AbeAYHpd (ORCPT ); Thu, 25 Jan 2018 02:45:33 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:40289 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751081AbeAYHpc (ORCPT ); Thu, 25 Jan 2018 02:45:32 -0500 Date: Wed, 24 Jan 2018 23:45:11 -0800 From: Christoph Hellwig To: Palmer Dabbelt Cc: linux@armlinux.org.uk, catalin.marinas@arm.com, Will Deacon , jonas@southpole.se, stefan.kristiansson@saunalahti.fi, shorne@gmail.com, tglx@linutronix.de, Christoph Hellwig , Arnd Bergmann , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, patches@groups.riscv.org Subject: Re: [PATCH v2 1/4] arm: Make set_handle_irq and handle_arch_irq generic Message-ID: <20180125074511.GA14162@infradead.org> References: <20180125030756.21787-1-palmer@sifive.com> <20180125030756.21787-2-palmer@sifive.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180125030756.21787-2-palmer@sifive.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 24, 2018 at 07:07:53PM -0800, Palmer Dabbelt wrote: > It looks like this same irqchip registration mechanism has been copied > into a handful of ports, including aarch64 and openrisc. I want to use > this in the RISC-V port, so I thought it would be good to make this > generic instead. > > This patch simply moves set_handle_irq and handle_arch_irq from arch/arm > to kernel/irq/handle.c. The two important changes here are that: a) the handle_arch_irq defintion is moved from assembly to C code b) it is now marked __ro_after_init Those should be prominently mentioned in the changelog, and for a we probably need an explicit ACK from the ARM folks.