From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-3475352-1516873690-2-4877950160748525796 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: yes ("Address greg@kroah.com in From header is in addressbook"); in-addressbook; shared/fdfaecbe-d8f0-4518-a17e-0d89bf6dc529 ("Greg") X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='com', MailFrom='org' X-Spam-charsets: plain='us-ascii' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: linux-usb-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1516873689; b=S2nkEbzpDbIoMpibgSJUNeFFU/ffnbQIeLqLYIuqZ4vYWlo BAQsWz80YG3ESAlA/NqASTFDwDSn8VbAGXXNHEUginSPX6IyWpc4yUltbnj9gRfk +N6ZyCgTYyed9+5J52bv8Awdqr7IS7OMi/HttA60tXQkOm3Ak2CzbhR9JE4DZrE+ 2LDnoGBiG7vwRAUz3ULfAGj7M+ihCvKfjvnsVdJ/Ng2e4ithjwQEZmQIyzrZ4/94 EEFCsMJadTPleajUP6fUqRTIB5P5avmLWwUPMoxDY3LsFEDVLmfGYN2mhEqzFCI0 Dhy16yM8Dh5YFCfX6MGIbn6Xe2gAYSLg7LNWpcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:in-reply-to:sender :list-id; s=arctest; t=1516873689; bh=+0DJnr5kBTTrux5BPJH+6wWyBe MjXtQarThP85/f9vk=; b=c0RUlBWdQACSoVbAGbIJE0JqQlhNDXt6tRXI/9BtY4 6KX/0lz4/N67gFe2W6ifirQIL3hi73fUcBqKgsaS/N6JglobHjYAmuSR9RonVPTH yT8QBGUPR2vtxJMC/qthg4Yj4MUNP5VkoIywrVgHYh5rPRlpj8ZO7kRxdu+L2I+F CWydPgpNJZ4bgXXnQuRE3yeg6l/hLmDgaF36OvS9G97f0BFbp4ZlE/TPN0hmm1Vf dQYonD8WlYELoSY6WMd3iCjtYnU/4lsDjMoTLV/KV+fA94j5HWYSd3TZC3v49IM8 irGMqGUhaxcskTefTN3J5geSmxSqkzSkq6G2ZLs2FS5g== ARC-Authentication-Results: i=1; mx1.messagingengine.com; arc=none (no signatures found); dkim=fail (body has been altered; 2048-bit rsa key sha256) header.d=messagingengine.com header.i=@messagingengine.com header.b=oTmzkP/b x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=fm1; dmarc=none (p=none,has-list-id=yes,d=none) header.from=kroah.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-usb-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=kroah.com header.result=pass header_is_org_domain=yes Authentication-Results: mx1.messagingengine.com; arc=none (no signatures found); dkim=fail (body has been altered; 2048-bit rsa key sha256) header.d=messagingengine.com header.i=@messagingengine.com header.b=oTmzkP/b x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=fm1; dmarc=none (p=none,has-list-id=yes,d=none) header.from=kroah.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-usb-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=kroah.com header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751161AbeAYJsF (ORCPT ); Thu, 25 Jan 2018 04:48:05 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:34677 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751136AbeAYJsA (ORCPT ); Thu, 25 Jan 2018 04:48:00 -0500 X-ME-Sender: Date: Thu, 25 Jan 2018 10:38:17 +0100 From: Greg KH To: Ingo Molnar Cc: Benjamin Gilbert , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, x86@kernel.org, Borislav Petkov , Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" Subject: Re: [PATCH 3/3] firmware: Fix up docs referring to FIRMWARE_IN_KERNEL Message-ID: <20180125093817.GB14894@kroah.com> References: <20180124020632.22905-1-benjamin.gilbert@coreos.com> <20180124020632.22905-4-benjamin.gilbert@coreos.com> <20180124074130.h35a6gghehnxr2st@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180124074130.h35a6gghehnxr2st@gmail.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-usb-owner@vger.kernel.org X-Mailing-List: linux-usb@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Wed, Jan 24, 2018 at 08:41:30AM +0100, Ingo Molnar wrote: > > * Benjamin Gilbert wrote: > > > We've removed the option, so stop talking about it. > > > > Signed-off-by: Benjamin Gilbert > > Cc: Borislav Petkov > > Cc: Thomas Gleixner > > Cc: Ingo Molnar > > Cc: H. Peter Anvin > > --- > > Documentation/driver-api/firmware/built-in-fw.rst | 7 +------ > > Documentation/x86/microcode.txt | 5 ++--- > > arch/x86/Kconfig | 6 +++--- > > 3 files changed, 6 insertions(+), 12 deletions(-) > > > > diff --git a/Documentation/driver-api/firmware/built-in-fw.rst b/Documentation/driver-api/firmware/built-in-fw.rst > > index 7300e66857f8..396cdf591ac5 100644 > > --- a/Documentation/driver-api/firmware/built-in-fw.rst > > +++ b/Documentation/driver-api/firmware/built-in-fw.rst > > @@ -11,13 +11,8 @@ options: > > * CONFIG_EXTRA_FIRMWARE > > * CONFIG_EXTRA_FIRMWARE_DIR > > > > -This should not be confused with CONFIG_FIRMWARE_IN_KERNEL, this is for drivers > > -which enables firmware to be built as part of the kernel build process. This > > -option, CONFIG_FIRMWARE_IN_KERNEL, will build all firmware for all drivers > > -enabled which ship its firmware inside the Linux kernel source tree. > > - > > There are a few reasons why you might want to consider building your firmware > > -into the kernel with CONFIG_EXTRA_FIRMWARE though: > > +into the kernel with CONFIG_EXTRA_FIRMWARE: > > > > * Speed > > * Firmware is needed for accessing the boot device, and the user doesn't > > diff --git a/Documentation/x86/microcode.txt b/Documentation/x86/microcode.txt > > index f57e1b45e628..aacd2f5e1a46 100644 > > --- a/Documentation/x86/microcode.txt > > +++ b/Documentation/x86/microcode.txt > > @@ -108,12 +108,11 @@ packages already put them there. > > ==================== > > > > The loader supports also loading of a builtin microcode supplied through > > -the regular firmware builtin method CONFIG_FIRMWARE_IN_KERNEL. Only > > -64-bit is currently supported. > > +the regular firmware builtin method CONFIG_EXTRA_FIRMWARE. Only 64-bit is > > +currently supported. > > s/regular firmware builtin method > /regular builtin firmware method I'll go edit that up by hand, thanks for the review. greg k-h