From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751331AbeAYKd2 (ORCPT <rfc822;w@1wt.eu>);
        Thu, 25 Jan 2018 05:33:28 -0500
Received: from mail-pf0-f194.google.com ([209.85.192.194]:39530 "EHLO
        mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750769AbeAYKd1 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 25 Jan 2018 05:33:27 -0500
X-Google-Smtp-Source: AH8x227rYkdigBSlc0C2IacB3dfAT/Y9VRXZEKU8UMA/Ri/rbJ35T7WVPivLVbCB8nLDvVZV3dml6g==
Date: Thu, 25 Jan 2018 18:33:16 +0800
From: Dong Aisheng <dongas86@gmail.com>
To: Anson Huang <Anson.Huang@nxp.com>
Cc: shawnguo@kernel.org, kernel@pengutronix.de, fabio.estevam@nxp.com,
        robh+dt@kernel.org, aisheng.dong@nxp.com, mark.rutland@arm.com,
        linux@armlinux.org.uk, Linux-imx@nxp.com,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ARM: dts: imx6sx: add ARM power domain support
Message-ID: <20180125103316.GB24622@b29396-OptiPlex-7040>
References: <1516725734-32745-1-git-send-email-Anson.Huang@nxp.com>
 <1516725734-32745-2-git-send-email-Anson.Huang@nxp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1516725734-32745-2-git-send-email-Anson.Huang@nxp.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jan 24, 2018 at 12:42:14AM +0800, Anson Huang wrote:
> Add ARM power domain in PGC.
> 
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> this patch should be based on 0001-ARM-dts-imx6sx-add-pu-power-domain-support.patch
>  arch/arm/boot/dts/imx6sx.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
> index 42ef4c6..aa29ca6 100644
> --- a/arch/arm/boot/dts/imx6sx.dtsi
> +++ b/arch/arm/boot/dts/imx6sx.dtsi
> @@ -768,6 +768,11 @@
>  					#address-cells = <1>;
>  					#size-cells = <0>;
>  
> +					power-domain@0 {

Nitpick: probably an 'arm' prefix is better:
arm: power-domain@0

Anyway, it's minor depends on maintainer's perference.

Otherwise, looks fine

Acked-by: Dong Aisheng <aisheng.dong@nxp.com>

Regards
Dong Aisheng

> +						reg = <0>;
> +						#power-domain-cells = <0>;
> +					};
> +
>  					pd_pu: power-domain@1 {
>  						reg = <1>;
>  						#power-domain-cells = <0>;
> -- 
> 2.7.4
>