From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-3635110-1516876655-2-13095734952273188386 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, ME_NOAUTH 0.01, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='org', MailFrom='org' X-Spam-charsets: plain='us-ascii' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1516876655; b=jv+Fl5Mw1b1goNf/EpS/1yJtOQk8bziNKU1BQcjmIukSogj +qVbLVVzPzvEhXUfcpgDF7E2zo/bAeVOu6erR9N5oLD8DcEE78ImFvGsKMOaZPDx 6lPZFNhZQMStBO2SN6cQexNBdivJpKNyL6VtHIJmp1Q7pOhjAuelaItO7WF8OUgt cwfnxSbUFlWe7vu3qPtEhCV7nnhpfE8s5AUGHeysR9XZosBKTyXhSkWielQEY71J 7Z/CjPajsWGrvvzr/FEsiT+OiWrSKY+3vi76UNdhH62YQQrcNTvuSEaExQxkJmX/ m4/ShlQMgNglaaLpWpDbGpDZkSHYc3UmloS9k0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:in-reply-to:sender :list-id; s=arctest; t=1516876655; bh=9PcNoj+xcvbDveB66oB5r9kbSo 7/ZDo82fTGF6Ka4pI=; b=Qj+sE4pPuIE6ANcycUkTWgwI2saMAdTSnXbgI//wpD WdggZg6kAOn3uc8NNvZiO0QOPxuxKz8ntqb2o09NOqrUTY0AcUPkOdHNkxtxVoEr +3Ll55L+pw2z2uGe/aBKx6kZrBmmmx7ECnrNQiAyYkKtQp6I1npunb+xhRuUnmRH 8iaIXmHAYUYlk7ZiBBg/73uhMQxzOPiR4OIsMIPHUkWY4l2ObSzvza+XfjR039sT Rx4ltbewhMQ6vb+/JLeFI5JUpGqADGsFSmd5VknRB0Y3UbSOGSvDyDSdY7UyD4o+ g1wdgsmgTOTB51DGDNbhBfzViE2Nzyt78d2vNw7G2YqQ== ARC-Authentication-Results: i=1; mx6.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linuxfoundation.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=linuxfoundation.org header.result=pass header_is_org_domain=yes Authentication-Results: mx6.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linuxfoundation.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=linuxfoundation.org header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751155AbeAYKhV (ORCPT ); Thu, 25 Jan 2018 05:37:21 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:54734 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751065AbeAYKhU (ORCPT ); Thu, 25 Jan 2018 05:37:20 -0500 Date: Thu, 25 Jan 2018 11:37:19 +0100 From: Greg KH To: Juergen Gross Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, xen-devel@lists.xenproject.org, lenb@kernel.org, rafael.j.wysocki@intel.com, mingo@redhat.com, boris.ostrovsky@oracle.com, stable@vger.kernel.org Subject: Re: [PATCH 2/2] xen: add acpi_arch_get_root_pointer() for pvh guests Message-ID: <20180125103719.GA16777@kroah.com> References: <20180125100454.23203-1-jgross@suse.com> <20180125100454.23203-3-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180125100454.23203-3-jgross@suse.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Thu, Jan 25, 2018 at 11:04:54AM +0100, Juergen Gross wrote: > Add acpi_arch_get_root_pointer() for Xen PVH guests to communicate > the address of the RSDP table given to the kernel via Xen start info. > > This makes the kernel boot again in PVH mode after on recent Xen the > RSDP was moved to higher addresses. So up to that change it was pure > luck that the legacy method to locate the RSDP was working when > running as PVH mode. > > Cc: # 4.11 > Signed-off-by: Juergen Gross > --- > arch/x86/xen/enlighten_pvh.c | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/arch/x86/xen/enlighten_pvh.c b/arch/x86/xen/enlighten_pvh.c > index 436c4f003e17..9a5c3a7fe673 100644 > --- a/arch/x86/xen/enlighten_pvh.c > +++ b/arch/x86/xen/enlighten_pvh.c > @@ -16,15 +16,24 @@ > /* > * PVH variables. > * > - * xen_pvh and pvh_bootparams need to live in data segment since they > - * are used after startup_{32|64}, which clear .bss, are invoked. > + * xen_pvh, pvh_bootparams and pvh_start_info need to live in data segment > + * since they are used after startup_{32|64}, which clear .bss, are invoked. > */ > bool xen_pvh __attribute__((section(".data"))) = 0; > struct boot_params pvh_bootparams __attribute__((section(".data"))); > +struct hvm_start_info pvh_start_info __attribute__((section(".data"))); > > -struct hvm_start_info pvh_start_info; > unsigned int pvh_start_info_sz = sizeof(pvh_start_info); > > +acpi_physical_address acpi_arch_get_root_pointer(void) > +{ > + if (xen_pvh) > + return pvh_start_info.rsdp_paddr; > + > + return 0; > +} > +EXPORT_SYMBOL_GPL(acpi_arch_get_root_pointer); Why does this have to be an exported symbol? Does this code get built as a module and will the linker somehow go and rewrite the previous call places with this one if it gets loaded? thanks, greg k-h