From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-3816309-1516883743-2-661843376190601927 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, ME_NOAUTH 0.01, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='org', MailFrom='org' X-Spam-charsets: plain='us-ascii' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1516883742; b=SDWpA50Efx7Toad7PcmX76++kLW+abkgbrsyciW0FU1vcxJ nhMdq3Y7qAufixgDK4PV41Z3ODC12kF72nkrcpe+tMMBghoEQFI+DqqOIGyTBdwF O/fWH8ahN4NYrPv6tPQeMqCXJTM4YZBU+rs6cogcxBYWuSPP35QmwhDus+EISu81 +OMZnbzARSR3VXu08W4ZoL/W0n094NJ35+ZHDfi5rIQN1jhmqEEamtZqceNcQikM a76n9Bit+TWeQgDJCTCscXC3EorznCbCaSoHsDXqVDMHVK//n/1HU9mLwBXQy8FC SCrWPMs0XvjtSCNmhqT2Da0EtPcqBo8HBiOLzNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:in-reply-to:sender :list-id; s=arctest; t=1516883742; bh=VxAKQvN9e5Zm/TGsJ7qg6lCiRb 51/oV+gQ9nzHaDmSE=; b=JYRaaEhcrCeKd0Z+5E6AMAIkzY6qIsuBWPhfAVV8Ow FIaQUHHLFAzVwBDx0SlSqXyNiNZy80EjYjiuO7lFPArmeBNdgLdrnMHu1LUzGFFp ttMTH8PnLqk+y0ny9wRHQzzV8BqhbAisaOMbxdcg+WCEqDS1LABRmZBjrRi3oihs U5XftgjTKzVQNGSRlUNTnSPpTYJcLDyYzWGkPk89dlMEpVRVorG3PUjSyRFIJjWM VCUrplF/cp52xalg02U0QozuU11ZGtlj0MovjHl1+tnBd5x0U3jhzzNlsDdInqE8 yuaUpsNN1Hpnah3v9705vmUsxgj7j59lAhLR8M+0oeNQ== ARC-Authentication-Results: i=1; mx3.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linuxfoundation.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=linuxfoundation.org header.result=pass header_is_org_domain=yes Authentication-Results: mx3.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linuxfoundation.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=linuxfoundation.org header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752044AbeAYMf2 (ORCPT ); Thu, 25 Jan 2018 07:35:28 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:60828 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751916AbeAYMf1 (ORCPT ); Thu, 25 Jan 2018 07:35:27 -0500 Date: Thu, 25 Jan 2018 13:35:15 +0100 From: Greg KH To: Juergen Gross Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, xen-devel@lists.xenproject.org, lenb@kernel.org, rafael.j.wysocki@intel.com, mingo@redhat.com, boris.ostrovsky@oracle.com, stable@vger.kernel.org Subject: Re: [PATCH 2/2] xen: add acpi_arch_get_root_pointer() for pvh guests Message-ID: <20180125123515.GA30787@kroah.com> References: <20180125100454.23203-1-jgross@suse.com> <20180125100454.23203-3-jgross@suse.com> <20180125103719.GA16777@kroah.com> <033717a8-f53a-3379-1e05-58b3d2bed24b@suse.com> <20180125110051.GA31911@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Thu, Jan 25, 2018 at 01:06:26PM +0100, Juergen Gross wrote: > On 25/01/18 12:00, Greg KH wrote: > > On Thu, Jan 25, 2018 at 11:49:35AM +0100, Juergen Gross wrote: > >> On 25/01/18 11:37, Greg KH wrote: > >>> On Thu, Jan 25, 2018 at 11:04:54AM +0100, Juergen Gross wrote: > >>>> Add acpi_arch_get_root_pointer() for Xen PVH guests to communicate > >>>> the address of the RSDP table given to the kernel via Xen start info. > >>>> > >>>> This makes the kernel boot again in PVH mode after on recent Xen the > >>>> RSDP was moved to higher addresses. So up to that change it was pure > >>>> luck that the legacy method to locate the RSDP was working when > >>>> running as PVH mode. > >>>> > >>>> Cc: # 4.11 > >>>> Signed-off-by: Juergen Gross > >>>> --- > >>>> arch/x86/xen/enlighten_pvh.c | 15 ++++++++++++--- > >>>> 1 file changed, 12 insertions(+), 3 deletions(-) > >>>> > >>>> diff --git a/arch/x86/xen/enlighten_pvh.c b/arch/x86/xen/enlighten_pvh.c > >>>> index 436c4f003e17..9a5c3a7fe673 100644 > >>>> --- a/arch/x86/xen/enlighten_pvh.c > >>>> +++ b/arch/x86/xen/enlighten_pvh.c > >>>> @@ -16,15 +16,24 @@ > >>>> /* > >>>> * PVH variables. > >>>> * > >>>> - * xen_pvh and pvh_bootparams need to live in data segment since they > >>>> - * are used after startup_{32|64}, which clear .bss, are invoked. > >>>> + * xen_pvh, pvh_bootparams and pvh_start_info need to live in data segment > >>>> + * since they are used after startup_{32|64}, which clear .bss, are invoked. > >>>> */ > >>>> bool xen_pvh __attribute__((section(".data"))) = 0; > >>>> struct boot_params pvh_bootparams __attribute__((section(".data"))); > >>>> +struct hvm_start_info pvh_start_info __attribute__((section(".data"))); > >>>> > >>>> -struct hvm_start_info pvh_start_info; > >>>> unsigned int pvh_start_info_sz = sizeof(pvh_start_info); > >>>> > >>>> +acpi_physical_address acpi_arch_get_root_pointer(void) > >>>> +{ > >>>> + if (xen_pvh) > >>>> + return pvh_start_info.rsdp_paddr; > >>>> + > >>>> + return 0; > >>>> +} > >>>> +EXPORT_SYMBOL_GPL(acpi_arch_get_root_pointer); > >>> > >>> Why does this have to be an exported symbol? Does this code get built > >>> as a module and will the linker somehow go and rewrite the previous call > >>> places with this one if it gets loaded? > >> > >> With being called by drivers/acpi/... I just wanted to make sure it is > >> working properly even in case the acpi code is built as a module. > > > > I didn't think the core ACPI code can be built as a module, have you > > tried that? > > No, but as the build wouldn't break whenever this is changed I wanted > to make sure the symbol is found. > > If you feel strong about that I can remove the EXPORT_SYMBOL_GPL(). Please don't export symbols that do not need to be exported, that's just a waste. thanks, greg k-h