From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752022AbeAYM7L (ORCPT ); Thu, 25 Jan 2018 07:59:11 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:44853 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751531AbeAYM7J (ORCPT ); Thu, 25 Jan 2018 07:59:09 -0500 X-Google-Smtp-Source: AH8x225YByrDGXK1RWpqE5UD1QkN1WY8hTgZaZ+/qHr9/t94p59AhaVnh2VTOr7KzZtlm9fInWn9Ww== From: Christian Brauner X-Google-Original-From: Christian Brauner Date: Thu, 25 Jan 2018 13:59:06 +0100 To: jbenc@redhat.com Cc: netdev@vger.kernel.org, ebiederm@xmission.com, davem@davemloft.net, dsahern@gmail.com, fw@strlen.de, daniel@iogearbox.net, lucien.xin@gmail.com, mschiffer@universe-factory.net, jakub.kicinski@netronome.com, vyasevich@gmail.com, linux-kernel@vger.kernel.org, w.bumiller@proxmox.com, nicolas.dichtel@6wind.com Subject: Re: [PATCH net-next 0/3 V1] rtnetlink: enable IFLA_IF_NETNSID for RTM_{DEL,SET}LINK Message-ID: <20180125125905.ahqrlmods5v56ucv@gmail.com> References: <20180124142634.17766-1-christian.brauner@ubuntu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180124142634.17766-1-christian.brauner@ubuntu.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 24, 2018 at 03:26:31PM +0100, Christian Brauner wrote: > Hi, > > Based on the previous discussion this enables passing a IFLA_IF_NETNSID > property along with RTM_SETLINK and RTM_DELLINK requests. The patch for > RTM_NEWLINK will be sent out in a separate patch since there are more > corner-cases to think about. > > Best, > Christian > > Changelog 2018-01-24: > * Preserve old behavior and report -ENODEV when either ifindex or ifname is > provided and IFLA_GROUP is set. Spotted by Wolfgang Bumiller. > > Christian Brauner (3): > rtnetlink: enable IFLA_IF_NETNSID in do_setlink() > rtnetlink: enable IFLA_IF_NETNSID for RTM_SETLINK > rtnetlink: enable IFLA_IF_NETNSID for RTM_DELLINK > > net/core/rtnetlink.c | 96 ++++++++++++++++++++++++++++++++++++++++------------ > 1 file changed, 75 insertions(+), 21 deletions(-) > > -- > 2.14.1 > I've done more testing around enabling IFLA_IF_NETNSID for RTM_NEWLINK as well and I think that the change is actually trivial. However, I would like to wait before sending this patch out until we have agreed on the patches for RTM_SETLINK and RTM_DELLINK in this series. Once we have merged those I can just send another small commit. Or - if changes to this patch series are required - I can just add it in a v2. Thanks Christian