From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933945AbeAYDkK (ORCPT ); Wed, 24 Jan 2018 22:40:10 -0500 Received: from ozlabs.org ([103.22.144.67]:33481 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933440AbeAYDjy (ORCPT ); Wed, 24 Jan 2018 22:39:54 -0500 Date: Thu, 25 Jan 2018 14:39:47 +1100 From: Stephen Rothwell To: Al Viro , Miklos Szeredi Cc: Linux-Next Mailing List , Linux Kernel Mailing List , NeilBrown Subject: Re: linux-next: manual merge of the vfs tree with the overlayfs tree Message-ID: <20180125143947.513e895a@canb.auug.org.au> In-Reply-To: <20180125143155.20b15b37@canb.auug.org.au> References: <20180125143155.20b15b37@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi all, On Thu, 25 Jan 2018 14:31:55 +1100 Stephen Rothwell wrote: > > + if (!disconnected) { > - hlist_bl_lock(&tmp->d_sb->s_roots); > - hlist_bl_add_head(&tmp->d_hash, &tmp->d_sb->s_roots); > - hlist_bl_unlock(&tmp->d_sb->s_roots); > ++ hlist_bl_lock(&dentry->d_sb->s_roots); > ++ hlist_bl_add_head(&dentry->d_hash, &tmp->d_sb->s_roots); I fixed up the "tmp" here ... it should have been "dentry". -- Cheers, Stephen Rothwell