From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751960AbeAZAAZ (ORCPT ); Thu, 25 Jan 2018 19:00:25 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:37422 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751846AbeAZAAS (ORCPT ); Thu, 25 Jan 2018 19:00:18 -0500 Date: Thu, 25 Jan 2018 16:00:16 -0800 From: Andrew Morton To: David Rientjes Cc: Roman Gushchin , Michal Hocko , Vladimir Davydov , Johannes Weiner , Tetsuo Handa , Tejun Heo , kernel-team@fb.com, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [patch -mm v2 2/3] mm, memcg: replace cgroup aware oom killer mount option with tunable Message-Id: <20180125160016.30e019e546125bb13b5b6b4f@linux-foundation.org> In-Reply-To: References: X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 25 Jan 2018 15:53:48 -0800 (PST) David Rientjes wrote: > Now that each mem cgroup on the system has a memory.oom_policy tunable to > specify oom kill selection behavior, remove the needless "groupoom" mount > option that requires (1) the entire system to be forced, perhaps > unnecessarily, perhaps unexpectedly, into a single oom policy that > differs from the traditional per process selection, and (2) a remount to > change. > > Instead of enabling the cgroup aware oom killer with the "groupoom" mount > option, set the mem cgroup subtree's memory.oom_policy to "cgroup". Can we retain the groupoom mount option and use its setting to set the initial value of every memory.oom_policy? That way the mount option remains somewhat useful and we're back-compatible?