From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753891AbeAZQKS (ORCPT <rfc822;w@1wt.eu>);
        Fri, 26 Jan 2018 11:10:18 -0500
Received: from shards.monkeyblade.net ([184.105.139.130]:47476 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753836AbeAZQKQ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 26 Jan 2018 11:10:16 -0500
Date: Fri, 26 Jan 2018 11:10:15 -0500 (EST)
Message-Id: <20180126.111015.455737320290348169.davem@davemloft.net>
To: baijiaju1990@gmail.com
Cc: viro@ZenIV.linux.org.uk, 3chas3@gmail.com,
        linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] atm: firestream: Replace GFP_ATOMIC with GFP_KERNEL in
 fs_send
From: David Miller <davem@davemloft.net>
In-Reply-To: <d5697036-e9aa-67a1-a6f3-3a17940542d6@gmail.com>
References: <1516953627-30983-1-git-send-email-baijiaju1990@gmail.com>
        <20180126120522.GX13338@ZenIV.linux.org.uk>
        <d5697036-e9aa-67a1-a6f3-3a17940542d6@gmail.com>
X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Jia-Ju Bai <baijiaju1990@gmail.com>
Date: Fri, 26 Jan 2018 21:56:32 +0800

> My tool did not handle this situation of passing function pointer, and
> I will improve the tool...

Never automate these kinds of changes.

Actually audit the change fully _yourself_ as a human after the tool
indicates a possibility to you.

This is why most of your changes have bugs, you rely on the tool too
much.