From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753687AbeAZQND convert rfc822-to-8bit (ORCPT ); Fri, 26 Jan 2018 11:13:03 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:47520 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751422AbeAZQNC (ORCPT ); Fri, 26 Jan 2018 11:13:02 -0500 Date: Fri, 26 Jan 2018 11:13:00 -0500 (EST) Message-Id: <20180126.111300.1890116690344495362.davem@davemloft.net> To: ecree@solarflare.com Cc: fengguang.wu@intel.com, kbuild-all@01.org, netdev@vger.kernel.org, linux-net-drivers@solarflare.com, bkenward@solarflare.com, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH net-next] sfc: efx_default_channel_want_txqs() can be static From: David Miller In-Reply-To: <8f502691-13cc-5128-43dd-36a17ec8bcc2@solarflare.com> References: <201801260928.N1021lrX%fengguang.wu@intel.com> <20180126010304.GA87465@cairo> <8f502691-13cc-5128-43dd-36a17ec8bcc2@solarflare.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Edward Cree Date: Fri, 26 Jan 2018 15:13:05 +0000 > On 26/01/18 01:03, kbuild test robot wrote: >> Fixes: 2935e3c38228 ("sfc: on 8000 series use TX queues for TX timestamps") >> Signed-off-by: Fengguang Wu > Acked-by: Edward Cree > > Dave, can you take this directly or do you need it reposted without RFC tags?  I'm not sure what the procedure is for robopatches. No I cannot. Don't you even notice that the subject line and commit message are totally inaccurate? They say that one function is being marked static. But the patch actually marks two different functions static, as well as a structure which is also completely not mentioned in the commit message nor subject line.