From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751628AbeAZEzW (ORCPT ); Thu, 25 Jan 2018 23:55:22 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:22591 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750823AbeAZEzU (ORCPT ); Thu, 25 Jan 2018 23:55:20 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20180126045519epoutp0239e7dbcfa96ac5df34125ab8f9b02183~NQy8g2DNw2953129531epoutp02v X-AuditID: b6c32a45-403ff70000001023-a5-5a6ab4b61633 Date: Fri, 26 Jan 2018 13:55:18 +0900 From: Andi Shyti To: Dmitry Torokhov Cc: Simon Shields , Rob Herring , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] Input: mms114 - mark as direct input device Message-id: <20180126045518.GQ7575@gangnam.samsung> MIME-version: 1.0 Content-type: text/plain; charset="us-ascii" Content-disposition: inline In-reply-to: <20180124193804.155654-3-dmitry.torokhov@gmail.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0hTYRjHeT3b2VGbnOalN7WSEyWGmztTtykqWRbDhEZB1CLsMF+cths7 UzT6YGbDhMhIQaaVVgotK1s2NczAkV0wA8XywsJLiYiBrJspUsedBL/93uf5/3ku70Ngkhlh NFFktiObmTFSeIjA401QST2dxTp575hc7b0zD9Tj/l9C9cjzJlz9t7dbpO4cnMT3CzU9Tp9I 43ZdwTVVj9245rt7p1agQxkGxBQgWxwy6y0FRebCTOrI8fyD+alKOS2l09QqKs7MmFAmlZOn lR4uMnJ1qbhSxljChbQMy1JJWRk2S4kdxRksrD2TOk3TChktV8kUCoUsJflMuiKVk5xFhg9N DZh1FSurqKoTVYDbWA0IJiCZAh2fXwrWWUJ2A3ircUcNCOH4N4Crn24KN0RDgy0iPtEBYGvL LOAffgDftbYHVAJyD5xomQDrjJMJsHJyGV/nCDIJdjWuBAwYeQnAJyP9ovVEOJkD2+vaArXF ZDJs++rEeN4Kl298DsQxMhG+H3gEeI6BM2sNAW8wuR/2vHcHOJLcDZsX6gLtQbIdh8OP+gDf dw6sbfThPIfDhdedIp5j4JzryX8N15FnUs+bawH0v/gZxCeS4VxLTRBfOQxWe9c4M8HFxbDa IeFRAx0egldnw2cdLozfylsAOyvr8Vqww7lpHuemeZyb5mkGmAtEIStrKkSswkrLWMbElpgL ZXqLyQ0C97XvUDdoGMrrByQBqC3iivEinUTIlLLlpn4ACYyKEG+VFusk4gKm/DyyWfJtJUbE 9oNU7lOuY9GRegt3rWZ7Pp2SJk9RKhUqpZo7q21ihzZHJyELGTs6h5AV2TZ8QURwdAWI/RMe O/CtXhV78fXgtM0fnR6mWmIfjhKLR+/79PHZXfrF3WkP786smjMvz+/tM9LuqagsYileN3vg 1chJR3b77RP3PuZ60zq2e4d9p3rir67kPciVj9VfaE20G6TM7Goomts1tTj2Rq28Vhb81Kkd dX358epYTKho2jBAxRxhKAFrYOh9mI1l/gFox22MdQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrKLMWRmVeSWpSXmKPExsVy+t9jQd1tW7KiDJ7uE7M4vOgFo8XNT99Y LS7vmsNm8X/PDnaLLWduszmweuycdZfdY9OqTjaPlvWb2Dw+b5ILYInisklJzcksSy3St0vg yjg/ZwZzwW/mioaWKewNjPOZuxg5OSQETCTOnVnI3sXIxSEksI5RYsr830wgCSGBT4wStx/4 gdgsAqoStxbeYgSx2QQ0JZpu/2ADsUUE9CW2z/4FFmcWaGaU+HFSHcQWFnCRWDNlGQuIzStg LLHs6SxmiAUnGSVutK9hh0gISvyYfI8FollLYv3O40wQtrTEo78zwGo4BRwkdp7dBGaLCihL LHg1hX0CI/8sJO2zkLTPQtK+gJF5FaNkakFxbnpusVGBUV5quV5xYm5xaV66XnJ+7iZGYOBu O6zVv4Px8ZL4Q4wCHIxKPLw3bmdGCbEmlhVX5h5ilOBgVhLhFdTNihLiTUmsrEotyo8vKs1J LT7EKM3BoiTOy59/LFJIID2xJDU7NbUgtQgmy8TBKdXAqPlSbPqKLb0WUs49l05xz1vgeP+7 O/O0DVH1Fcf7frs3vA1c8yM3X3/elvU7UnbYH3jONOd327HvsQbmmydYZyye9eFsWb6iSH+n dDH7pn9H9p6RzK9yPnB2RdiOFy/Oc+eXLZpaGC7JPsG7e98s1/Zw98KKqyuvHFf6uvnfnLBr yxxnaziGHVFiKc5INNRiLipOBAAZZ+waWAIAAA== X-CMS-MailID: 20180126045518epcas2p2ec572373e741b5ea4abe5a6e3237fa22 X-Msg-Generator: CA CMS-TYPE: 102P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20180124193814epcas1p22db64829cbf5476abe443b3ef404cd50 X-RootMTR: 20180124193814epcas1p22db64829cbf5476abe443b3ef404cd50 References: <20180124193804.155654-1-dmitry.torokhov@gmail.com> <20180124193804.155654-3-dmitry.torokhov@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dmitry, On Wed, Jan 24, 2018 at 11:38:02AM -0800, Dmitry Torokhov wrote: > mms14 is a touchscreen and thus a direct input device; let's mark it > as such. This also allows us to drop some initialization code as > input_init_mt_slots() will do that for us. > > Also add error handling for input_mt_init_slots(). > > Signed-off-by: Dmitry Torokhov Reviewed-by: Andi Shyti Tested-by: Andi Shyti Thanks, Andi