From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751546AbeAZFOo (ORCPT ); Fri, 26 Jan 2018 00:14:44 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:54774 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750730AbeAZFOl (ORCPT ); Fri, 26 Jan 2018 00:14:41 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20180126051439epoutp0122b0088b5eb1d526a001524751badaca~NRD1GS0Yn1696116961epoutp011 X-AuditID: b6c32a37-44bff70000001029-3c-5a6ab93fa4df Date: Fri, 26 Jan 2018 14:14:38 +0900 From: Andi Shyti To: Dmitry Torokhov Cc: Marcus Folkesson , Simon Shields , Rob Herring , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4 v2] Input: mms114 - add support for mms152 Message-id: <20180126051438.GS7575@gangnam.samsung> MIME-version: 1.0 Content-type: text/plain; charset="us-ascii" Content-disposition: inline In-reply-to: <20180124213201.vemutoltuz43hiwr@dtor-ws> User-Agent: Mutt/1.9.2 (2017-12-15) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrCKsWRmVeSWpSXmKPExsWy7bCmrq79zqwogxmPuS0OL3rBaHHz0zdW i8u75rBZTFx/j9Xi/54d7BZbztxmc2Dz2DnrLrvHplWdbB4t6zexeXzeJBfAEpVqk5GamJJa pJCal5yfkpmXbqvkHRzvHG9qZmCoa2hpYa6kkJeYm2qr5OIToOuWmQO0XEmhLDGnFCgUkFhc rKRvZ1OUX1qSqpCRX1xiqxRtaGikZ2hgrmdkZKRnYhxrZWQKVJKQmnH19R6WgrW8FbvXfWFs YFzH1cXIySEhYCLRf7eNsYuRi0NIYAejxIbVF9khnO+MEvPudzJ3MXKAVa176A7SICSwm1Hi 40ZxiJpPjBJrVkxkAkmwCKhKnJkJ0szJwSagKdF0+wcbiC0ioC+xffYvRhCbWWALo8SuV0Yg trCAk8TW5v3MIDavgLHEjSkb2CBsQYkfk++xQNTrSJw9tg6qV1ri0d8ZYPM5Bcwkbj5ZCBYX FVCWWPBqCjvEN1vYJN489oOwXSRWrF3HCmELS7w6voUd4hdpiUtHbSHCzYwS224ng/wiITCB UeLT3q9MEAljiWcLu5gg9vJJvPvawwrRyyvR0SYEUeIhsfbHcRYI21HiwoLJzJAwmcEk8Xzh Q+YJjLKzkLwzC8k7s5C8s4CReRWjWGpBcW56arFhgbFecWJucWleul5yfu4mRnAK0zLfwbjh nM8hRgEORiUe3hu3M6OEWBPLiitzDzFKcDArifAK6mZFCfGmJFZWpRblxxeV5qQWH2I0BUbJ RGYp0eR8YHrNK4k3NLE0MDEzAqYoS0NDJXHegACXKCGB9MSS1OzU1ILUIpg+Jg5OqQZG0UOL LISNJl1+vN8vcN+PYIs7e91fpFmcmL9kRuonJZdM7YaU3kN+1p8uf3FNKxac8H8v1/HN2a/P 342ce2DPjU/PFybX6vrv+89wXWLyRybtTtOK9N9va+bpZl1Z/HZbqN65TK8+j3upCU/fl7Yd DdH0ZZLQP6W/Y3VHSshmnkerwnJX5U87osRSnJFoqMVcVJwIAA5B33p3AwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrFLMWRmVeSWpSXmKPExsVy+t9jAV27nVlRBvNWmVkcXvSC0eLmp2+s Fpd3zWGzmLj+HqvF/z072C22nLnN5sDmsXPWXXaPTas62Txa1m9i8/i8SS6AJYrLJiU1J7Ms tUjfLoEr4+rrPSwFa3krdq/7wtjAuI6ri5GDQ0LARGLdQ/cuRi4OIYGdjBKXTs1m6WLkBHI+ MUpsPuUAYrMIqEqcmXmRHcRmE9CUaLr9gw3EFhHQl9g++xcjSDOzwBZGiR3XXjKBJIQFnCS2 Nu9nBrF5BYwlbkzZwAaxYQaTxOobn9kgEoISPybfA9vGLKAlsX7ncSYIW1ri0d8ZYNs4Bcwk bj5ZyAhiiwooSyx4NYV9AiP/LCTts5C0z0LSvoCReRWjZGpBcW56brFRgWFearlecWJucWle ul5yfu4mRmAIbzus1beD8f6S+EOMAhyMSjy8DTczo4RYE8uKK3MPMUpwMCuJ8ArqZkUJ8aYk VlalFuXHF5XmpBYfYpTmYFES572ddyxSSCA9sSQ1OzW1ILUIJsvEwSnVwCg7TVfv62NuxnZe wWfPJnRFLlVaonE3QS6OXUIk4rrnpd/3HEo+bGnqCE6uE3P1+laht8HoWfoG9mUM0dP2SV/P TtdcFS+630R3T55nX/Qlv8vCFix9z4JmXRD+v2FvsD672esO6zufbi14rin5qvSE+65rOe0s Xtubvj11m382xpfrMPtqHiWW4oxEQy3mouJEAPaq5cpdAgAA X-CMS-MailID: 20180126051439epcas1p47876262c4049d93f819dc2c1bd44c7e9 X-Msg-Generator: CA CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20180124213208epcas5p12b0a71e1013b861b5f7dd9a6060c41ac X-RootMTR: 20180124213208epcas5p12b0a71e1013b861b5f7dd9a6060c41ac References: <20180124193804.155654-1-dmitry.torokhov@gmail.com> <20180124193804.155654-5-dmitry.torokhov@gmail.com> <20180124200408.GB705@gmail.com> <20180124213201.vemutoltuz43hiwr@dtor-ws> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Simon and Dmitry, On Wed, Jan 24, 2018 at 01:32:01PM -0800, Dmitry Torokhov wrote: > From: Simon Shields > > MMS152 has no configuration registers, but the packet format used in > interrupts is identical to mms114. > > Signed-off-by: Simon Shields > Patchwork-Id: 10125841 > Signed-off-by: Dmitry Torokhov also here Reviewed-by: Andi Shyti Tested-by: Andi Shyti one small nitpick: > @@ -239,14 +249,33 @@ static int mms114_get_version(struct mms114_data *data) > { > struct device *dev = &data->client->dev; > u8 buf[6]; > + int group; > int error; do we really need to define a new 'group' variable? Andi > - error = __mms114_read_reg(data, MMS114_TSP_REV, 6, buf); > - if (error < 0) > - return error; > + switch (data->type) { > + case TYPE_MMS152: > + error = __mms114_read_reg(data, MMS152_FW_REV, 3, buf); > + if (error) > + return error; > + > + group = i2c_smbus_read_byte_data(data->client, > + MMS152_COMPAT_GROUP); > + if (group < 0) > + return group; > + > + dev_info(dev, "TSP FW Rev: bootloader 0x%x / core 0x%x / config 0x%x, Compat group: %c\n", > + buf[0], buf[1], buf[2], group); > + break; > + > + case TYPE_MMS114: > + error = __mms114_read_reg(data, MMS114_TSP_REV, 6, buf); > + if (error) > + return error; > > - dev_info(dev, "TSP Rev: 0x%x, HW Rev: 0x%x, Firmware Ver: 0x%x\n", > - buf[0], buf[1], buf[3]); > + dev_info(dev, "TSP Rev: 0x%x, HW Rev: 0x%x, Firmware Ver: 0x%x\n", > + buf[0], buf[1], buf[3]); > + break; > + } > > return 0; > }