From: Alexandre Courbot <acourbot@chromium.org>
To: Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil@xs4all.nl>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Pawel Osciak <posciak@chromium.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Tomasz Figa <tfiga@chromium.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Gustavo Padovan <gustavo.padovan@collabora.com>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Alexandre Courbot <acourbot@chromium.org>
Subject: [RFC PATCH 7/8] media: vim2m: add media device
Date: Fri, 26 Jan 2018 15:02:15 +0900 [thread overview]
Message-ID: <20180126060216.147918-8-acourbot@chromium.org> (raw)
In-Reply-To: <20180126060216.147918-1-acourbot@chromium.org>
Request API requires a media node. Add one to the vim2m driver so we can
use requests with it.
Signed-off-by: Alexandre Courbot <acourbot@chromium.org>
---
drivers/media/platform/vim2m.c | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/drivers/media/platform/vim2m.c b/drivers/media/platform/vim2m.c
index b01fba020d5f..a32e8a7950eb 100644
--- a/drivers/media/platform/vim2m.c
+++ b/drivers/media/platform/vim2m.c
@@ -140,6 +140,9 @@ static struct vim2m_fmt *find_format(struct v4l2_format *f)
struct vim2m_dev {
struct v4l2_device v4l2_dev;
struct video_device vfd;
+#ifdef CONFIG_MEDIA_CONTROLLER
+ struct media_device mdev;
+#endif
atomic_t num_inst;
struct mutex dev_mutex;
@@ -1001,6 +1004,13 @@ static int vim2m_probe(struct platform_device *pdev)
spin_lock_init(&dev->irqlock);
+#ifdef CONFIG_MEDIA_CONTROLLER
+ dev->mdev.dev = &pdev->dev;
+ strlcpy(dev->mdev.model, "vim2m", sizeof(dev->mdev.model));
+ media_device_init(&dev->mdev);
+ dev->v4l2_dev.mdev = &dev->mdev;
+#endif
+
ret = v4l2_device_register(&pdev->dev, &dev->v4l2_dev);
if (ret)
return ret;
@@ -1034,6 +1044,13 @@ static int vim2m_probe(struct platform_device *pdev)
goto err_m2m;
}
+#ifdef CONFIG_MEDIA_CONTROLLER
+ /* Register the media device node */
+ ret = media_device_register(&dev->mdev);
+ if (ret)
+ goto err_m2m;
+#endif
+
return 0;
err_m2m:
@@ -1050,6 +1067,13 @@ static int vim2m_remove(struct platform_device *pdev)
struct vim2m_dev *dev = platform_get_drvdata(pdev);
v4l2_info(&dev->v4l2_dev, "Removing " MEM2MEM_NAME);
+
+#ifdef CONFIG_MEDIA_CONTROLLER
+ if (media_devnode_is_registered(dev->mdev.devnode))
+ media_device_unregister(&dev->mdev);
+ media_device_cleanup(&dev->mdev);
+#endif
+
v4l2_m2m_release(dev->m2m_dev);
del_timer_sync(&dev->timer);
video_unregister_device(&dev->vfd);
--
2.16.0.rc1.238.g530d649a79-goog
next prev parent reply other threads:[~2018-01-26 6:03 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-26 6:02 [RFC PATCH 0/8] [media] Request API, take three Alexandre Courbot
2018-01-26 6:02 ` [RFC PATCH 1/8] media: add request API core and UAPI Alexandre Courbot
2018-01-26 6:02 ` [RFC PATCH 2/8] videodev2.h: Add request field to v4l2_buffer Alexandre Courbot
2018-01-26 6:02 ` [RFC PATCH 3/8] media: videobuf2: add support for requests Alexandre Courbot
2018-01-31 12:19 ` Sakari Ailus
2018-01-26 6:02 ` [RFC PATCH 4/8] media: vb2: add support for requests in QBUF ioctl Alexandre Courbot
2018-01-26 6:02 ` [RFC PATCH 5/8] media: Document the media request API Alexandre Courbot
2018-01-29 16:04 ` Hans Verkuil
2018-01-30 6:31 ` Alexandre Courbot
2018-01-26 6:02 ` [RFC PATCH 6/8] v4l2: document the request API interface Alexandre Courbot
2018-01-26 20:40 ` Randy Dunlap
2018-01-26 21:44 ` Nicolas Dufresne
2018-01-29 16:03 ` Hans Verkuil
2018-01-30 6:31 ` Alexandre Courbot
2018-01-31 8:26 ` Hans Verkuil
2018-02-06 22:19 ` Sakari Ailus
2018-01-26 6:02 ` Alexandre Courbot [this message]
2018-01-26 6:02 ` [RFC PATCH 8/8] media: vim2m: add request support Alexandre Courbot
2018-01-29 11:21 ` [RFC PATCH 0/8] [media] Request API, take three Hans Verkuil
2018-01-30 6:31 ` Alexandre Courbot
2018-01-31 7:50 ` Hans Verkuil
2018-01-31 8:10 ` Tomasz Figa
2018-01-31 8:47 ` Hans Verkuil
2018-01-31 9:46 ` Tomasz Figa
2018-01-31 16:16 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180126060216.147918-8-acourbot@chromium.org \
--to=acourbot@chromium.org \
--cc=gustavo.padovan@collabora.com \
--cc=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mchehab@kernel.org \
--cc=posciak@chromium.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®