From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x227OlqIncUbfh38IEQQXEjwR7VMh5crplISAVTNZSDYpSeC+96oDd27f7nr+x79pn+4FiKDd ARC-Seal: i=1; a=rsa-sha256; t=1516935658; cv=none; d=google.com; s=arc-20160816; b=Wis0TNDxHJYEoBg321Ozw2dczoJ5I2eCTKL5TlCfme29kJGHG2Ye53zpSMJ6/2vsKW Pu3l6jrpJ6+wiOG3x75Xs2H+w7CNSx1tLeNr1lWbqoZM4rlOnG2u4vE4QMdcDyckCneO ppkRueQUwo7y7oqZ8Njvekzcp8kOn6moMvpcwiWLLwl0GYYFeLrwpjcLMRe8aIbjEO9F C0MMPdXs4Yr5PVNVjGOe5QoDeJN7OZc6P1/ZQ6I59doHFupc3o+nin0jcz6sG/q40YHW TGorwmRsi5D9XVzcg4MFBGMq0UfjTfS0hwWzl009Hl/0xmc3/WoWNSGWH+vGOk3S/RoC 3/bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:arc-authentication-results; bh=Vx1GguIpd3ZsQ3ABjGqpj2a+j1gFpU34r/7RE19it78=; b=YYgRVJawrKLI9R8MWjs2fIFz3M+iy98wksRlUbMGvX/uC/JYrOJfv8GYcldLuSLuDq wt78QNQgRbmXJqAoCyD56NGq8j6uKrnbU9Ts/rhyT39Z0U2+mLaYDHFljcL0saIl4pOS bdx2yEOjlAYevYLJ+xNGaqPiY54ZQMHxqd0rtE59Cd32kvEAu9ToLtPHmcA9M8CfB68h /AZc1JzH7rySGjK7uqRp1T3KiBUZHXrW2Iiud8/JvnpboVkeDFrx3ogMF7CEWhPGw9lE vHCHHemaH6ctevYRHG5JWOiXCFUrPmWMjJhO5lUJkdSrOsm7dZmaM8dnUSuooyJE7YGY upNg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of yong.deng@magewell.com designates 115.124.20.49 as permitted sender) smtp.mailfrom=yong.deng@magewell.com Authentication-Results: mx.google.com; spf=pass (google.com: domain of yong.deng@magewell.com designates 115.124.20.49 as permitted sender) smtp.mailfrom=yong.deng@magewell.com X-Alimail-AntiSpam: AC=CONTINUE;BC=0.06656254|-1;CH=green;FP=0|0|0|0|0|-1|-1|-1;HT=e02c03309;MF=yong.deng@magewell.com;NM=1;PH=DS;RN=28;RT=28;SR=0;TI=SMTPD_---.AXEmKxt_1516935642; Date: Fri, 26 Jan 2018 11:00:41 +0800 From: Yong To: Yong Cc: kbuild test robot , kbuild-all@01.org, Maxime Ripard , Mauro Carvalho Chehab , Rob Herring , Mark Rutland , Chen-Yu Tsai , "David S. Miller" , Greg Kroah-Hartman , Hans Verkuil , Linus Walleij , Randy Dunlap , Stanimir Varbanov , Hugues Fruchet , Yannick Fertre , Philipp Zabel , Arnd Bergmann , Benjamin Gaignard , Ramesh Shanmugasundaram , Sakari Ailus , Rick Chang , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, megous@megous.com Subject: Re: [PATCH v6 2/2] media: V3s: Add support for Allwinner CSI. Message-Id: <20180126110041.f89848325b9ecfb07df387ca@magewell.com> In-Reply-To: <20180126094658.aa70ed3f890464f6051e21e4@magewell.com> References: <1516695531-23349-1-git-send-email-yong.deng@magewell.com> <201801260759.RyNhDZz4%fengguang.wu@intel.com> <20180126094658.aa70ed3f890464f6051e21e4@magewell.com> X-Mailer: Sylpheed 3.6.0 (GTK+ 2.24.30; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1590370608168306586?= X-GMAIL-MSGID: =?utf-8?q?1590622324945790537?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: Hi Maxime, On Fri, 26 Jan 2018 09:46:58 +0800 Yong wrote: > Hi Maxime, > > Do you have any experience in solving this problem? > It seems the PHYS_OFFSET maybe undeclared when the ARCH is not arm. Got it. Should I add 'depends on ARM' in Kconfig? > > On Fri, 26 Jan 2018 08:04:18 +0800 > kbuild test robot wrote: > > > Hi Yong, > > > > I love your patch! Yet something to improve: > > > > [auto build test ERROR on linuxtv-media/master] > > [also build test ERROR on v4.15-rc9 next-20180119] > > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > > > > url: https://github.com/0day-ci/linux/commits/Yong-Deng/dt-bindings-media-Add-Allwinner-V3s-Camera-Sensor-Interface-CSI/20180126-054511 > > base: git://linuxtv.org/media_tree.git master > > config: i386-allmodconfig (attached as .config) > > compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025 > > reproduce: > > # save the attached .config to linux build tree > > make ARCH=i386 > > > > All errors (new ones prefixed by >>): > > > > drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c: In function 'sun6i_csi_update_buf_addr': > > >> drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c:567:31: error: 'PHYS_OFFSET' undeclared (first use in this function); did you mean 'PAGE_OFFSET'? > > dma_addr_t bus_addr = addr - PHYS_OFFSET; > > ^~~~~~~~~~~ > > PAGE_OFFSET > > drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c:567:31: note: each undeclared identifier is reported only once for each function it appears in > > > > vim +567 drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c > > > > 562 > > 563 void sun6i_csi_update_buf_addr(struct sun6i_csi *csi, dma_addr_t addr) > > 564 { > > 565 struct sun6i_csi_dev *sdev = sun6i_csi_to_dev(csi); > > 566 /* transform physical address to bus address */ > > > 567 dma_addr_t bus_addr = addr - PHYS_OFFSET; > > 568 > > 569 regmap_write(sdev->regmap, CSI_CH_F0_BUFA_REG, > > 570 (bus_addr + sdev->planar_offset[0]) >> 2); > > 571 if (sdev->planar_offset[1] != -1) > > 572 regmap_write(sdev->regmap, CSI_CH_F1_BUFA_REG, > > 573 (bus_addr + sdev->planar_offset[1]) >> 2); > > 574 if (sdev->planar_offset[2] != -1) > > 575 regmap_write(sdev->regmap, CSI_CH_F2_BUFA_REG, > > 576 (bus_addr + sdev->planar_offset[2]) >> 2); > > 577 } > > 578 > > > > --- > > 0-DAY kernel test infrastructure Open Source Technology Center > > https://lists.01.org/pipermail/kbuild-all Intel Corporation > > > Thanks, > Yong Thanks, Yong