From: Marek Szyprowski <m.szyprowski@samsung.com>
To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
Russell King <rmk+kernel@arm.linux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Inki Dae <inki.dae@samsung.com>
Subject: [RFC 1/2] arm: cacheflush syscall: process only pages that are in the memory
Date: Fri, 26 Jan 2018 12:14:40 +0100 [thread overview]
Message-ID: <20180126111441.29353-1-m.szyprowski@samsung.com> (raw)
In-Reply-To: <CGME20180126111453eucas1p1330d8561386c3cf2bb457bc22c0d99a8@eucas1p1.samsung.com>
glibc in calls cacheflush syscall on the whole textrels section of the
relocated binaries. However, relocation usually doesn't touch all pages
of that section, so not all of them are read to memory when calling this
syscall. However flush_cache_user_range() function will unconditionally
touch all pages from the provided range, resulting additional overhead
related to reading all clean pages. Optimize this by calling
flush_cache_user_range() only on the pages that are already in the
memory.
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
arch/arm/kernel/traps.c | 25 +++++++++++++++++++------
1 file changed, 19 insertions(+), 6 deletions(-)
diff --git a/arch/arm/kernel/traps.c b/arch/arm/kernel/traps.c
index 5e3633c24e63..a5ec262ab30e 100644
--- a/arch/arm/kernel/traps.c
+++ b/arch/arm/kernel/traps.c
@@ -564,23 +564,36 @@ static int bad_syscall(int n, struct pt_regs *regs)
static inline int
__do_cache_op(unsigned long start, unsigned long end)
{
- int ret;
+ struct vm_area_struct *vma = NULL;
+ int ret = 0;
+ down_read(¤t->mm->mmap_sem);
do {
unsigned long chunk = min(PAGE_SIZE, end - start);
+ if (!vma || vma->vm_end <= start) {
+ vma = find_vma(current->mm, start);
+ if (!vma) {
+ ret = -EFAULT;
+ goto done;
+ }
+ }
+
if (fatal_signal_pending(current))
return 0;
- ret = flush_cache_user_range(start, start + chunk);
- if (ret)
- return ret;
+ if (follow_page(vma, start, 0)) {
+ ret = flush_cache_user_range(start, start + chunk);
+ if (ret)
+ goto done;
+ }
cond_resched();
start += chunk;
} while (start < end);
-
- return 0;
+done:
+ up_read(¤t->mm->mmap_sem);
+ return ret;
}
static inline int
--
2.15.0
next parent reply other threads:[~2018-01-26 11:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180126111453eucas1p1330d8561386c3cf2bb457bc22c0d99a8@eucas1p1.samsung.com>
2018-01-26 11:14 ` Marek Szyprowski [this message]
[not found] ` <CGME20180126111453eucas1p178663ac7b17d0c92cc889a42b3f5bcec@eucas1p1.samsung.com>
2018-01-26 11:14 ` [RFC 2/2] arm64: compat: " Marek Szyprowski
2018-01-26 17:41 ` Catalin Marinas
2018-01-26 18:02 ` Catalin Marinas
2018-01-26 11:32 ` [RFC 1/2] arm: " Russell King - ARM Linux
2018-01-26 13:30 ` Marek Szyprowski
2018-01-26 21:39 ` Russell King - ARM Linux
2018-01-31 6:03 ` Inki Dae
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180126111441.29353-1-m.szyprowski@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=catalin.marinas@arm.com \
--cc=inki.dae@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®