From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x224iGmRF5sVz0vn14tqYeMK3Y6dv/XePq7escWufz1uzxOs4tn3ncxHidCdm2gVf1ijxgscn ARC-Seal: i=1; a=rsa-sha256; t=1516974777; cv=none; d=google.com; s=arc-20160816; b=C54mDMOfEFFEW/3RC2LHBr2TqDiWHs58o1byhSNyEh5nruUC9FJeYK/6DDZQq489Wv bOgKFY4Vfx2AMyqzGMtCZbRQlux8hYQYFJk1002auQabNn93l9sllfgJH3PyIGLXo8NX queIHfR8xmDwc82W1aWnnJZ4Kx/QPvVdn9jXLqJWUgJX0JHHp6xBSWMEEV6l1lpUOKXa qRYstIlu9XRji4GbNOK7g8qKAvqpULSdLZHy5NgJVJ6bpr+DikhXRjJWSr2GjZwfyZr8 L8tZkL5NfylDkH8vtvuC/dKvIBgxp/J5f0l81qyCcBjhi7XbsG2kkMoR2qDljvgunXjQ Cf8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:arc-authentication-results; bh=dHhakMfUjYHLtgYAIiA+V8aQYNRhEKnLMN5dQN/Fb6Q=; b=0C6SbZxBpVgKC3KNXlf5lAeKhXvg7bz9khs5aLNSESBtudQu0qdVnmOti2Ywu08B+l 9N3v07IlHfvSWkKxE5x5CWfERzoy5pVGtyNTn7tXJRVmlQ3FBi3CDiH3fmv9JKROx6+n ScR8G79Ewy1w8bFJGKlnKnGmnleTIoXXju9c66/9JvbdVc0DjZEtR9mIulwNvI+ljFlI FKiDEQFXhaTsnE6tWfW+0IXSywZnAj4JQ28GVdaMlVxaFlObOl1Q9W8/Ex9X4oUA6jF7 MGdDANLIwCkjBkdHT21LtF8GsOWAqCloO+M9skE/bgefaoM54izB7mW0iArXY4pM0UW9 Jl7w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of colin.king@canonical.com designates 91.189.89.112 as permitted sender) smtp.mailfrom=colin.king@canonical.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of colin.king@canonical.com designates 91.189.89.112 as permitted sender) smtp.mailfrom=colin.king@canonical.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com From: Colin King To: Greg Kroah-Hartman , Ping-Ke Shih , devel@driverdev.osuosl.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] staging: rtlwifi: remove redundant initialization of 'cfg_cmd' Date: Fri, 26 Jan 2018 13:52:55 +0000 Message-Id: <20180126135255.18539-1-colin.king@canonical.com> X-Mailer: git-send-email 2.15.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1590663343925260570?= X-GMAIL-MSGID: =?utf-8?q?1590663343925260570?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: From: Colin Ian King The initialization of cfg_cmd is redundant as the value is never read and it is being re-assigned to cfg_cmd = pwrcfgcmd[ary_idx] inside a loop, hence it can be removed. Cleans up clang warning: drivers/staging/rtlwifi/core.c:1819:22: warning: Value stored to 'cfg_cmd' during its initialization is never read Signed-off-by: Colin Ian King --- drivers/staging/rtlwifi/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtlwifi/core.c b/drivers/staging/rtlwifi/core.c index a43d37452e8b..3ec039498208 100644 --- a/drivers/staging/rtlwifi/core.c +++ b/drivers/staging/rtlwifi/core.c @@ -1816,7 +1816,7 @@ bool rtl_hal_pwrseqcmdparsing(struct rtl_priv *rtlpriv, u8 cut_version, u8 faversion, u8 interface_type, struct wlan_pwr_cfg pwrcfgcmd[]) { - struct wlan_pwr_cfg cfg_cmd = {0}; + struct wlan_pwr_cfg cfg_cmd; bool polling_bit = false; u32 ary_idx = 0; u8 value = 0; -- 2.15.1