From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751918AbeAZRcW (ORCPT <rfc822;w@1wt.eu>);
        Fri, 26 Jan 2018 12:32:22 -0500
Received: from heliosphere.sirena.org.uk ([172.104.155.198]:53254 "EHLO
        heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751324AbeAZRcV (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 26 Jan 2018 12:32:21 -0500
Date: Fri, 26 Jan 2018 17:32:18 +0000
From: Mark Brown <broonie@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        linux-spi <linux-spi@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] spi: sprd: Use 'spi_master_put()' instead of
 'spi_controller_put()'
Message-ID: <20180126173218.GF32674@sirena.org.uk>
References: <20180126155256.25956-1-christophe.jaillet@wanadoo.fr>
 <CAMuHMdXMndPDnCYyfxJ8=mrJdWTdn-ANqwGHkY8+BAVUYBm4NA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="ChQOR20MqfxkMJg9"
Content-Disposition: inline
In-Reply-To: <CAMuHMdXMndPDnCYyfxJ8=mrJdWTdn-ANqwGHkY8+BAVUYBm4NA@mail.gmail.com>
X-Cookie: You are standing on my toes.
User-Agent: Mutt/1.9.2 (2017-12-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--ChQOR20MqfxkMJg9
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Jan 26, 2018 at 05:16:34PM +0100, Geert Uytterhoeven wrote:
> On Fri, Jan 26, 2018 at 4:52 PM, Christophe JAILLET
> <christophe.jaillet@wanadoo.fr> wrote:
> > 'spi_alloc_master()' calls should be balanced by a 'spi_master_put()' call.

> > 'spi_controller_put()' is equivalent (see include/linux/spi/spi.h) but it
> > is cleaner and more logical to use 'spi_master_put()'.

> My intention was to phase out the spi_master_* names, and remove them
> when there are no users left.

Yeah, a better change here would be adding the matching allocation
function and using that.

--ChQOR20MqfxkMJg9
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlprZiEACgkQJNaLcl1U
h9BM+Af/Yr4QqNAqW6MHtbb595L/lMcB7slMA58WGBRB1HQ60se2V8WQA9CWitkw
cogpF8D2mluhhFl7ONBb5JYuP6z7tZRuFIx3ODUOTlsUZUQ59Hdir6etcLjrXAyu
adwC7/k2aBDyGLzCucfYLAnQra0pmk1qr6YTQ8y7J4Th4HNgdaQ5e9BDdX2dFnCJ
Xo4PiV5XdeDY+wwGXeqMZFPBtjLQVRuRv9WJ7VLI7bkw/espGihVGwBzcgG0t0fG
Rz2Ss1YJo9CGyfC5oS26yr4188iDnHg7j72dWu77OT5IpEkt9F+QrVnsiWGNG0mh
ARWwbvFYOEVtCDh0GCk/tWJQly6iTA==
=JRM+
-----END PGP SIGNATURE-----

--ChQOR20MqfxkMJg9--