From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x227feeVOL0VTPqLiDNbbrRXiUfGgEMzFeNjsYhmaHk9nw/yz8Pd3vp8Xgtb+cwsAJ38k3I9r ARC-Seal: i=1; a=rsa-sha256; t=1517042055; cv=none; d=google.com; s=arc-20160816; b=Gel9cIGw+y4k8R0aJqFCIbFXI2Jmhayri9ir2w00R5X3GC2eeV0A2R2L4igTuR0tb5 AYlZD5NYZ+guUE3EM8XrMfzNtXypDCplDNCvjb1O6aBTjminJHhrSFXSgwlDuhVjE3Mg B++sBcNlCjhnga/98xd6XzUg5qR/xsDCEksmDnliQjgdJo8hKqOf8zmcGIvhQgDc6jxH oOm/32XB74uy63qlsA1cBKo/gIVwcxwhT+He0ojiieZWmyzn8PrZZhv6vEvK+21WPdQj reT826NhoHB+WlOjewhcC7KYBskyigrkyb8hI9UsU32O4YQbGn7nLxaJOz+sPxsJTsmZ zs6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:subject:cc:to:from:arc-authentication-results; bh=jUtyKgutt7uAP9MiFio0RmUCcrdHARY3swng16e0Brk=; b=m+NyrE9GvV8oB2M4dVRLnotr9GnxoXluAvmfU+nv0iGiZiWkVpz4JPCO0JJIeCTNam 516cLvrXxJWFBX/jy1qY+pZ6tmNiLGeqaXzqcKVswqiRvMH3QN9P6s+y1zuDPME2JPgh NlTUaJl8QnOv9F3wAceh1LFBDK+0hFHVVgADlSvdPvVhN+9Rbwgi95bZTZopXVh4dIDM 7mXuQ9rv1+RT8kvzrlu9VLxhde3sn5OBoqFJyDUTnlzM7xWBVe9iaKuCtjqhWuybqjGn +FnoG6EcvgVsvlKUUd9wM9LCSLDmBQ/tE+r7YdABWWH2cbaq93mLhVIb/5rtMYRDE2jv YDKg== ARC-Authentication-Results: i=1; mx.google.com; spf=neutral (google.com: 2a01:238:43f3:0:615b:ee97:1f81:cbf2 is neither permitted nor denied by best guess record for domain of andreas@kemnade.info) smtp.mailfrom=andreas@kemnade.info Authentication-Results: mx.google.com; spf=neutral (google.com: 2a01:238:43f3:0:615b:ee97:1f81:cbf2 is neither permitted nor denied by best guess record for domain of andreas@kemnade.info) smtp.mailfrom=andreas@kemnade.info From: Andreas Kemnade To: b-liu@ti.com, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Tony Lindgren , Discussions about the Letux Kernel Cc: Andreas Kemnade Subject: [PATCH] usb: musb: fix enumeration after resume Date: Sat, 27 Jan 2018 09:34:03 +0100 Message-Id: <20180127083403.928-1-andreas@kemnade.info> X-Mailer: git-send-email 2.11.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1590733890514552620?= X-GMAIL-MSGID: =?utf-8?q?1590733890514552620?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On dm3730 there are enumeration problems after resume. Investigation led to the cause that the MUSB_POWER_SOFTCONN bit is not set. If it was set before suspend (because it was enabled via musb_pullup()), it is set in musb_restore_context() so the pullup is enabled. But then musb_start() is called which overwrites MUSB_POWER and therefore disables MUSB_POWER_SOFTCONN, so no pullup is enabled and the device is not enumerated. So let's do a subset of what musb_start() does in the same way as musb_suspend() does it. Platform-specific stuff it still called as there might be some phy-related stuff which needs to be enabled. Also interrupts are enabled, as it was the original idea of calling musb_start() in musb_resume() according to Commit 6fc6f4b87cb3 ("usb: musb: Disable interrupts on suspend, enable them on resume") Signed-off-by: Andreas Kemnade --- drivers/usb/musb/musb_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c index ea5013aa69e2..255424aae513 100644 --- a/drivers/usb/musb/musb_core.c +++ b/drivers/usb/musb/musb_core.c @@ -2709,7 +2709,8 @@ static int musb_resume(struct device *dev) if ((devctl & mask) != (musb->context.devctl & mask)) musb->port1_status = 0; - musb_start(musb); + musb_enable_interrupts(musb); + musb_platform_enable(musb); spin_lock_irqsave(&musb->lock, flags); error = musb_run_resume_work(musb); -- 2.11.0