From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-1029900-1517046312-2-17493859136868532070 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.001, RCVD_IN_DNSWL_MED -2.3, SPF_PASS -0.001, LANGUAGES unknown, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='140.211.166.137', Host='smtp4.osuosl.org', Country='US', FromHeader='hr', MailFrom='org' X-Spam-charsets: cc='UTF-8', plain='us-ascii' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: driverdev-devel-bounces@linuxdriverproject.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1517046312; b=VLvmXCYjUtPA/ihYTynO3LSyISpS1OKAyp12izqn19kSC47 bL24Etqd5dVFryknMtzbVXhdHsDRP/IzkbsxdY0Y/l8uhFOY73Rkp0HHAWo0G/Fo jNWloGQQK/41xIhaiqEwn6FTkATcFM2l0+30v5fR07RvlvW/YsSGuSfwotjznngf G70mquJzCZ+gNyT/KQYxLez+7qCmVrT66FIPlTiidzhwutZ3kEz0ySiRsvscvPE6 aiMT8Ltt9F+gH89L1dps7lhKrOIqawQ5B0kLvmLXqSjsOPCcHqeJHt2x/aA/g36e +rw7wIRbshZYKnb3Eq5NUep7gUsIIE3Fq9E3E+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:date:message-id:in-reply-to :references:subject:list-id:list-unsubscribe:list-archive :list-post:list-help:list-subscribe:cc:mime-version:content-type :content-transfer-encoding:sender; s=arctest; t=1517046312; bh=k IGyfN1BM42Y8K8f1xwRh6fI9EvE9oFBHrAWnNJkfcQ=; b=QspW3rHRx4lcNmmKg xCzsUmxmMJCaPUcCS8icTrQj7LZRH96ZOLi/HAgEwTyUILywbkj0OMlzxYzuHHNU HpF/LRMrNJYQcKgwR9XEluRFIj/Y/z5N2bi80c3K8CMYKSmM64jy4WCrkPK7Myyq uMhzUKnNvkIR5Pfhwzslbt7ibJeeLBxa7HMKky/uU9xvpIDKv6nzjcpCN36rN6LP q35qiRd3Vj/gnGR9Sv/J/e2XtyRbMlTTqwtIuCOiqbl2yzLq2UdKjzudn/23N7E/ zL/0FF7I+dR+I85c9a6eRUBmPGtgBRq5BEsOyfM1DR6ZFxHHK1963L9KAf0OrHIv WHUxQ== ARC-Authentication-Results: i=1; mx2.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=carnet.hr; iprev=pass policy.iprev=140.211.166.137 (smtp4.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=fraxinus.osuosl.org; x-aligned-from=fail; x-ptr=fail x-ptr-helo=fraxinus.osuosl.org x-ptr-lookup=smtp4.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=carnet.hr header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128 Authentication-Results: mx2.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=carnet.hr; iprev=pass policy.iprev=140.211.166.137 (smtp4.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=fraxinus.osuosl.org; x-aligned-from=fail; x-ptr=fail x-ptr-helo=fraxinus.osuosl.org x-ptr-lookup=smtp4.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=carnet.hr header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128 X-Remote-Delivered-To: driverdev-devel@osuosl.org From: Valentin Vidic To: Greg Kroah-Hartman Date: Sat, 27 Jan 2018 10:42:16 +0100 Message-Id: <20180127094233.20234-7-Valentin.Vidic@CARNet.hr> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180127094233.20234-1-Valentin.Vidic@CARNet.hr> References: <20180127094233.20234-1-Valentin.Vidic@CARNet.hr> X-SA-Exim-Connect-IP: 161.53.12.131 Subject: [PATCH 7/8] staging: pi433: fix CamelCase for regValue X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.24 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Michael Panzlaff , Valentin Vidic , linux-kernel@vger.kernel.org, Marcin Ciupak , Marcus Wolf , =?UTF-8?q?Simon=20Sandstr=C3=B6m?= MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: Local variable storing the new value for dio register so replace with dio_value. Update regaddr to dio_addr to match. Fixes checkpatch warnings: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/rf69.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c index ef56deccd0af..42c2e1c6b386 100644 --- a/drivers/staging/pi433/rf69.c +++ b/drivers/staging/pi433/rf69.c @@ -505,27 +505,27 @@ int rf69_set_dio_mapping(struct spi_device *spi, u8 DIONumber, u8 value) { u8 mask; u8 shift; - u8 regaddr; - u8 regValue; + u8 dio_addr; + u8 dio_value; switch (DIONumber) { case 0: - mask = MASK_DIO0; shift = SHIFT_DIO0; regaddr = REG_DIOMAPPING1; + mask = MASK_DIO0; shift = SHIFT_DIO0; dio_addr = REG_DIOMAPPING1; break; case 1: - mask = MASK_DIO1; shift = SHIFT_DIO1; regaddr = REG_DIOMAPPING1; + mask = MASK_DIO1; shift = SHIFT_DIO1; dio_addr = REG_DIOMAPPING1; break; case 2: - mask = MASK_DIO2; shift = SHIFT_DIO2; regaddr = REG_DIOMAPPING1; + mask = MASK_DIO2; shift = SHIFT_DIO2; dio_addr = REG_DIOMAPPING1; break; case 3: - mask = MASK_DIO3; shift = SHIFT_DIO3; regaddr = REG_DIOMAPPING1; + mask = MASK_DIO3; shift = SHIFT_DIO3; dio_addr = REG_DIOMAPPING1; break; case 4: - mask = MASK_DIO4; shift = SHIFT_DIO4; regaddr = REG_DIOMAPPING2; + mask = MASK_DIO4; shift = SHIFT_DIO4; dio_addr = REG_DIOMAPPING2; break; case 5: - mask = MASK_DIO5; shift = SHIFT_DIO5; regaddr = REG_DIOMAPPING2; + mask = MASK_DIO5; shift = SHIFT_DIO5; dio_addr = REG_DIOMAPPING2; break; default: dev_dbg(&spi->dev, "set: illegal input param"); @@ -533,13 +533,13 @@ int rf69_set_dio_mapping(struct spi_device *spi, u8 DIONumber, u8 value) } // read reg - regValue = rf69_read_reg(spi, regaddr); + dio_value = rf69_read_reg(spi, dio_addr); // delete old value - regValue = regValue & ~mask; + dio_value = dio_value & ~mask; // add new value - regValue = regValue | value << shift; + dio_value = dio_value | value << shift; // write back - return rf69_write_reg(spi, regaddr, regValue); + return rf69_write_reg(spi, dio_addr, dio_value); } bool rf69_get_flag(struct spi_device *spi, enum flag flag) -- 2.15.1 _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel