From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752822AbeA0Un4 (ORCPT ); Sat, 27 Jan 2018 15:43:56 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:49467 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752439AbeA0Unz (ORCPT ); Sat, 27 Jan 2018 15:43:55 -0500 Date: Sat, 27 Jan 2018 21:43:50 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: =?iso-8859-1?Q?Beno=EEt_Th=E9baudeau?= Cc: Mark Rutland , devicetree@vger.kernel.org, linux-kernel , Russell King , Rob Herring , Sascha Hauer , Fabio Estevam , Michael Nazzareno Trimarchi , Shawn Guo , linux-arm-kernel Subject: Re: [PATCH] ARM: dts: imx25-pinfunc: Always set SION for SD CMD Message-ID: <20180127204350.3xswhyvvae6w4w2c@pengutronix.de> References: <20180127000752.2879-1-benoit.thebaudeau.dev@gmail.com> <20180127153733.7ziaq6frli3jemc7@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 27, 2018 at 09:37:11PM +0100, Benoît Thébaudeau wrote: > On Sat, Jan 27, 2018 at 4:37 PM, Uwe Kleine-König > wrote: > > On Sat, Jan 27, 2018 at 01:07:52AM +0100, Benoît Thébaudeau wrote: > >> The eSDHC does not work properly if the SION bit is not set for the > >> bidirectional CMD signal, whatever the eSDHC instance and the selected > >> pad. Therefore, setting SION is mandatory for all eSDHC CMD ports. Do > >> this for MX25_PAD_*__SD*_CMD in imx25-pinfunc.h in order to enforce this > >> behavior for all boards. > >> > >> This had already been done for eSDHC1, but not for eSDHC2. Also, define > >> MX25_PAD_FEC_MDC__SDHC2_CMD so that all the possible cases are covered > >> from now on. > > > > There is an inconsistency in the naming. The eSDHC1 CMD constants are > > named: > > > > MX25_PAD_SD1_CMD__SD1_CMD > > > > The reference calls this: > > > > CMD of instance: esdhc1. > > > > The register name is correct though. Not sure it's worth to fix this to > > use consistent naming (which would result in: > > > > MX25_PAD_SD1_CMD__ESDHC1_CMD > > > > which looks ugly, too). > > Indeed. I had also noticed this. I can send a patch to apply before > this one. But that would break the out-of-tree DT files using these > definitions. Would that be OK? One possibility is to do something like this: #define MX25_PAD_SD1_CMD__ESDHC1_CMD X Y Z ... ... /* * compat defines for out-of-tree users. Yes, you should update when you * make use of one of them. */ #define MX25_PAD_SD1_CMD__SD1_CMD MX25_PAD_SD1_CMD__ESDHC1_CMD This would also allow to fix the users in a separate step. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |