From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-1164045-1517178547-2-15150308977628566011 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.001, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES enro, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='com', MailFrom='org', XOriginatingCountry='US' X-Spam-charsets: plain='iso-8859-1' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1517178546; b=i0IZvsxB5s784Ry01ELgwZhi0Ok7l49TD28mj+s1nIbYulF ih0ol4v6iYjeJ6gh/F06Dkm7yf2m4jkP6vuauheSSIcjqnG3en7l0mxmjw0wKD0r r7OsEgYXQ7qYHOxpex2DeyniM6Mv7ON7xJMNfEkr9/+u9ZA/eUoJuCqyfzL/bLbu VDmj40BpHvKdkNUIwF/0bA/kl/pv8kSafjRw4IsVE9fp3HHo5zBW1noO3+VVI7Bk GXi6fRhrkqcU92b+b5sxwI6MwYwsLyuVn0lVxFWzgG5bSETvq/h70pO0iUFga0os kNSIhc0dmNhotNSr1V2lL0ksmdWTW5IcBQ9QxYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id :references:in-reply-to:content-type:content-transfer-encoding :mime-version:sender:list-id; s=arctest; t=1517178546; bh=HyhcR3 JKXO6mtBBhspLm8Vrt7UWIJ8kSrDnm8joT7KY=; b=sv0SlNE+TcYuWMmTfxXhTG /o0RgnrYUDWGqSV4nffvnlqqZzmu4oLWUJyROkS00TniCgTdE7OnqSetO/f4yY5V vQ7CkfcaGPZCWQiocOrPSLZCqYlSKThovewOAXsItEl5tdDAb2xApmUSWNJA0Q4o 9taSqevkcetVHzvDI//LI0Ywf6CGTsELAEp5fanLiQCHVuKM+dkhF/YhQRc8UPhw n+xk9dq8EOa+jAQUru/Z86WugsTzt9i6hAQO7fwA3k2DUsPwzDGh1e76MfKCow05 CpO/uQmeqhIBC9NZcrGIauH4x+qIzlng6W2M5Onrqo6bhZ753Ab3JF48qzPGOtEA == ARC-Authentication-Results: i=1; mx3.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=nr/wj/3l x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Authentication-Results: mx3.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=nr/wj/3l x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753081AbeA1W3D (ORCPT ); Sun, 28 Jan 2018 17:29:03 -0500 Received: from mail-dm3nam03on0120.outbound.protection.outlook.com ([104.47.41.120]:15392 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753441AbeA1W3B (ORCPT ); Sun, 28 Jan 2018 17:29:01 -0500 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: Stefan Haberland , Martin Schwidefsky , Sasha Levin Subject: [PATCH AUTOSEL for 4.9 21/49] s390/dasd: prevent prefix I/O error Thread-Topic: [PATCH AUTOSEL for 4.9 21/49] s390/dasd: prevent prefix I/O error Thread-Index: AQHTmIc6S917dVuBHkSWDPGfGQf1rQ== Date: Sun, 28 Jan 2018 22:27:49 +0000 Message-ID: <20180128222727.22404-21-alexander.levin@microsoft.com> References: <20180128222727.22404-1-alexander.levin@microsoft.com> In-Reply-To: <20180128222727.22404-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;MW2PR2101MB1097;7:fH1XbYvjobJebjRZ1YKSXpiC5xQcGOHLeakMgvTvxhdPpMuT4jATSfwQCwwZlJQW7AmomxOdu4IJOj9aKxOZY4xj3P8UqQPZEO3emIaAjppSvJy3SPzumds4AgDcWP12tSijcCqz0YNjas9n4mUTIWD+jR6vikg1AGdF/gFLC39YmEC4Jam5z+cOH0KoueS+Bs/sDbmdy+1vTaIzLGMnV0adDYyjPuXRr1tL2l1MyA3LGdg3tBGf/wR0onD5AOIW x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: f2b11350-1721-4640-b890-08d5669e867e x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7193020);SRVR:MW2PR2101MB1097; x-ms-traffictypediagnostic: MW2PR2101MB1097: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(190383065149520)(104084551191319); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(61425038)(6040501)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(3231101)(944501161)(6055026)(61426038)(61427038)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(20161123562045)(20161123560045)(6072148)(201708071742011);SRVR:MW2PR2101MB1097;BCL:0;PCL:0;RULEID:;SRVR:MW2PR2101MB1097; x-forefront-prvs: 05669A7924 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(346002)(366004)(39380400002)(39860400002)(396003)(376002)(199004)(189003)(72206003)(14454004)(3280700002)(106356001)(4326008)(478600001)(10290500003)(76176011)(102836004)(3660700001)(59450400001)(25786009)(6506007)(105586002)(316002)(6486002)(97736004)(22452003)(186003)(99286004)(110136005)(54906003)(107886003)(26005)(86362001)(8676002)(81156014)(2906002)(1076002)(81166006)(68736007)(3846002)(6116002)(305945005)(7736002)(36756003)(86612001)(10090500001)(6512007)(2950100002)(66066001)(5660300001)(53936002)(6666003)(8936002)(6436002)(2501003)(2900100001)(5250100002)(22906009)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:MW2PR2101MB1097;H:MW2PR2101MB1034.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; x-microsoft-antispam-message-info: htfTz2GjXRfOfgDpdk7wjWvF6xt63r8bHAnjLdFvnJEI6RCCGOhgJ6TVodUGgTEHtXDshSBwuR8A1niNVg2lWQ== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: f2b11350-1721-4640-b890-08d5669e867e X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jan 2018 22:27:49.8960 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR2101MB1097 Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: From: Stefan Haberland [ Upstream commit da340f921d3454f1521671c7a5a43ad3331fbe50 ] Prevent that a prefix flag is set based on invalid configuration data. The validity.verify_base flag should only be set for alias devices. Usually the unit address type is either one of base, PAV alias or HyperPAV alias. But in cases where the unit address type is not set or any other value the validity.verify_base flag might be set as well. This would lead to follow on errors. Explicitly check for alias devices and set the validity flag only for them. Signed-off-by: Stefan Haberland Reviewed-by: Jan Hoeppner Signed-off-by: Martin Schwidefsky Signed-off-by: Sasha Levin --- drivers/s390/block/dasd_eckd.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/s390/block/dasd_eckd.c b/drivers/s390/block/dasd_eckd.= c index a7a88476e215..0f5bc2f8382b 100644 --- a/drivers/s390/block/dasd_eckd.c +++ b/drivers/s390/block/dasd_eckd.c @@ -521,10 +521,12 @@ static int prefix_LRE(struct ccw1 *ccw, struct PFX_ec= kd_data *pfxdata, pfxdata->validity.define_extent =3D 1; =20 /* private uid is kept up to date, conf_data may be outdated */ - if (startpriv->uid.type !=3D UA_BASE_DEVICE) { + if (startpriv->uid.type =3D=3D UA_BASE_PAV_ALIAS) pfxdata->validity.verify_base =3D 1; - if (startpriv->uid.type =3D=3D UA_HYPER_PAV_ALIAS) - pfxdata->validity.hyper_pav =3D 1; + + if (startpriv->uid.type =3D=3D UA_HYPER_PAV_ALIAS) { + pfxdata->validity.verify_base =3D 1; + pfxdata->validity.hyper_pav =3D 1; } =20 /* define extend data (mostly)*/ @@ -3471,10 +3473,12 @@ static int prepare_itcw(struct itcw *itcw, pfxdata.validity.define_extent =3D 1; =20 /* private uid is kept up to date, conf_data may be outdated */ - if (startpriv->uid.type !=3D UA_BASE_DEVICE) { + if (startpriv->uid.type =3D=3D UA_BASE_PAV_ALIAS) + pfxdata.validity.verify_base =3D 1; + + if (startpriv->uid.type =3D=3D UA_HYPER_PAV_ALIAS) { pfxdata.validity.verify_base =3D 1; - if (startpriv->uid.type =3D=3D UA_HYPER_PAV_ALIAS) - pfxdata.validity.hyper_pav =3D 1; + pfxdata.validity.hyper_pav =3D 1; } =20 switch (cmd) { --=20 2.11.0