From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-1372482-1517179897-2-2194178154648588149 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.001, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES unknown, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='com', MailFrom='org', XOriginatingCountry='US' X-Spam-charsets: plain='iso-8859-1' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1517179897; b=bDZB/3JifKirOD//zxGq86e9fEkeE1XcuIj6DKEbevc+DDL PiysO8ukGH9gWwFj25wGT2tAzKyICZuGIU3LqrxnXmGmpF+aWipU/slHc54hDm1N euhC1Rxp3LJoUPsAFK+7UPyUomnvc0fr5euUoU+V4ZreT0FDHij4yKHs6v8lMWTN 54lcd6Cvmy7bz3po05yrB2++H/RiL9waoNU8p2Q8CwXNFAbg/w5AYqSv8EdJHhiO I4xtg4XYRBO2bLWL+/Rc8STlPIQku9YxoF98PGeWXp/vJEb/TQvDTPEJAYMeAOtX yhA2lg/Tir8vlTUjnbATULVfhrKn6LeJmrp+mBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id :references:in-reply-to:content-type:content-transfer-encoding :mime-version:sender:list-id; s=arctest; t=1517179897; bh=WfoaEM DMGLOD9pzNi4c5CtzSYDfF/E7BHoAc8Irnawg=; b=YpUsDR8mLmErLFXxVARtkM NaBwrYoiWuE5mYUycw2GGpeoFSj8dS7QHQPYyTTs9y6QF/22t16R5gXyr/Ddk6p+ 6dsnQBagFpt/KoYldxRPAo1eNt1vjZVPvaG7VVIuoO6iEvDDJHT3KXSEQq7nYsWQ qNybd3/OVBDg3ngyGRnGBjMr6dfhdjsdP6dTLXKkaeS/RwoA64kyd3ZXq9PsucoR 5d7K/8HBTuPuUDvdUWl58xM93wejWZ/LRbA0+GZohdzS+pt0XbZLsDYvjvs/cqEP EjtFSxt/rgh1Rq+hLx1pcyuiVVG5NIUVhNKcDfaVo7A/yg7Fl2rDhS6QkEW7njJg == ARC-Authentication-Results: i=1; mx3.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=atkTH++1 x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Authentication-Results: mx3.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=atkTH++1 x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932814AbeA1WvJ (ORCPT ); Sun, 28 Jan 2018 17:51:09 -0500 Received: from mail-dm3nam03on0120.outbound.protection.outlook.com ([104.47.41.120]:15392 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753174AbeA1W3E (ORCPT ); Sun, 28 Jan 2018 17:29:04 -0500 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: Nogah Frankel , "David S . Miller" , Sasha Levin Subject: [PATCH AUTOSEL for 4.9 24/49] net_sched: red: Avoid devision by zero Thread-Topic: [PATCH AUTOSEL for 4.9 24/49] net_sched: red: Avoid devision by zero Thread-Index: AQHTmIc7NjtbDHbLPk+5PeI8FKC4Jw== Date: Sun, 28 Jan 2018 22:27:51 +0000 Message-ID: <20180128222727.22404-24-alexander.levin@microsoft.com> References: <20180128222727.22404-1-alexander.levin@microsoft.com> In-Reply-To: <20180128222727.22404-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;MW2PR2101MB1097;7:f6nRcnZDvR9WmZ5CYx+yEIr9TJbpy35kn04lWaxd9SO8M0xXvrJnyZZ/VK3UBC++fQiRo6y7iPZ1Cr5mXWBtWeerqbXY2TAZwQ02Q2wwjkxAyd9F6WRNlgeDgKshBLPcy0WIZ0cGN5Wc9wwM8bbNknrdbRkvBHMw3fKBSNZ7Whs2AhnkZPwCW55rqa9UBRVFiPejuVShxMRUsw60IrgpeE4+e0hq/l9+UFvzYXlaQqcEDRpzSCrDo7DLObj4cWmK x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 9e8e8b8b-7a38-4ce7-2d91-08d5669e8737 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7193020);SRVR:MW2PR2101MB1097; x-ms-traffictypediagnostic: MW2PR2101MB1097: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(61425038)(6040501)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(3231101)(944501161)(6055026)(61426038)(61427038)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(20161123562045)(20161123560045)(6072148)(201708071742011);SRVR:MW2PR2101MB1097;BCL:0;PCL:0;RULEID:;SRVR:MW2PR2101MB1097; x-forefront-prvs: 05669A7924 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(346002)(366004)(39380400002)(39860400002)(396003)(376002)(199004)(189003)(72206003)(14454004)(3280700002)(106356001)(4326008)(478600001)(10290500003)(76176011)(102836004)(3660700001)(59450400001)(25786009)(6506007)(105586002)(316002)(6486002)(97736004)(22452003)(186003)(575784001)(99286004)(110136005)(54906003)(107886003)(26005)(86362001)(8676002)(81156014)(2906002)(1076002)(81166006)(68736007)(3846002)(6116002)(305945005)(7736002)(36756003)(86612001)(10090500001)(6512007)(2950100002)(66066001)(5660300001)(53936002)(6666003)(8936002)(6436002)(2501003)(2900100001)(5250100002)(22906009)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:MW2PR2101MB1097;H:MW2PR2101MB1034.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; x-microsoft-antispam-message-info: 8II+gkcDE9FNHhf3ncEIbi6uWTHPiF6bu0xgY1jt+khFXFnw7FVdgS78fMCL1U0Ih6kwTZC8Rung3RCxXR0Lxg== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9e8e8b8b-7a38-4ce7-2d91-08d5669e8737 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jan 2018 22:27:51.6232 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR2101MB1097 Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: From: Nogah Frankel [ Upstream commit 5c472203421ab4f928aa1ae9e1dbcfdd80324148 ] Do not allow delta value to be zero since it is used as a divisor. Fixes: 8af2a218de38 ("sch_red: Adaptative RED AQM") Signed-off-by: Nogah Frankel Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- include/net/red.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/net/red.h b/include/net/red.h index 76e0b5f922c6..ba5039418a93 100644 --- a/include/net/red.h +++ b/include/net/red.h @@ -178,7 +178,7 @@ static inline void red_set_parms(struct red_parms *p, p->qth_max =3D qth_max << Wlog; p->Wlog =3D Wlog; p->Plog =3D Plog; - if (delta < 0) + if (delta <=3D 0) delta =3D 1; p->qth_delta =3D delta; if (!max_P) { --=20 2.11.0