From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-1372482-1517180248-2-17124651440886181729 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.001, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='com', MailFrom='org', XOriginatingCountry='US' X-Spam-charsets: plain='iso-8859-1' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1517180248; b=pRQymHMcaQrU9qNK+EhjfY/5F2gXW/eDLZXYgQrA+bIwW2C fLawrJ/BJWq+7DXPGO/1GqpwMCuIq3x2X6IxHOPuLmOHXK2vRZQ1T4riwsXKhFvK RS3ytsTABo4ebkoihuIG+EXVYSSSj3QVzGnuuYx7gNPsT5doY81MaLQ6gfMIa+A+ z36totqZCWJug+3iyApA7kppp94L4uYetvujLtfmgiJUKsZ93ouhLsj5n6mF9ofD CRTgmXAtta36DA3iOSSKxABndyzmDOmdyME8ZUDfeEzDZCKuxywXe3go8cuR8khM QLQREsByULcyD8iOYosAbaXBMmwzbQo6xTgWGPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id :references:in-reply-to:content-type:content-transfer-encoding :mime-version:sender:list-id; s=arctest; t=1517180248; bh=XSDnyt iJLTIBX4VqevmLnl2iI3agCUpsTENg7pD8C0E=; b=t+HuaLz91/ow88GuM2Iarc /dF/RzjBcZVs63f5EGypZxeqMoXUeZFpVLheH0n6FPGRxa1Q+q9q4bbDbbg/pZAr RkQI7BFzdqJe9OaLtVif2V5LjOP+6p4H//6nNY7Mefzz4TorNQXzVeKuCB8ohvuF nWMT1wGqvyPKAIk909UsIMa0oOjF39upfa1XhsHzmuPiXvqdW8CEOHBTYBXSdvKy h2s8ZE8EWsH/q5I8c+IQ1NqatUqbnIkZSgY93aGZ1CfW5o7WsLYtvRChxiWHnD94 z8JJwUmYpczpxFsSwBVz6Yy2Pdg9kYMP98ltQR4xLRTVkQ/hS1AV++CUxf2WtwKw == ARC-Authentication-Results: i=1; mx6.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=Rz5nZVjq x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Authentication-Results: mx6.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=Rz5nZVjq x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932834AbeA1W5O (ORCPT ); Sun, 28 Jan 2018 17:57:14 -0500 Received: from mail-by2nam03on0130.outbound.protection.outlook.com ([104.47.42.130]:20166 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932084AbeA1W21 (ORCPT ); Sun, 28 Jan 2018 17:28:27 -0500 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: Keerthy , Tony Lindgren , Sasha Levin Subject: [PATCH AUTOSEL for 4.9 03/49] ARM: AM33xx: PRM: Remove am33xx_pwrdm_read_prev_pwrst function Thread-Topic: [PATCH AUTOSEL for 4.9 03/49] ARM: AM33xx: PRM: Remove am33xx_pwrdm_read_prev_pwrst function Thread-Index: AQHTmIczy6skJJ/5G02V1Q04braBTA== Date: Sun, 28 Jan 2018 22:27:37 +0000 Message-ID: <20180128222727.22404-3-alexander.levin@microsoft.com> References: <20180128222727.22404-1-alexander.levin@microsoft.com> In-Reply-To: <20180128222727.22404-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;MW2PR2101MB1017;7:7fB6m1m5v4ag8yGxdnQEXX4Odnsh/SaFYaDslxHYcPKMICLd8u7bI+iznnn5hQRUaq6tKv9qAn1badVEUSw+S3AUdo0/ZGMJEXZIe29Ryjb2o7QzqRS/CLhF+3ALLpS5wqJVOwaWbzoeWqPfyghPJUJYYnuhN4DtvfeTomhCKApOrXulwdRFA4F3HP1aasBSSM63pllN8fnDR2V923TsEcjGe0ZeCTq2ESFGGWs/LbrSry2J4p4VLTqxkft54k9n x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 3566a92e-1557-4701-cce8-08d5669e6fde x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7193020);SRVR:MW2PR2101MB1017; x-ms-traffictypediagnostic: MW2PR2101MB1017: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(31051911155226)(89211679590171)(106291317490208); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(61425038)(6040501)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3231101)(944501161)(3002001)(6055026)(61426038)(61427038)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123558120)(20161123560045)(20161123564045)(6072148)(201708071742011);SRVR:MW2PR2101MB1017;BCL:0;PCL:0;RULEID:;SRVR:MW2PR2101MB1017; x-forefront-prvs: 05669A7924 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(396003)(39860400002)(39380400002)(366004)(346002)(376002)(189003)(199004)(81156014)(6666003)(305945005)(2900100001)(76176011)(68736007)(86612001)(3660700001)(8676002)(3280700002)(6506007)(102836004)(6116002)(105586002)(7736002)(2950100002)(3846002)(1076002)(106356001)(36756003)(5660300001)(2906002)(8936002)(66066001)(10090500001)(6486002)(6512007)(25786009)(53936002)(186003)(316002)(6436002)(86362001)(575784001)(14454004)(478600001)(6306002)(2501003)(966005)(5250100002)(72206003)(99286004)(97736004)(107886003)(4326008)(15760500003)(54906003)(81166006)(110136005)(26005)(10290500003)(22452003)(22906009)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:MW2PR2101MB1017;H:MW2PR2101MB1034.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; x-microsoft-antispam-message-info: t01hGSn34Jj96Kmqx3GEJONDGdGUQuwBrLdzSz8a8v2f0LtuoOK4OcfhVtYzyN3moVLoNa/cn46orjtGH/nc9w== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3566a92e-1557-4701-cce8-08d5669e6fde X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jan 2018 22:27:37.1480 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR2101MB1017 Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: From: Keerthy [ Upstream commit b6d6af7226465b6d11eac09d0be2ab78a4a9eb62 ] Referring TRM Am335X series: http://www.ti.com/lit/ug/spruh73p/spruh73p.pdf The LastPowerStateEntered bitfield is present only for PM_CEFUSE domain. This is not present in any of the other power domains. Hence remove the generic am33xx_pwrdm_read_prev_pwrst hook which wrongly reads the reserved bit fields for all the other power domains. Reading the reserved bits leads to wrongly interpreting the low power transitions for various power domains that do not have the LastPowerStateEntered field. The pm debug counters values are wrong currently as we are incrementing them based on the reserved bits. Signed-off-by: Keerthy Signed-off-by: Tony Lindgren Signed-off-by: Sasha Levin --- arch/arm/mach-omap2/prm33xx.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/arch/arm/mach-omap2/prm33xx.c b/arch/arm/mach-omap2/prm33xx.c index dcb5001d77da..973bcd754e1c 100644 --- a/arch/arm/mach-omap2/prm33xx.c +++ b/arch/arm/mach-omap2/prm33xx.c @@ -176,17 +176,6 @@ static int am33xx_pwrdm_read_pwrst(struct powerdomain = *pwrdm) return v; } =20 -static int am33xx_pwrdm_read_prev_pwrst(struct powerdomain *pwrdm) -{ - u32 v; - - v =3D am33xx_prm_read_reg(pwrdm->prcm_offs, pwrdm->pwrstst_offs); - v &=3D AM33XX_LASTPOWERSTATEENTERED_MASK; - v >>=3D AM33XX_LASTPOWERSTATEENTERED_SHIFT; - - return v; -} - static int am33xx_pwrdm_set_lowpwrstchange(struct powerdomain *pwrdm) { am33xx_prm_rmw_reg_bits(AM33XX_LOWPOWERSTATECHANGE_MASK, @@ -357,7 +346,6 @@ struct pwrdm_ops am33xx_pwrdm_operations =3D { .pwrdm_set_next_pwrst =3D am33xx_pwrdm_set_next_pwrst, .pwrdm_read_next_pwrst =3D am33xx_pwrdm_read_next_pwrst, .pwrdm_read_pwrst =3D am33xx_pwrdm_read_pwrst, - .pwrdm_read_prev_pwrst =3D am33xx_pwrdm_read_prev_pwrst, .pwrdm_set_logic_retst =3D am33xx_pwrdm_set_logic_retst, .pwrdm_read_logic_pwrst =3D am33xx_pwrdm_read_logic_pwrst, .pwrdm_read_logic_retst =3D am33xx_pwrdm_read_logic_retst, --=20 2.11.0