From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-1372483-1517179867-2-16032417683548466837 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.001, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='com', MailFrom='org', XOriginatingCountry='US' X-Spam-charsets: plain='iso-8859-1' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1517179866; b=SdzFmjLMk42qKuLvxhJDG9E3T8F7PnRSc/0PO9cZorjRMiM bv+I+neAwajBt1kddK5GrYa1Pte2d+FsFg819p8MHHMhxurQXtFKSHpeThG2hIWd T0Tn+RZnufuBqRa2QFyupgW4LcF7AQAutjFDMJizLsb2TuEe28l2rfC+xXCb29M9 jtQfYVx29grIQZtSn4LBK2WAjoMLolUu9t5AC1XzfX9y5i7snmXWzYbrC1i6Ddq8 Ubwji3JFtLtOPmQAfFlI/XOumd2SGwbhsblhMh+tugEgUhhjpEl1W6Uc4sguE2B4 0cHR4jvLF2uk7LpQ0l1Mf2xiKPxGQeOSBiO8QkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id :references:in-reply-to:content-type:content-transfer-encoding :mime-version:sender:list-id; s=arctest; t=1517179866; bh=YpDEzQ HtOyoZ0zC4i0zAzPBoDIT6c7ipR5Z5+S8rdsQ=; b=OAnqDEcxyibf7WUbejm5IA sXrJmZShBRsie668NY+fXMB7zzfkIfYAUsEO2vVnf4IIvwynh7Hi5JepUJBhHZgL dqL8/sud+N87z166cohb1r5UmPx495rqpw+jgVoizB7XC6oiUuKAoyBHgxG5UgLd LXH+26ttKREA6aJWRuWeGL23eu5aJpxQP52EJwQU16siYzWHxtwhFWd8SCDkHNk8 7HO7M9uiVqThhEOetp6/i1xr2snqNrxnhDZm0ycbcLz78c2IHudA0g+MTgJB817r QDe92d7y5jt6yY8l5saRAx0AhYTcPKLSi0W47O2zGZ68lY9Zsu4ZpQOj806ufs5Q == ARC-Authentication-Results: i=1; mx1.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=IQZIeQXk x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Authentication-Results: mx1.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=IQZIeQXk x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932138AbeA1Wuw (ORCPT ); Sun, 28 Jan 2018 17:50:52 -0500 Received: from mail-by2nam03on0118.outbound.protection.outlook.com ([104.47.42.118]:52393 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753722AbeA1W3F (ORCPT ); Sun, 28 Jan 2018 17:29:05 -0500 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: Claudiu Manoil , Shaohui Xie , "David S . Miller" , Sasha Levin Subject: [PATCH AUTOSEL for 4.9 31/49] gianfar: Disable EEE autoneg by default Thread-Topic: [PATCH AUTOSEL for 4.9 31/49] gianfar: Disable EEE autoneg by default Thread-Index: AQHTmIc+yKwL+mehrEOQoQzr3dNDPg== Date: Sun, 28 Jan 2018 22:27:56 +0000 Message-ID: <20180128222727.22404-31-alexander.levin@microsoft.com> References: <20180128222727.22404-1-alexander.levin@microsoft.com> In-Reply-To: <20180128222727.22404-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;MW2PR2101MB0924;7:tvEyy0iIPVxMy0PsKH7ue1V9rxnC/cEPRe1zJCiY7/Tl7zWI7XUF4puzIwhERp6QGrsGtUT+xIAow+AebwAOr3n5/ly5xw3dEgFkOCreq9CFZcpxRj211WNxEMnU+oyin7VQ47AHcitTlx2izrKaQtahBw+1f6G9ZkDzRl0oF8vf67xAQmQfYpYPbJU8bSyDXMffVPIiusuKcMPL3hy48NDvXPDS08jSxJwpoXyY9nk1fI2dWBRmCMo/AHI2hKSH x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: e623c813-f2df-4c9b-f51e-08d5669e88b9 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7193020);SRVR:MW2PR2101MB0924; x-ms-traffictypediagnostic: MW2PR2101MB0924: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(185117386973197)(21532816269658); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(61425038)(6040501)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(3231101)(944501161)(6055026)(61426038)(61427038)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123560045)(20161123564045)(6072148)(201708071742011);SRVR:MW2PR2101MB0924;BCL:0;PCL:0;RULEID:;SRVR:MW2PR2101MB0924; x-forefront-prvs: 05669A7924 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(396003)(346002)(39860400002)(366004)(39380400002)(376002)(189003)(199004)(2906002)(26005)(10090500001)(6116002)(3846002)(8936002)(6666003)(86362001)(36756003)(186003)(66066001)(99286004)(1076002)(107886003)(86612001)(4326008)(25786009)(5250100002)(68736007)(2900100001)(2501003)(72206003)(6512007)(3280700002)(22452003)(8656006)(53936002)(478600001)(10290500003)(106356001)(3660700001)(110136005)(54906003)(97736004)(6436002)(316002)(2950100002)(8676002)(81156014)(76176011)(81166006)(6506007)(105586002)(305945005)(14454004)(6486002)(102836004)(5660300001)(7736002)(22906009)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:MW2PR2101MB0924;H:MW2PR2101MB1034.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; x-microsoft-antispam-message-info: 6jh6pp2pFQA+FrZsvcXPGX+Dg56lYxs3Jeh4PhNkK3X3m3At7ScZGSnc+euuh3g4JKOlfcPV/iGATjD41wvQBA== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: e623c813-f2df-4c9b-f51e-08d5669e88b9 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jan 2018 22:27:56.0794 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR2101MB0924 Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: From: Claudiu Manoil [ Upstream commit b6b5e8a691185606dfffff3198c89e3b4fd9d4f6 ] This controller does not support EEE, but it may connect to a PHY which supports EEE and advertises EEE by default, while its link partner also advertises EEE. If this happens, the PHY enters low power mode when the traffic rate is low and causes packet loss. This patch disables EEE advertisement by default for any PHY that gianfar connects to, to prevent the above unwanted outcome. Signed-off-by: Shaohui Xie Tested-by: Yangbo Lu Signed-off-by: Claudiu Manoil Reviewed-by: Andrew Lunn Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/freescale/gianfar.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/etherne= t/freescale/gianfar.c index 5b643ca00db2..e3b41ba95168 100644 --- a/drivers/net/ethernet/freescale/gianfar.c +++ b/drivers/net/ethernet/freescale/gianfar.c @@ -1789,6 +1789,7 @@ static int init_phy(struct net_device *dev) GFAR_SUPPORTED_GBIT : 0; phy_interface_t interface; struct phy_device *phydev; + struct ethtool_eee edata; =20 priv->oldlink =3D 0; priv->oldspeed =3D 0; @@ -1813,6 +1814,10 @@ static int init_phy(struct net_device *dev) /* Add support for flow control, but don't advertise it by default */ phydev->supported |=3D (SUPPORTED_Pause | SUPPORTED_Asym_Pause); =20 + /* disable EEE autoneg, EEE not supported by eTSEC */ + memset(&edata, 0, sizeof(struct ethtool_eee)); + phy_ethtool_set_eee(phydev, &edata); + return 0; } =20 --=20 2.11.0