From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-1372482-1517179764-2-13580576178510580989 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.001, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='com', MailFrom='org', XOriginatingCountry='US' X-Spam-charsets: plain='iso-8859-1' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1517179764; b=bZ/HUfU0rW65i1/Uhckp4VhDqO81oYaWmF9+U9y8QvcMpak fKGUqh4MQQasgK7Q5lgimqjWpdBRfj+dgWCsg3q4VZ/ummcl/iJ8vT/+to3JnETe TYP80fZPKAUchqMdrsFQF6r8kX6M5u/N68YARYQZmIM4LsVbecrHIz/geCi29R61 BSpw4sWy6Q/0+1QwWyqB48XRtGfEqQyrOq02J+KNAA0SR4VUjN7lcPB4DujfwaXE zFgoB2hjKBN5rksoRw9eLCjVHtG3miyto+Ni+USNIQNOnHzKfowBndiIUmBCCN2c bnOBkdL6Snw2hVxKilToE9+TfuLcd9XrObne3bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id :references:in-reply-to:content-type:content-transfer-encoding :mime-version:sender:list-id; s=arctest; t=1517179764; bh=gUmTrq 7VHv2XCLFrqIB23GZK04M0ugEFCChTQbuxiiI=; b=Y0qMczhAy4LPFm+bguH4F6 9Y5+G49WkaGkq3GB/ZiNqd6PjHoQOlfy1e9p6f9o5ZofMM+Trs5xEw163RVLpIit JsjhR2eg2YfMhV4AY6WNmAuPsQZ6tABmJvbgkfw66TKRHFdyqlDzUE71ULHgNKWj gngkuYhpZJCuPByLHmunE7KzY425o2ef6d9sjNVZ5VI1Fl7SnQ/lqZng+NsNV6KX Mmr0zFRssOt94VhlMcSFyPzH3C2990oaoBq8jPNkXdkHUDdMdp3+RO/da33uF6Rf nsGfG1eY9dyan6lbcMLXqXNYEjK85nZx8qC/rODjHNvm+x6DbpRT/rf4FdL79JNA == ARC-Authentication-Results: i=1; mx6.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=X/KbyRkC x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Authentication-Results: mx6.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=X/KbyRkC x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933027AbeA1WtW (ORCPT ); Sun, 28 Jan 2018 17:49:22 -0500 Received: from mail-by2nam03on0118.outbound.protection.outlook.com ([104.47.42.118]:52393 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753441AbeA1W3G (ORCPT ); Sun, 28 Jan 2018 17:29:06 -0500 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: "Gustavo A. R. Silva" , Vinod Koul , Sasha Levin Subject: [PATCH AUTOSEL for 4.9 33/49] dmaengine: at_hdmac: fix potential NULL pointer dereference in atc_prep_dma_interleaved Thread-Topic: [PATCH AUTOSEL for 4.9 33/49] dmaengine: at_hdmac: fix potential NULL pointer dereference in atc_prep_dma_interleaved Thread-Index: AQHTmIc/xXmd3dq6hESENRPTj7oAiw== Date: Sun, 28 Jan 2018 22:27:57 +0000 Message-ID: <20180128222727.22404-33-alexander.levin@microsoft.com> References: <20180128222727.22404-1-alexander.levin@microsoft.com> In-Reply-To: <20180128222727.22404-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;MW2PR2101MB0924;6:jbdXiIvbqiVDenm4P7istIXvY58mc2LwT2y7442LaM+QE1Kndae5x7knCb2EcBufBGQzKtY5CfvQDR4XEsGUhhqO7gpA2e3IgCJIe9i8D09juf4H2PqsG0kgZE7lT/wQMmrKPRomAGmOm2V4KvppQOzWOaFa5M9MvakiPw64RRvjl30dOGMzFrKS8veoEkq0N4w1OINWMPJprT/ICqal9Gme4ypeEmk21MYHQsOIdOdMwKDCcDXb5h0CJcGJ2p3Tw4b90/FAxBZ4BCZw4T+abS5MY+sghasqUziQ884Q58Wb6h3UHcgQdX3rxSHr//1C8XktjHCL4KPfRwsOzM7vvMVhUXY+IM+SUAvxGDxrX6tVVgDBtQq3cdi+/iMkDs8c;5:aRp+Niww32ogS2ZLaxu3xmpaTMKshmZYS2Jznw7hSzhA3qYm7mkYCntNh7V8dJaSR3DgxKjdjctOkLNY1/IgWW24YJtWs9gRWEYjLo4rXteQHUOsu2B9XkjFLzcnGJ+pH1nfNY0gqYWU43wec9y03K8cMd8Ue+ZhDnUb8XTH84c=;24:2gtBA2JfR3Y8nSJvaxmSxpskHbh8m70Fy0j3Hg39pvUc4z3cQNjDpo/7q7ZX+NdD2BK+2p1t4xY0bierwKV5klrh7c4vlV0Cht7ldSejT6A=;7:0TgfdGOQ0FRIjP6q0s/SDSqF32HXDQ4kwf9Ycb9oMlSPQyp06dn6K96ciyXDU0WT2z30s2cm/PDxCyZD9c+uhlIaRwaWMoCDoRue9DDDze0G3X/xT76J/IaYZJ4ks2KuxVMP+NK5g0yV7fGzguHxITKQyYbWFkso4i0twG4vSXeP7Zuhz+u1SwVmK0Q8PrnZgto9uU9SMhcM3cVz2IFOvC2yTQRucx46I0Qsl4NcaqolXj2guJnz/BzHm1F7DxsY x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 1a74145f-a229-4a34-e3ca-08d5669e891e x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7193020);SRVR:MW2PR2101MB0924; x-ms-traffictypediagnostic: MW2PR2101MB0924: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(61425038)(6040501)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(3231101)(944501161)(6055026)(61426038)(61427038)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123560045)(20161123564045)(6072148)(201708071742011);SRVR:MW2PR2101MB0924;BCL:0;PCL:0;RULEID:;SRVR:MW2PR2101MB0924; x-forefront-prvs: 05669A7924 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(396003)(346002)(39860400002)(366004)(39380400002)(376002)(189003)(199004)(2906002)(26005)(10090500001)(6116002)(3846002)(59450400001)(8936002)(6666003)(86362001)(36756003)(186003)(66066001)(99286004)(1076002)(107886003)(86612001)(4326008)(25786009)(5250100002)(68736007)(2900100001)(2501003)(72206003)(6512007)(3280700002)(22452003)(53936002)(478600001)(10290500003)(106356001)(3660700001)(110136005)(54906003)(97736004)(6436002)(316002)(2950100002)(8676002)(81156014)(76176011)(81166006)(6506007)(105586002)(305945005)(14454004)(6486002)(102836004)(5660300001)(7736002)(22906009)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:MW2PR2101MB0924;H:MW2PR2101MB1034.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; x-microsoft-antispam-message-info: mkUJwfSyJanPbYnpXiB7pG8/aqKdnC6IQAEv22GJpSBkxFqulNZR0nKUiqauO5yIuXl38PtMSOxdHSvNYf+Vqg== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1a74145f-a229-4a34-e3ca-08d5669e891e X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jan 2018 22:27:57.3603 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR2101MB0924 Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: From: "Gustavo A. R. Silva" [ Upstream commit 62a277d43d47e74972de44d33bd3763e31992414 ] _xt_ is being dereferenced before it is null checked, hence there is a potential null pointer dereference. Fix this by moving the pointer dereference after _xt_ has been null checked. This issue was detected with the help of Coccinelle. Fixes: 4483320e241c ("dmaengine: Use Pointer xt after NULL check.") Signed-off-by: Gustavo A. R. Silva Acked-by: Ludovic Desroches Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/dma/at_hdmac.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c index a4c8f80db29d..e2cec5b357fd 100644 --- a/drivers/dma/at_hdmac.c +++ b/drivers/dma/at_hdmac.c @@ -709,7 +709,7 @@ atc_prep_dma_interleaved(struct dma_chan *chan, unsigned long flags) { struct at_dma_chan *atchan =3D to_at_dma_chan(chan); - struct data_chunk *first =3D xt->sgl; + struct data_chunk *first; struct at_desc *desc =3D NULL; size_t xfer_count; unsigned int dwidth; @@ -721,6 +721,8 @@ atc_prep_dma_interleaved(struct dma_chan *chan, if (unlikely(!xt || xt->numf !=3D 1 || !xt->frame_size)) return NULL; =20 + first =3D xt->sgl; + dev_info(chan2dev(chan), "%s: src=3D%pad, dest=3D%pad, numf=3D%d, frame_size=3D%d, flags=3D0x%lx= \n", __func__, &xt->src_start, &xt->dst_start, xt->numf, --=20 2.11.0