From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-1372482-1517179571-2-2503208832194669748 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.001, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES unknown, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='com', MailFrom='org', XOriginatingCountry='US' X-Spam-charsets: plain='iso-8859-1' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1517179570; b=BLe06ZkuS6gzK4r2baNRFIwSHA2H6ROxXhTxVNXtIPARims /he2dKZDRLoYYJ7z4AKH2MmstpV4vx4Rhw7P+x++M22JB/EdtuzrK3RzFL1md9PN sI4GiBzhPIxzm1o5Bn6pHnwGaqqYCYm2N6Qc0bb9jay34pRRpdleIN6xf5D1EiNu ZVNQG8Sk2Vzo/DjwfGG67a/s1J61WFFVvGKGPFGRaTiToM0sIh7FBKqxrnn6yqlK 0AT9DTbt8O+dS5EyWM8y0tn5FA7WZDqODRY73pPn5EAfnB/kM/MdpkrDd/PXDq2A +ryfXxg0muJsNwOpUBIvkGgjQCCtm/nHc91d7/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id :references:in-reply-to:content-type:content-transfer-encoding :mime-version:sender:list-id; s=arctest; t=1517179570; bh=kyjpBO nfso4dXTQhtJLPYAoFlqR6AaRRkTBSIBeUl4k=; b=w+KW51U3kITAzJ8X/H1KIc 6wxPKSYerw8sNBuZFsntz53d7ACCsmv1/N2dfIXrwYCJI2PJT6ll598Th7K3xb1Z 5GUuVAop6BebBGNyIMqapzsytUvOAmQcnKHKn5UBkFVd9X1qAbLWCPmmHETTiEt6 9Yce7wbSkrDjSxi4zlrx9GDTiAh9NdUhl7aIJm3Is9kO6yxqvJKJL4HxqfAQiUI2 nb+EVNsboC0yh05uHnMh/6Do+d6HG/aSR6Fz8nJY/Vof++e571Jwbs3dEfaMTXc9 /HN46hopidHbh5ITCRHjZzvK80o1zGxAmIOX8/Su1jGmNAqqI3TX/AMM7of4TolQ == ARC-Authentication-Results: i=1; mx3.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=aSqs6BWF x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Authentication-Results: mx3.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=aSqs6BWF x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932311AbeA1W3U (ORCPT ); Sun, 28 Jan 2018 17:29:20 -0500 Received: from mail-sn1nam01on0139.outbound.protection.outlook.com ([104.47.32.139]:17739 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932266AbeA1W3O (ORCPT ); Sun, 28 Jan 2018 17:29:14 -0500 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: Tobias Jordan , Vinod Koul , Sasha Levin Subject: [PATCH AUTOSEL for 4.9 42/49] dmaengine: jz4740: disable/unprepare clk if probe fails Thread-Topic: [PATCH AUTOSEL for 4.9 42/49] dmaengine: jz4740: disable/unprepare clk if probe fails Thread-Index: AQHTmIdC+bZX1EbMk0GF0cHQnLdRIA== Date: Sun, 28 Jan 2018 22:28:03 +0000 Message-ID: <20180128222727.22404-42-alexander.levin@microsoft.com> References: <20180128222727.22404-1-alexander.levin@microsoft.com> In-Reply-To: <20180128222727.22404-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;MW2PR2101MB0924;7:72FEmKe9MidhVzxFBeFaPq0wCAWZI/l4JRLGF25S7+hXUt26p1Xg/QXsCzu8XodSYcvGPvixtZSm3PZravg551Aw4aZOuxb5ZFPq3bNGBUegyHMW3W0vAvJexcnk9585gURCAHaExaUqOzV3tRY4D6jCiozwlfKLMtzGCgRmjUxfvY5KakNOTrjf0kk9Ut5gz9NgC3+jqQ6s5JCx9iMxza+ClWM61+7nDXG2t63CGHf9Pc/0HBHGVsSAKjA4xtDx x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 3ece688c-1057-4298-84cc-08d5669e8b6d x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7193020);SRVR:MW2PR2101MB0924; x-ms-traffictypediagnostic: MW2PR2101MB0924: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(61425038)(6040501)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(3231101)(944501161)(6055026)(61426038)(61427038)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123560045)(20161123564045)(6072148)(201708071742011);SRVR:MW2PR2101MB0924;BCL:0;PCL:0;RULEID:;SRVR:MW2PR2101MB0924; x-forefront-prvs: 05669A7924 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(396003)(346002)(39860400002)(366004)(39380400002)(376002)(189003)(199004)(2906002)(26005)(10090500001)(6116002)(3846002)(59450400001)(8936002)(6666003)(86362001)(36756003)(186003)(66066001)(99286004)(1076002)(107886003)(86612001)(4326008)(25786009)(5250100002)(68736007)(2900100001)(2501003)(72206003)(6512007)(3280700002)(22452003)(53936002)(478600001)(10290500003)(106356001)(3660700001)(110136005)(54906003)(97736004)(6436002)(316002)(2950100002)(8676002)(81156014)(76176011)(81166006)(6506007)(105586002)(305945005)(14454004)(6486002)(102836004)(5660300001)(7736002)(22906009)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:MW2PR2101MB0924;H:MW2PR2101MB1034.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; x-microsoft-antispam-message-info: pXvgj2kpCIPK7ZS3Gb7yIyyt3qLPzSlnjcW5SB+9wNWChyZr7YvcKwaXpvA7pLabubOk4AhIhL61nhVuSRSjqw== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3ece688c-1057-4298-84cc-08d5669e8b6d X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jan 2018 22:28:03.3465 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR2101MB0924 Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: From: Tobias Jordan [ Upstream commit eb9436966fdc84cebdf222952a99898ab46d9bb0 ] in error path of jz4740_dma_probe(), call clk_disable_unprepare() to clean up. Found by Linux Driver Verification project (linuxtesting.org). Fixes: 25ce6c35fea0 MIPS: jz4740: Remove custom DMA API Signed-off-by: Tobias Jordan Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/dma/dma-jz4740.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/dma/dma-jz4740.c b/drivers/dma/dma-jz4740.c index d50273fed715..afd5e10f8927 100644 --- a/drivers/dma/dma-jz4740.c +++ b/drivers/dma/dma-jz4740.c @@ -555,7 +555,7 @@ static int jz4740_dma_probe(struct platform_device *pde= v) =20 ret =3D dma_async_device_register(dd); if (ret) - return ret; + goto err_clk; =20 irq =3D platform_get_irq(pdev, 0); ret =3D request_irq(irq, jz4740_dma_irq, 0, dev_name(&pdev->dev), dmadev)= ; @@ -568,6 +568,8 @@ static int jz4740_dma_probe(struct platform_device *pde= v) =20 err_unregister: dma_async_device_unregister(dd); +err_clk: + clk_disable_unprepare(dmadev->clk); return ret; } =20 --=20 2.11.0