From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751581AbeA2RDT (ORCPT ); Mon, 29 Jan 2018 12:03:19 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:45486 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751262AbeA2RDS (ORCPT ); Mon, 29 Jan 2018 12:03:18 -0500 Date: Mon, 29 Jan 2018 12:03:16 -0500 (EST) Message-Id: <20180129.120316.1103183862386556019.davem@davemloft.net> To: jasowang@redhat.com Cc: mst@redhat.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, john.fastabend@gmail.com Subject: Re: [PATCH net-next 00/12] ptr_ring fixes From: David Miller In-Reply-To: <74a2d464-3b3c-94fc-bf05-dee8e7ae775c@redhat.com> References: <1516923320-16959-1-git-send-email-mst@redhat.com> <74a2d464-3b3c-94fc-bf05-dee8e7ae775c@redhat.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jason Wang Date: Mon, 29 Jan 2018 15:10:37 +0800 > > > On 2018年01月26日 07:36, Michael S. Tsirkin wrote: >> This fixes a bunch of issues around ptr_ring use in net core. >> One of these: "tap: fix use-after-free" is also needed on net, >> but can't be backported cleanly. >> >> I will post a net patch separately. >> >> Lightly tested - Jason, could you pls confirm this >> addresses the security issue you saw with ptr_ring? >> Testing reports would be appreciated too. >> >> Michael S. Tsirkin (12): >> ptr_ring: keep consumer_head valid at all times >> ptr_ring: clean up documentation >> ptr_ring: READ/WRITE_ONCE for __ptr_ring_empty >> tap: fix use-after-free >> ptr_ring: disallow lockless __ptr_ring_full >> Revert "net: ptr_ring: otherwise safe empty checks can overrun array >> bounds" >> skb_array: use __ptr_ring_empty >> ptr_ring: prevent queue load/store tearing >> tools/virtio: switch to __ptr_ring_empty >> tools/virtio: more stubs to fix tools build >> tools/virtio: copy READ/WRITE_ONCE >> tools/virtio: fix smp_mb on x86 >> >> drivers/net/tap.c | 3 -- >> include/linux/ptr_ring.h | 86 ++++++++++++++++++++++------------------ >> include/linux/skb_array.h | 2 +- >> tools/virtio/linux/kernel.h | 2 +- >> tools/virtio/linux/thread_info.h | 1 + >> tools/virtio/ringtest/main.h | 59 ++++++++++++++++++++++++++- >> tools/virtio/ringtest/ptr_ring.c | 2 +- >> 7 files changed, 110 insertions(+), 45 deletions(-) >> create mode 100644 tools/virtio/linux/thread_info.h >> > > For the series: > > Tested-by: Jason Wang > Acked-by: Jason Wang Series applied, thanks everyone.