From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-3470331-1517241367-2-4193396617947202565 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.001, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='us', MailFrom='org' X-Spam-charsets: plain='us-ascii' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: linux-serial-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1517241366; b=AD9wbZf2CSTUcQHSHYd4YvJZhSyAg6SahlX6N2AxtweBDqD CnB8MEclXvcAtrbmAXHWhr6hfmQZzoaw30cOUL9GREwdJHbdG/lj8TffXcYBR++a J2DVVfOSEH8CM6DnogWVkeZkWXecPLLdTuCREfQbWIDfa9hiMxI13m6T+OMnjRiU RaxpSg8j4rgL7JlIqaZswin1+LqUiYFi3b0HDXPl4B/1hLd1ZBptKbqn7jxvd8VA ggSgX2LSPH23W6GWbXl0TM9qii/nl/NFwvsEz8BLvi19VG7y8BKXalxXwYOSz1kX 3X4/QYghc40lBnh6GZl9Emodse9c1sK7SXi/RZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:in-reply-to:sender :list-id; s=arctest; t=1517241366; bh=2W/rLPGILKZ9wiEHltqNV27DD7 SrIcVX8tssWgRdEXc=; b=cO+j9+PaPVcwr6w4JhcP1V8UUFAy4m5FeubvMJju1i VQYlgpOGjuHkq8/zk/wZwa+GSj7RwGh+L34HFMhwLBB946AVta7A6FJB9xjC78jR zAyH5rPpI9FggrguappJQ3e7G+bAo5t9f0/zO6kTImaUqvUZ9hMzmzRbdyXN/cS2 USSP/Libc3G/H7JBgp7EPdkm+6o3kl0dAxJXCvwqIluH+5X3W3UVf/wC57Pala0V OnLXXC9x5wVTiG43IRHmdvLaM3DTn7CBaQlhSHQQMixgNCvUVN89aCE/gve7XXrO 9GI7atsXM5EnqX1m7/MiKBPo1V+c+eePUmjIS1FHJHyQ== ARC-Authentication-Results: i=1; mx3.messagingengine.com; arc=none (no signatures found); dkim-adsp=unknown (ADSP policy from eso.teric.us); dkim=fail (body has been altered; 2048-bit rsa key sha256) header.d=eso.teric.us header.i=@eso.teric.us header.b=RjY5Brn7 x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=mail; dmarc=none (p=none,has-list-id=yes,d=none) header.from=eso.teric.us; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-serial-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=eso.teric.us header.result=pass header_org.domain=teric.us header_org.mx.error=NOERROR header_org.result=warn header_is_org_domain=no Authentication-Results: mx3.messagingengine.com; arc=none (no signatures found); dkim-adsp=unknown (ADSP policy from eso.teric.us); dkim=fail (body has been altered; 2048-bit rsa key sha256) header.d=eso.teric.us header.i=@eso.teric.us header.b=RjY5Brn7 x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=mail; dmarc=none (p=none,has-list-id=yes,d=none) header.from=eso.teric.us; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-serial-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=eso.teric.us header.result=pass header_org.domain=teric.us header_org.mx.error=NOERROR header_org.result=warn header_is_org_domain=no Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751829AbeA2P4C (ORCPT ); Mon, 29 Jan 2018 10:56:02 -0500 Received: from eso.teric.us ([69.164.192.171]:52796 "EHLO eso.teric.us" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751378AbeA2P4B (ORCPT ); Mon, 29 Jan 2018 10:56:01 -0500 Date: Mon, 29 Jan 2018 09:56:00 -0600 From: Julia Cartwright To: Oleksandr Shamray Cc: gregkh@linuxfoundation.org, arnd@arndb.de, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, openbmc@lists.ozlabs.org, joel@jms.id.au, jiri@resnulli.us, tklauser@distanz.ch, linux-serial@vger.kernel.org, vadimp@mellanox.com, system-sw-low-level@mellanox.com, robh+dt@kernel.org, openocd-devel-owner@lists.sourceforge.net, linux-api@vger.kernel.org, davem@davemloft.net, mchehab@kernel.org, Jiri Pirko Subject: Re: [patch v18 1/4] drivers: jtag: Add JTAG core driver Message-ID: <20180129155600.GA1924@kryptos.localdomain> References: <1517236305-4880-1-git-send-email-oleksandrs@mellanox.com> <1517236305-4880-2-git-send-email-oleksandrs@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1517236305-4880-2-git-send-email-oleksandrs@mellanox.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-serial-owner@vger.kernel.org X-Mailing-List: linux-serial@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Mon, Jan 29, 2018 at 04:31:42PM +0200, Oleksandr Shamray wrote: > Initial patch for JTAG driver > JTAG class driver provide infrastructure to support hardware/software > JTAG platform drivers. It provide user layer API interface for flashing > and debugging external devices which equipped with JTAG interface > using standard transactions. > > Driver exposes set of IOCTL to user space for: > - XFER: > - SIR (Scan Instruction Register, IEEE 1149.1 Data Register scan); > - SDR (Scan Data Register, IEEE 1149.1 Instruction Register scan); > - RUNTEST (Forces the IEEE 1149.1 bus to a run state for a specified > number of clocks). > - SIOCFREQ/GIOCFREQ for setting and reading JTAG frequency. > > Driver core provides set of internal APIs for allocation and > registration: > - jtag_register; > - jtag_unregister; > - jtag_alloc; > - jtag_free; > > Platform driver on registration with jtag-core creates the next > entry in dev folder: > /dev/jtagX > > Signed-off-by: Oleksandr Shamray > Signed-off-by: Jiri Pirko > Acked-by: Philippe Ombredanne [..] > diff --git a/drivers/jtag/jtag.c b/drivers/jtag/jtag.c [..] > +struct jtag *jtag_alloc(size_t priv_size, const struct jtag_ops *ops) > +{ > + struct jtag *jtag; > + > + jtag = kzalloc(sizeof(*jtag) + priv_size, GFP_KERNEL); > + if (!jtag) > + return NULL; > + > + if (!ops) > + return NULL; > + > + if (!ops->idle || !ops->mode_set || !ops->status_get || !ops->xfer) > + return NULL; Did you think through this? You leak 'jtag' here and above. Perform all the ops checks prior to the allocation. Julia