From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jpoimboe@redhat.com>
X-Google-Smtp-Source: AH8x225lhqgUGynR1So5/bI85sDv9AmLLW7JFE2BwpsKDqKg377JdPDNI2hUZVgT6KqS4hGlfXOF
ARC-Seal: i=1; a=rsa-sha256; t=1517248747; cv=none;
        d=google.com; s=arc-20160816;
        b=rOM77tRIipn32ZqGdNBdke4OEjmCF1xM672V9YgY+3LtRHq/lH3zCe6HOinmjcSqeM
         SHvBk3EX7q3AI9OJp3nGPVbe2uuPZpxSqtFLslINUWCocTpXnYtO6bU1IyeLe+/V3eiE
         7QRXkAptBIUn6tx8sMIIGgKLQ6h/TmZvnUrqpsTPz/ogEpq5tUEr6AmUR7VI792zgEHE
         7tn1a17qVpzZI2iock82mmabTL6KutqiwnWZQW2RdAZ2h5lAw7YCtCCiHZzDmbPR9OLU
         nvEuchqOHsqfTl/7bPeaaCUtWWYVXvrbQDEbq/rz5BF9Q4fR5NSpfcAfirFeEcx+cLMt
         8LLg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=user-agent:in-reply-to:content-disposition:mime-version:references
         :message-id:subject:cc:to:from:date:arc-authentication-results;
        bh=Ow7Xf4jv2lQLR9foMx73T7Pe1P7jiaF7P2BjOazih7M=;
        b=YUA8Nk1z5NwcOD0IfoNKENC19iJFVp1S4mN608b6O+TXiCr7pikqD7H63WsGu6my9S
         SYOdUHMF8ZI7VCx29k3xOjf1tzMIcLesGMWBfQcrSRaVDU/Xr0MaKM1v6kO8uUwHWCu4
         zw1VPM3bLBqgDSwotLl3/anCguGHjE+wDjakdD7Ru0GKnddja/Aow/PAHoiRwaN4iVB8
         /WzkuwM4/380+VNt2ukBVo5UYTfFuJ31/JS1EwKr1eDk0rJbbRyrwkzMF/il1bC3ugWF
         JkhVzunfDtB16fJcI0v/yOkSeETEs5Jfe+275gGAY3uQCBNQpa+EePzIt+LF+cePpW88
         Vy3A==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of jpoimboe@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=jpoimboe@redhat.com;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of jpoimboe@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=jpoimboe@redhat.com;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com
Date: Mon, 29 Jan 2018 11:58:58 -0600
From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: David Woodhouse <dwmw2@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>, linux-kernel@vger.kernel.org,
	Dave Hansen <dave.hansen@intel.com>,
	Ashok Raj <ashok.raj@intel.com>,
	Tim Chen <tim.c.chen@linux.intel.com>,
	Andy Lutomirski <luto@kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Greg KH <gregkh@linuxfoundation.org>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Andi Kleen <ak@linux.intel.com>,
	Arjan Van De Ven <arjan.van.de.ven@intel.com>,
	Dan Williams <dan.j.williams@intel.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Jun Nakajima <jun.nakajima@intel.com>,
	Asit Mallick <asit.k.mallick@intel.com>,
	Jason Baron <jbaron@akamai.com>
Subject: Re: [PATCH 03/24] x86/paravirt: Annotate indirect calls
Message-ID: <20180129175858.4btnobcifaumc7g4@treble>
References: <20180123152539.374360046@infradead.org>
 <20180123152638.162540737@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20180123152638.162540737@infradead.org>
User-Agent: Mutt/1.6.0.1 (2016-04-01)
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: =?utf-8?q?1590397845189698377?=
X-GMAIL-MSGID: =?utf-8?q?1590950622339595447?=
X-Mailing-List: linux-kernel@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>

On Tue, Jan 23, 2018 at 04:25:42PM +0100, Peter Zijlstra wrote:
> Paravirt emits indirect calls which get flagged by objtool retpoline
> checks, annotate it away because all these indirect calls will be
> patched out before we start userspace.
> 
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> ---
>  arch/x86/include/asm/paravirt.h       |   22 ++++++++++++++++++----
>  arch/x86/include/asm/paravirt_types.h |    7 ++++++-
>  2 files changed, 24 insertions(+), 5 deletions(-)
> 
> --- a/arch/x86/include/asm/paravirt.h
> +++ b/arch/x86/include/asm/paravirt.h
> @@ -828,6 +828,12 @@ extern void default_banner(void);
>  	 .short clobbers;			\
>  	.popsection
>  
> +#define PARA_RETPOLINE_SAFE				\
> +	773:;						\
> +	.pushsection .discard.retpoline_safe;		\
> +	_ASM_PTR 773b;					\
> +	.popsection

Why does paravirt have its own version of this macro?

-- 
Josh