From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751581AbeA2SnS (ORCPT ); Mon, 29 Jan 2018 13:43:18 -0500 Received: from mail-pg0-f68.google.com ([74.125.83.68]:41596 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751257AbeA2SnN (ORCPT ); Mon, 29 Jan 2018 13:43:13 -0500 X-Google-Smtp-Source: AH8x224seBK/hkFfuX2IhlIXbiF1EZHgbNlbRY02MSsbDMCrMsIeKgpPPzGIIvwB1EEoFSjdf9u6cQ== Date: Mon, 29 Jan 2018 10:43:09 -0800 From: Dmitry Torokhov To: Andi Shyti Cc: Simon Shields , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Andi Shyti Subject: Re: [PATCH 4/8] Input: mms114 - remove unused variable Message-ID: <20180129184309.ljnw63owyuhofqko@dtor-ws> References: <20180129113323.18961-1-andi.shyti@samsung.com> <20180129113323.18961-5-andi.shyti@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180129113323.18961-5-andi.shyti@samsung.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 29, 2018 at 08:33:19PM +0900, Andi Shyti wrote: > '__packed' is not used anywhere, remove it. Umm, this is not a variable, this is type annotation meaning that the structure is packed. Still not needed, as we are not using anything but u8 data elements, but justification is completely wrong. > > Signed-off-by: Andi Shyti > --- > drivers/input/touchscreen/mms114.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/touchscreen/mms114.c b/drivers/input/touchscreen/mms114.c > index fb4435ae506b..11dba8bb48e3 100644 > --- a/drivers/input/touchscreen/mms114.c > +++ b/drivers/input/touchscreen/mms114.c > @@ -78,7 +78,7 @@ struct mms114_touch { > u8 width; > u8 strength; > u8 reserved[2]; > -} __packed; > +}; > > static void mms114_process_mt(struct mms114_data *data, struct mms114_touch *touch) > { > -- > 2.15.1 > -- Dmitry