From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751907AbeA2S4h (ORCPT <rfc822;w@1wt.eu>);
        Mon, 29 Jan 2018 13:56:37 -0500
Received: from mail-pf0-f193.google.com ([209.85.192.193]:39950 "EHLO
        mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751249AbeA2S4f (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 29 Jan 2018 13:56:35 -0500
X-Google-Smtp-Source: AH8x224qu7Op90FZX0InSWWSjjKstE7o5Orf7Jy+9sg421xp0j5M6VMuoxI6NRJYwesSFOIapMaWNg==
Date: Mon, 29 Jan 2018 10:56:31 -0800
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Andi Shyti <andi.shyti@samsung.com>
Cc: Simon Shields <simon@lineageos.org>, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org, Andi Shyti <andi@etezian.org>
Subject: Re: [PATCH 5/8] Input: mms114 - use lower case for hexadecimal values
Message-ID: <20180129185631.wvgl3il6tu6nk7ew@dtor-ws>
References: <20180129113323.18961-1-andi.shyti@samsung.com>
 <CGME20180129113331epcas2p29c39450d723f7d2085fc10a74a74e53c@epcas2p2.samsung.com>
 <20180129113323.18961-6-andi.shyti@samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180129113323.18961-6-andi.shyti@samsung.com>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jan 29, 2018 at 08:33:20PM +0900, Andi Shyti wrote:
> Signed-off-by: Andi Shyti <andi.shyti@samsung.com>

But why?

> ---
>  drivers/input/touchscreen/mms114.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/mms114.c b/drivers/input/touchscreen/mms114.c
> index 11dba8bb48e3..fdf23bc416af 100644
> --- a/drivers/input/touchscreen/mms114.c
> +++ b/drivers/input/touchscreen/mms114.c
> @@ -20,7 +20,7 @@
>  
>  /* Write only registers */
>  #define MMS114_MODE_CONTROL		0x01
> -#define MMS114_OPERATION_MODE_MASK	0xE
> +#define MMS114_OPERATION_MODE_MASK	0xe
>  #define MMS114_ACTIVE			(1 << 1)
>  
>  #define MMS114_XY_RESOLUTION_H		0x02
> @@ -30,12 +30,12 @@
>  #define MMS114_MOVING_THRESHOLD		0x06
>  
>  /* Read only registers */
> -#define MMS114_PACKET_SIZE		0x0F
> +#define MMS114_PACKET_SIZE		0x0f
>  #define MMS114_INFOMATION		0x10
> -#define MMS114_TSP_REV			0xF0
> +#define MMS114_TSP_REV			0xf0
>  
> -#define MMS152_FW_REV			0xE1
> -#define MMS152_COMPAT_GROUP		0xF2
> +#define MMS152_FW_REV			0xe1
> +#define MMS152_COMPAT_GROUP		0xf2
>  
>  /* 200ms needs after power on */
>  #define MMS114_POWERON_DELAY		200
> -- 
> 2.15.1
> 

-- 
Dmitry