From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752007AbeA2Tqt (ORCPT ); Mon, 29 Jan 2018 14:46:49 -0500 Received: from mail-pf0-f193.google.com ([209.85.192.193]:33454 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751593AbeA2Tqr (ORCPT ); Mon, 29 Jan 2018 14:46:47 -0500 X-Google-Smtp-Source: AH8x226zu3fAAEiRmmdxcMyoPHHiz+JNTVuJjpiWc4QibNSY+xzM3RwgxI3SD03DPSbC4uvJYTRf4Q== Date: Mon, 29 Jan 2018 11:46:43 -0800 From: Dmitry Torokhov To: Andi Shyti Cc: Simon Shields , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Andi Shyti Subject: Re: [PATCH 3/8] Input: mms114 - replace mdelay with msleep Message-ID: <20180129194643.wwccgov65m7mcw5h@dtor-ws> References: <20180129113323.18961-1-andi.shyti@samsung.com> <20180129113323.18961-4-andi.shyti@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180129113323.18961-4-andi.shyti@samsung.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 29, 2018 at 08:33:18PM +0900, Andi Shyti wrote: > 200ms seconds is a very long time to keep the CPU busy looping. > Use msleep instead. > > Signed-off-by: Andi Shyti Applied, thank you. > --- > drivers/input/touchscreen/mms114.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/touchscreen/mms114.c b/drivers/input/touchscreen/mms114.c > index 94a97049d711..fb4435ae506b 100644 > --- a/drivers/input/touchscreen/mms114.c > +++ b/drivers/input/touchscreen/mms114.c > @@ -290,7 +290,7 @@ static int mms114_start(struct mms114_data *data) > return error; > } > > - mdelay(MMS114_POWERON_DELAY); > + msleep(MMS114_POWERON_DELAY); > > error = mms114_setup_regs(data); > if (error < 0) { > -- > 2.15.1 > -- Dmitry