From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752041AbeA2Tq6 (ORCPT ); Mon, 29 Jan 2018 14:46:58 -0500 Received: from mail-pg0-f66.google.com ([74.125.83.66]:45695 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751593AbeA2Tq4 (ORCPT ); Mon, 29 Jan 2018 14:46:56 -0500 X-Google-Smtp-Source: AH8x227B2hVj5wco41QQX4/LXoRcMpWvg8z7KntHpeJiUMZM4z6TIusHBIe/veidZJYNZ37+jUEhbg== Date: Mon, 29 Jan 2018 11:46:52 -0800 From: Dmitry Torokhov To: Andi Shyti Cc: Simon Shields , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Andi Shyti Subject: Re: [PATCH 6/8] Input: mms114 - Use BIT() macro instead of explicit shifting Message-ID: <20180129194652.wf7oklunpu2fyoo6@dtor-ws> References: <20180129113323.18961-1-andi.shyti@samsung.com> <20180129113323.18961-7-andi.shyti@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180129113323.18961-7-andi.shyti@samsung.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 29, 2018 at 08:33:21PM +0900, Andi Shyti wrote: > Signed-off-by: Andi Shyti Applied, thank you. > --- > drivers/input/touchscreen/mms114.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/touchscreen/mms114.c b/drivers/input/touchscreen/mms114.c > index fdf23bc416af..d70c03adf148 100644 > --- a/drivers/input/touchscreen/mms114.c > +++ b/drivers/input/touchscreen/mms114.c > @@ -21,7 +21,7 @@ > /* Write only registers */ > #define MMS114_MODE_CONTROL 0x01 > #define MMS114_OPERATION_MODE_MASK 0xe > -#define MMS114_ACTIVE (1 << 1) > +#define MMS114_ACTIVE BIT(1) > > #define MMS114_XY_RESOLUTION_H 0x02 > #define MMS114_X_RESOLUTION 0x03 > -- > 2.15.1 > -- Dmitry