From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751837AbeA2X15 (ORCPT ); Mon, 29 Jan 2018 18:27:57 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:41118 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751417AbeA2X1z (ORCPT ); Mon, 29 Jan 2018 18:27:55 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20180129232753epoutp0114c61cd43141fff0aa50a67b91e1f8f3~Oa6NJ1xDD2291222912epoutp015 X-AuditID: b6c32a48-9adff70000000ff0-99-5a6fadf86970 Date: Tue, 30 Jan 2018 08:27:52 +0900 From: Andi Shyti To: Dmitry Torokhov Cc: Simon Shields , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Andi Shyti Subject: Re: [PATCH 4/8] Input: mms114 - remove unused variable Message-id: <20180129232752.GV7575@gangnam.samsung> MIME-version: 1.0 Content-type: text/plain; charset="us-ascii" Content-disposition: inline In-reply-to: <20180129184309.ljnw63owyuhofqko@dtor-ws> User-Agent: Mutt/1.9.2 (2017-12-15) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrIKsWRmVeSWpSXmKPExsWy7bCmme6PtflRBnP6jSwW/3jOZHF40QtG i5ufvrFaXN41h81iy5nbbA6sHteXfGL22DnrLrtHy/pNbB6fN8kFsESl2mSkJqakFimk5iXn p2TmpdsqeQfHO8ebmhkY6hpaWpgrKeQl5qbaKrn4BOi6ZeYA7VVSKEvMKQUKBSQWFyvp29kU 5ZeWpCpk5BeX2CpFGxoa6RkamOsZGRnpmRjHWhmZApUkpGYsWbyIveAES8XM013MDYynmLsY OTkkBEwk3p69zdjFyMUhJLCDUeLqjWZ2kISQwHdGiZObLLoYOcCKrnYnQtTsZpTYeeMlI0TN J0aJngsmIDaLgKpE+8IzLCA2m4CmRNPtH2wgtoiAvsT22b/AFjALNDNKnFr1AqxIWMBe4t/W KWBX8AoYS2zf+YMRwhaU+DH5HlgNs4COxNlj6xghbGmJR39ngB3HKWAm8frRC7C4qICyxIJX U9hBFkgIrGGTuPBrCyvEay4Sty99Z4KwhSVeHd/CDmFLSzxbtZERwga6aNvtZIjmCYwSn/Z+ hWowlni2sIsJYjOfRMfhv+yQoOCV6GgTgijxkLi86QPUHEeJq9vOM0OC6C2jxIP22YwTGGVn IXloFpKHZiF5aAEj8ypGsdSC4tz01GKjAhO94sTc4tK8dL3k/NxNjODkpeWxg/HAOZ9DjAIc jEo8vAYq+VFCrIllxZW5hxglOJiVRHhFVgOFeFMSK6tSi/Lji0pzUosPMZoCY2Uis5Rocj4w seaVxBuaWBqYmJkZmZtZAFOVOG9bgEuUkEB6YklqdmpqQWoRTB8TB6dUA6P7nWkzZ0hHpNy3 mdFtmLg6/Z94d/rmlu91YkULL+3Lj/gc97fntAZnrMaSVo+C6Ys4n9fwCLuvvBxtP6V5xl++ ruy0lBqvDWuWb0njkZWRqPt9onn2RJ1/F8/c+G4nOGFqsuWGHve7Mam8u8KfClU+cmS0sntc /eZMt8w2zZZXFyfec7XxkVRiKc5INNRiLipOBADbDJWQdAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrKLMWRmVeSWpSXmKPExsVy+t9jAd0fa/OjDKa9kbdY/OM5k8XhRS8Y LW5++sZqcXnXHDaLLWduszmwelxf8onZY+esu+weLes3sXl83iQXwBLFZZOSmpNZllqkb5fA lbFk8SL2ghMsFTNPdzE3MJ5i7mLk4JAQMJG42p3YxcjFISSwk1Hi5IPZTBDOJ0aJj1+fAxVx crAIqEq0LzzDAmKzCWhKNN3+wQZiiwjoS2yf/YsRpIFZoJlR4uL6nawgCWEBe4l/W6eANfMK GEts3/mDEcQWEnjLKPHsMB9EXFDix+R7YEOZBbQk1u88zgRhS0s8+juDHcTmFDCTeP3oBViv qICyxIJXU9gnMPLPQtI+C0n7LCTtCxiZVzFKphYU56bnFhsVGOWllusVJ+YWl+al6yXn525i BAbutsNa/TsYHy+JP8QowMGoxMNroJIfJcSaWFZcmXuIUYKDWUmEV2Q1UIg3JbGyKrUoP76o NCe1+BCjNAeLkjgvf/6xSCGB9MSS1OzU1ILUIpgsEwenVAPjBKkgx5JvM15PNswrMToYbZM0 6ar8vIg7S2+1mZjfE76vZXDzrYiY4MIXP2LLLc5fM0lfaWmyu9DVdqPcAeUZhQfTtbvbd3yM cLDWP6TktjZ22dSFj7OWz5bSvX/I9XZjleNmj8rtx6Y8Wu3g0B+gPXn7NS4TlSsRef//Hpmj 02bcHXt7trOrEktxRqKhFnNRcSIAAwwUQ1gCAAA= X-CMS-MailID: 20180129232752epcas2p1a495ee12fcb1b809ae433daa1de48702 X-Msg-Generator: CA CMS-TYPE: 102P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20180129113331epcas2p3bb7bc89558e7219ef257b36fa47dc076 X-RootMTR: 20180129113331epcas2p3bb7bc89558e7219ef257b36fa47dc076 References: <20180129113323.18961-1-andi.shyti@samsung.com> <20180129113323.18961-5-andi.shyti@samsung.com> <20180129184309.ljnw63owyuhofqko@dtor-ws> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dmitry, On Mon, Jan 29, 2018 at 10:43:09AM -0800, Dmitry Torokhov wrote: > On Mon, Jan 29, 2018 at 08:33:19PM +0900, Andi Shyti wrote: > > '__packed' is not used anywhere, remove it. > > Umm, this is not a variable, this is type annotation meaning that the > structure is packed. Still not needed, as we are not using anything but > u8 data elements, but justification is completely wrong. Oh dammit! :) of course! The original idea was the alignment of the structure, but I must have got confused while re-editing all the commits. Sorry, I'll fix it. Andi