From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751979AbeA2X33 (ORCPT ); Mon, 29 Jan 2018 18:29:29 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:29213 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751542AbeA2X31 (ORCPT ); Mon, 29 Jan 2018 18:29:27 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout3.samsung.com 20180129232925epoutp03de080c7adaf1bf0103ae1a7adc8d91c1~Oa7ikgraz0901409014epoutp03Y X-AuditID: b6c32a38-adbff70000001054-73-5a6fae541fab Date: Tue, 30 Jan 2018 08:29:23 +0900 From: Andi Shyti To: Dmitry Torokhov Cc: Simon Shields , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Andi Shyti Subject: Re: [PATCH 5/8] Input: mms114 - use lower case for hexadecimal values Message-id: <20180129232923.GW7575@gangnam.samsung> MIME-version: 1.0 Content-type: text/plain; charset="us-ascii" Content-disposition: inline In-reply-to: <20180129185631.wvgl3il6tu6nk7ew@dtor-ws> User-Agent: Mutt/1.9.2 (2017-12-15) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrEKsWRmVeSWpSXmKPExsWy7bCmvm7Iuvwog8nLTS0W/3jOZHF40QtG i5ufvrFaXN41h81iy5nbbA6sHteXfGL22DnrLrtHy/pNbB6fN8kFsESl2mSkJqakFimk5iXn p2TmpdsqeQfHO8ebmhkY6hpaWpgrKeQl5qbaKrn4BOi6ZeYA7VVSKEvMKQUKBSQWFyvp29kU 5ZeWpCpk5BeX2CpFGxoa6RkamOsZGRnpmRjHWhmZApUkpGbceLSJqeAhT8XJloVsDYx/OLsY OTkkBEwknlztYOti5OIQEtjBKPFr4x0o5zujxOTWx+wwVWuW7maCSOxmlGhaeYwZwvnEKLF1 +3FWkCoWAVWJfSv/MYHYbAKaEk23f7CB2CIC+hLbZ/9iBGlgFmhmlDi16gULSEJYIEBi18WD YEW8AsYSEy8sYYGwBSV+TL4HZjML6EicPbaOEcKWlnj0dwbYSZwCZhJL1+8Cs0UFlCUWvJoC deoKNokf7RwQtovEkWsQuyQEhCVeHd8CVMMBZEtLXDpqCxEGumfb7WSQ2yQEJjBKfNr7lQki YSzxbGEXE8RePol3X3tYIXp5JTrahCBKPCRWnfrECmE7Ssw6vZgREihvGSW+bL7MNoFRdhaS d2YheWcWkncWMDKvYhRLLSjOTU8tNiww0StOzC0uzUvXS87P3cQITl9aFjsY95zzOcQowMGo xMNroJIfJcSaWFZcmXuIUYKDWUmEV2Q1UIg3JbGyKrUoP76oNCe1+BCjKTBOJjJLiSbnA1Nr Xkm8oYmlgYmZETBRWRoaKonzBgS4RAkJpCeWpGanphakFsH0MXFwSjUwMh/Z1uZguWTl/oLo +r1erUwmz/i8Gh699w1m6s3jvXx5QuKqe9cltnIu3MbA3LJ7U2Lw/kPnqy8br7ZQND57uGFL tOLZHwwW3k0lYp2uPaxc/J4feVJzLCrLy3J1rGUMMuaFNuzRemzks3Mlj6ex7J0/2ivn/0xs dpO+Mu9DX+jpPVtbv8xRYinOSDTUYi4qTgQAWCoT9nUDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrOLMWRmVeSWpSXmKPExsVy+t9jAd3gdflRBuc+W1ss/vGcyeLwoheM Fjc/fWO1uLxrDpvFljO32RxYPa4v+cTssXPWXXaPlvWb2Dw+b5ILYInisklJzcksSy3St0vg yrjxaBNTwUOeipMtC9kaGP9wdjFyckgImEisWbqbqYuRi0NIYCejxK/5jSwQzidGib43Xewg VSwCqhL7Vv5jArHZBDQlmm7/YAOxRQT0JbbP/sUI0sAs0MwocXH9TlaQhLCAn8SiM5/AingF jCUmXlgCNfUto8TbsxtZIBKCEj8m3wOzmQW0JNbvPM4EYUtLPPo7A2wzp4CZxNL1u8BsUQFl iQWvprBPYOSfhaR9FpL2WUjaFzAyr2KUTC0ozk3PLTYqMMxLLdcrTswtLs1L10vOz93ECAze bYe1+nYw3l8Sf4hRgINRiYfXQCU/Sog1say4MvcQowQHs5IIr8hqoBBvSmJlVWpRfnxRaU5q 8SFGaQ4WJXHe23nHIoUE0hNLUrNTUwtSi2CyTBycUg2MCkmrpltodVdIVfWcCir9diVl5bRZ rXdKPoU9mnpU7/gqz5l2F8Ii/OzUdd9Onq7+ulXKpPqVwgqB+MrgHWIP59hMZqtVtUvazD+p YJM2974TQZU1sxNvTBeoaj9QujrdL9z09P4dmnuVfI4u9Y6f0zxt89IHgt2RfQUFq6t1v9zc e5TvdY+OEktxRqKhFnNRcSIAnU0OnFoCAAA= X-CMS-MailID: 20180129232924epcas1p340b4d34ba89ffe417f534e699755bce8 X-Msg-Generator: CA CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20180129113331epcas2p29c39450d723f7d2085fc10a74a74e53c X-RootMTR: 20180129113331epcas2p29c39450d723f7d2085fc10a74a74e53c References: <20180129113323.18961-1-andi.shyti@samsung.com> <20180129113323.18961-6-andi.shyti@samsung.com> <20180129185631.wvgl3il6tu6nk7ew@dtor-ws> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dmitry, On Mon, Jan 29, 2018 at 10:56:31AM -0800, Dmitry Torokhov wrote: > On Mon, Jan 29, 2018 at 08:33:20PM +0900, Andi Shyti wrote: > > Signed-off-by: Andi Shyti > > But why? I think this patch is trivial and the subject itself is quite self-explanatory and the commit message would be a copy-paste of it. OK, if you want I will add "some comment". Andi > > --- > > drivers/input/touchscreen/mms114.c | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/input/touchscreen/mms114.c b/drivers/input/touchscreen/mms114.c > > index 11dba8bb48e3..fdf23bc416af 100644 > > --- a/drivers/input/touchscreen/mms114.c > > +++ b/drivers/input/touchscreen/mms114.c > > @@ -20,7 +20,7 @@ > > > > /* Write only registers */ > > #define MMS114_MODE_CONTROL 0x01 > > -#define MMS114_OPERATION_MODE_MASK 0xE > > +#define MMS114_OPERATION_MODE_MASK 0xe > > #define MMS114_ACTIVE (1 << 1) > > > > #define MMS114_XY_RESOLUTION_H 0x02 > > @@ -30,12 +30,12 @@ > > #define MMS114_MOVING_THRESHOLD 0x06 > > > > /* Read only registers */ > > -#define MMS114_PACKET_SIZE 0x0F > > +#define MMS114_PACKET_SIZE 0x0f > > #define MMS114_INFOMATION 0x10 > > -#define MMS114_TSP_REV 0xF0 > > +#define MMS114_TSP_REV 0xf0 > > > > -#define MMS152_FW_REV 0xE1 > > -#define MMS152_COMPAT_GROUP 0xF2 > > +#define MMS152_FW_REV 0xe1 > > +#define MMS152_COMPAT_GROUP 0xf2 > > > > /* 200ms needs after power on */ > > #define MMS114_POWERON_DELAY 200 > > -- > > 2.15.1 > > > > -- > Dmitry >