From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752007AbeA2Xdl (ORCPT ); Mon, 29 Jan 2018 18:33:41 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:37425 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751510AbeA2Xdi (ORCPT ); Mon, 29 Jan 2018 18:33:38 -0500 X-Google-Smtp-Source: AH8x227e7ZZiEtyOYdaC2gTXGD0am37FmTTX23IfGez+TrVEi7itaQdL2f0kq7FxOsh8KAOcmvYMeQ== Date: Mon, 29 Jan 2018 15:33:35 -0800 From: Dmitry Torokhov To: Andi Shyti Cc: Simon Shields , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Andi Shyti Subject: Re: [PATCH 5/8] Input: mms114 - use lower case for hexadecimal values Message-ID: <20180129233335.ikqioeetkkvocblm@dtor-ws> References: <20180129113323.18961-1-andi.shyti@samsung.com> <20180129113323.18961-6-andi.shyti@samsung.com> <20180129185631.wvgl3il6tu6nk7ew@dtor-ws> <20180129232923.GW7575@gangnam.samsung> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180129232923.GW7575@gangnam.samsung> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 30, 2018 at 08:29:23AM +0900, Andi Shyti wrote: > Hi Dmitry, > > On Mon, Jan 29, 2018 at 10:56:31AM -0800, Dmitry Torokhov wrote: > > On Mon, Jan 29, 2018 at 08:33:20PM +0900, Andi Shyti wrote: > > > Signed-off-by: Andi Shyti > > > > But why? > > I think this patch is trivial and the subject itself is quite > self-explanatory and the commit message would be a copy-paste of > it. Here is where we disagree. Why lowercase is preferred over uppercase? Do we have this in coding style (and I completely forgot about it)? Or is it your preference (mine is too to be fair, but I also do not care about churning the code for it)? Thanks. -- Dmitry