From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751993AbeA2Xnh (ORCPT <rfc822;w@1wt.eu>);
        Mon, 29 Jan 2018 18:43:37 -0500
Received: from mailout2.samsung.com ([203.254.224.25]:25606 "EHLO
        mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751394AbeA2Xnf (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 29 Jan 2018 18:43:35 -0500
DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20180129234333epoutp02d7d917d59c71bb14f345dddcfd4d8500~ObH4Ux2rk0319103191epoutp02X
X-AuditID: b6c32a39-47fff70000000fc5-64-5a6fb147ec37
Date: Tue, 30 Jan 2018 08:41:58 +0900
From: Andi Shyti <andi.shyti@samsung.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Simon Shields <simon@lineageos.org>, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org, Andi Shyti <andi@etezian.org>
Subject: Re: [PATCH 5/8] Input: mms114 - use lower case for hexadecimal
 values
Message-id: <20180129234158.GX7575@gangnam.samsung>
MIME-version: 1.0
Content-type: text/plain; charset="us-ascii"
Content-disposition: inline
In-reply-to: <20180129233335.ikqioeetkkvocblm@dtor-ws>
User-Agent: Mutt/1.9.2 (2017-12-15)
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrEKsWRmVeSWpSXmKPExsWy7bCmvq77xvwog59LxC0W/3jOZHF40QtG
        i5ufvrFaXN41h81iy5nbbA6sHteXfGL22DnrLrtHy/pNbB6fN8kFsESl2mSkJqakFimk5iXn
        p2TmpdsqeQfHO8ebmhkY6hpaWpgrKeQl5qbaKrn4BOi6ZeYA7VVSKEvMKQUKBSQWFyvp29kU
        5ZeWpCpk5BeX2CpFGxoa6RkamOsZGRnpmRjHWhmZApUkpGY8O7iWpWAPZ8XkGUdYGxiXs3cx
        cnJICJhIPNj3gbGLkYtDSGAHo8SxG0fYIJzvjBKznpxihql6+uwTE0RiA6PEzXUtUM4nRom1
        k1YwglSxCKhK7HzeAzaXTUBToun2DzYQW0RAX2L77F9gO5gFmhklTq16wQKSEBYIkNh18SBQ
        EQcHr4CxxPYODZAwr4CgxI/J98BKmAV0JM4eW8cIYUtLPPo7A2w+p4CZxJyPV1lBbFEBZYkF
        r6awg8yXEFjDJjFt6xyo51wkNs9dzwJhC0u8Or6FHWSXBNCgS0dtIcJA92y7nQzRO4FR4tPe
        r0wQCWOJZwu7mCAW80m8+9rDCtHLK9HRJgRR4iGx6tQnVgjbUWLW6cXQcDzMJNG/5jT7BEbZ
        WUj+mYXkn1lI/lnAyLyKUSy1oDg3PbXYsMBUrzgxt7g0L10vOT93EyM4fWlZ7mA8ds7nEKMA
        B6MSD6+BSn6UEGtiWXFl7iFGCQ5mJRFekdVAId6UxMqq1KL8+KLSnNTiQ4ymwDiZyCwlmpwP
        TK15JfGGJpYGJmZGwERlaWioJM4bEOASJSSQnliSmp2aWpBaBNPHxMEp1cDoEsvscSJ7eUee
        wcEu9tz781mKxW7N0lboueqr9y+0Tc3quuEjfvsnnrEJnw1EfNS21Wox3JllPctJ5r/fQ6ff
        395e4NNfzeydIvxgCdtSq4mzFhQLb7+0nLneSWtV/7sZDx8kWEW9vh6/faFGvLvewTt/9ryo
        VbOZYr3f9RjPlLmy3utf7RBSYinOSDTUYi4qTgQAC+KJPHUDAAA=
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrGLMWRmVeSWpSXmKPExsVy+t9jQV23jflRBhfm6lgs/vGcyeLwoheM
        Fjc/fWO1uLxrDpvFljO32RxYPa4v+cTssXPWXXaPlvWb2Dw+b5ILYInisklJzcksSy3St0vg
        ynh2cC1LwR7OiskzjrA2MC5n72Lk5JAQMJF4+uwTUxcjF4eQwDpGiU0XNrNCOJ8YJV5tfQxW
        xSKgKrHzeQ+YzSagKdF0+wcbiC0ioC+xffYvRpAGZoFmRomL63eygiSEBfwkFp35BFTEwcEr
        YCyxvUMDYuhhJolpL9rBmnkFBCV+TL7HAmIzC2hJrN95nAnClpZ49HcG2DJOATOJOR+vgs0U
        FVCWWPBqCvsERv5ZSNpnIWmfhaR9ASPzKkbJ1ILi3PTcYqMCw7zUcr3ixNzi0rx0veT83E2M
        wNDddlirbwfj/SXxhxgFOBiVeHgNVPKjhFgTy4orcw8xSnAwK4nwiqwGCvGmJFZWpRblxxeV
        5qQWH2KU5mBREue9nXcsUkggPbEkNTs1tSC1CCbLxMEp1cAYVjmbca7Bnd+WbBmqayKM+3V7
        ZNme7T0xYYu8oFQgr4Rve8wrPw+DBvaGHdOCmn7kGG2uF7bUltXfLBWRPf2dw/u3QVO+66l9
        rpS4Llqf45x3M91v5d2Ps5W1TglGPkv9etl20VMt64mOSi9m+zJUlZSVZ6619nC7Iyo/Z9eS
        6REy++q2v1FiKc5INNRiLipOBAB4hgMcWQIAAA==
X-CMS-MailID: 20180129234158epcas1p18f65b205b3e0ebdb5baca69184e079a1
X-Msg-Generator: CA
CMS-TYPE: 101P
DLP-Filter: Pass
X-CFilter-Loop: Reflected
X-CMS-RootMailID: 20180129113331epcas2p29c39450d723f7d2085fc10a74a74e53c
X-RootMTR: 20180129113331epcas2p29c39450d723f7d2085fc10a74a74e53c
References: <20180129113323.18961-1-andi.shyti@samsung.com>
        <CGME20180129113331epcas2p29c39450d723f7d2085fc10a74a74e53c@epcas2p2.samsung.com>
        <20180129113323.18961-6-andi.shyti@samsung.com>
        <20180129185631.wvgl3il6tu6nk7ew@dtor-ws>
        <20180129232923.GW7575@gangnam.samsung>
        <20180129233335.ikqioeetkkvocblm@dtor-ws>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Dmitry,

On Mon, Jan 29, 2018 at 03:33:35PM -0800, Dmitry Torokhov wrote:
> On Tue, Jan 30, 2018 at 08:29:23AM +0900, Andi Shyti wrote:
> > Hi Dmitry,
> > 
> > On Mon, Jan 29, 2018 at 10:56:31AM -0800, Dmitry Torokhov wrote:
> > > On Mon, Jan 29, 2018 at 08:33:20PM +0900, Andi Shyti wrote:
> > > > Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
> > > 
> > > But why?
> > 
> > I think this patch is trivial and the subject itself is quite
> > self-explanatory and the commit message would be a copy-paste of
> > it.
> 
> Here is where we disagree. Why lowercase is preferred over uppercase? Do
> we have this in coding style (and I completely forgot about it)? Or is
> it your preference (mine is too to be fair, but I also do not care
> about churning the code for it)?

I think this is the case where the cultural habits become law, I've
been writing lower case hex values from years and my eyes are so
used to it that it looks wrong to have them written upper case.
Many maintainers reject upper case hex values.

As well as many reject the " ? : " conditional form.

In any case, you're basically right here, at this point I
don't mind if you drop it :)

Thanks,
Andi