From: Peter Zijlstra <peterz@infradead.org>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
Ingo Molnar <mingo@kernel.org>,
David Woodhouse <dwmw2@infradead.org>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH 4/4] objtool: Don't print '.tmp_' prefix for .o files
Date: Tue, 30 Jan 2018 10:58:31 +0100 [thread overview]
Message-ID: <20180130095831.GJ2228@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <3788b5aec1c279184b78cdbd8b520903c0fb8a80.1517284349.git.jpoimboe@redhat.com>
On Mon, Jan 29, 2018 at 10:00:42PM -0600, Josh Poimboeuf wrote:
> With the following commit:
>
> 2a0098d70640 ("objtool: Fix seg fault with gold linker")
>
> ... objtool warnings started showing the modversions '.tmp_' prefix in
> the .o file name, like:
>
> arch/x86/mm/.tmp_mem_encrypt_boot.o: warning: objtool: sme_encrypt_execute()+0x48: indirect call found in RETPOLINE build
>
> The prefix is confusing. Remove it from the printed 'objname' variable.
This patch actually tripped me up today. Turns out I have both:
build/kernel/sched/core.o
build/kernel/sched/.tmp_core.o
and ended up staring at the wrong file and going WTF because the offsets
didn't match.
I much prefer the actual real filename printed. Yes the .tmp_ crud is
weird, but at least its the real file.
next prev parent reply other threads:[~2018-01-30 9:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-30 4:00 [PATCH 0/4] objtool: seg fault fixes and retpoline improvements Josh Poimboeuf
2018-01-30 4:00 ` [PATCH 1/4] objtool: Improve retpoline alternative handling Josh Poimboeuf
2018-01-30 8:46 ` [tip:x86/pti] " tip-bot for Josh Poimboeuf
2018-01-30 14:12 ` tip-bot for Josh Poimboeuf
2018-01-30 4:00 ` [PATCH 2/4] objtool: Add support for alternatives at the end of a section Josh Poimboeuf
2018-01-30 8:46 ` [tip:x86/pti] " tip-bot for Josh Poimboeuf
2018-01-30 14:13 ` tip-bot for Josh Poimboeuf
2018-01-30 4:00 ` [PATCH 3/4] objtool: Warn on stripped section symbol Josh Poimboeuf
2018-01-30 8:47 ` [tip:x86/pti] " tip-bot for Josh Poimboeuf
2018-01-30 14:13 ` tip-bot for Josh Poimboeuf
2018-01-30 4:00 ` [PATCH 4/4] objtool: Don't print '.tmp_' prefix for .o files Josh Poimboeuf
2018-01-30 8:47 ` [tip:x86/pti] objtool: Don't print '.tmp_' prefix for .o files when CONFIG_MODVERSIONS=y tip-bot for Josh Poimboeuf
2018-01-30 9:58 ` Peter Zijlstra [this message]
2018-01-30 15:53 ` [PATCH 4/4] objtool: Don't print '.tmp_' prefix for .o files Josh Poimboeuf
2018-01-31 6:17 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180130095831.GJ2228@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=dwmw2@infradead.org \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mingo@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome