From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x225AJIyvdGfd29qTqlokQ8fQDlo59TFVkL3Yf5fEDvvII7rQzW/WQs9nmjAMBtZV3yogtdn2 ARC-Seal: i=1; a=rsa-sha256; t=1517314576; cv=none; d=google.com; s=arc-20160816; b=DfQwhxZOxyEVKeF/6rNxgM3Tnuyti89a0IqTpso3lyuQEpXF57Q7oxNudy9ZaWPCYC /WeHz0CXvmqG+/iiqjOgFCVZacoNtyXMXZJV6gHqjeI9jj93axPpgUfcEpRVkSdX7JwC AQUHl+dS4g8xQkJuVfODD0PEll9PX/PULvLhfB35HjxKp3CEHcWyBFe8+fPHfwW+uWQY IfRlSfn9t2k6GIe4DonrU/F4rgwXsk3oCmB+sS542pcLDc4Q6hcWvNOgEU0VxIZNPFbZ o4XHekXkN97TC4/5nFyJQgCGbXUVzJyFD5mufJRVePe1d5MaLjCa+u0ymMMOCwTtK4DN piJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=tiEQBBJhy4ibYF970d0I7KxPbtXLVkcRUlvMcNX7bfE=; b=XD1f8wi881lpUNYzfOzEnHYbJn242+4GztrKzzIlBu5zbHZ0WliAz4GA9jG8zAPKPD irUocW40B2M23xCK0wJbyVrp7aeh2ZMUNPyo6aQ3N75cuMduNNakXrD54DRXnTaeoWzL hWwd1FTYL6ZlIV9J3L+S3u/UgJEpfKi3IsIcgDKwNubqGnzV8seBTsVxCauCa6yHnSY6 pPyYbHS60zJPQX8x/om2Ct9KlKd1ci8eIJ00+HjZPJWV4VuzHQjqOBV+aCtBKLYRxwmm 7wYsoqbJvl6jXJsyrtP27BamR09Sz3dllKXGd/3c6B2oliQiQhgT3r7U1ZOcLqG/d/Gj eLKg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kselftest-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kselftest-owner@vger.kernel.org Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kselftest-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kselftest-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751452AbeA3MQP (ORCPT ); Tue, 30 Jan 2018 07:16:15 -0500 Received: from mx2.suse.de ([195.135.220.15]:54353 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751411AbeA3MQO (ORCPT ); Tue, 30 Jan 2018 07:16:14 -0500 Date: Tue, 30 Jan 2018 13:16:11 +0100 From: Michal Hocko To: Ram Pai Cc: mpe@ellerman.id.au, mingo@redhat.com, akpm@linux-foundation.org, corbet@lwn.net, arnd@arndb.de, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, x86@kernel.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, dave.hansen@intel.com, benh@kernel.crashing.org, paulus@samba.org, khandual@linux.vnet.ibm.com, aneesh.kumar@linux.vnet.ibm.com, bsingharora@gmail.com, hbabu@us.ibm.com, bauerman@linux.vnet.ibm.com, ebiederm@xmission.com Subject: Re: [PATCH v10 27/27] mm: display pkey in smaps if arch_pkeys_enabled() is true Message-ID: <20180130121611.GC26445@dhcp22.suse.cz> References: <1516326648-22775-1-git-send-email-linuxram@us.ibm.com> <1516326648-22775-28-git-send-email-linuxram@us.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1516326648-22775-28-git-send-email-linuxram@us.ibm.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kselftest-owner@vger.kernel.org X-Mailing-List: linux-kselftest@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1589983964716042571?= X-GMAIL-MSGID: =?utf-8?q?1591019649093843133?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Thu 18-01-18 17:50:48, Ram Pai wrote: [...] > @@ -851,9 +848,13 @@ static int show_smap(struct seq_file *m, void *v, int is_pid) > (unsigned long)(mss->pss >> (10 + PSS_SHIFT))); > > if (!rollup_mode) { > - arch_show_smap(m, vma); > +#ifdef CONFIG_ARCH_HAS_PKEYS > + if (arch_pkeys_enabled()) > + seq_printf(m, "ProtectionKey: %8u\n", vma_pkey(vma)); > +#endif > show_smap_vma_flags(m, vma); > } > + Why do you need to add ifdef here? The previous patch should make arch_pkeys_enabled == F when CONFIG_ARCH_HAS_PKEYS=n. Btw. could you merge those two patches into one. It is usually much easier to review a new helper function if it is added along with a user. > m_cache_vma(m, vma); > return ret; > } > -- > 1.7.1 -- Michal Hocko SUSE Labs