From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-2008515-1517318727-2-10163086180556483570 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.001, ME_NOAUTH 0.01, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='com', MailFrom='org' X-Spam-charsets: plain='us-ascii' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: linux-usb-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1517318726; b=RfIKA5gYd20F7Nx1TT5Uj2QvYnqJ5/ml2zpT3Qt6rSmOcG3 n5ZTjK0pzKh1EhVqTOtZn95EMb08r21M6JRwUjPXwLVCR7gDakKheEph1w6Bn1l5 yGiG1i63hmnq/XWVQyRskBeMkkvvDVbo8qHfVIhOzr5/o5dffahni4mq3ruyVXRv SmUHQj85C9Otp7hjE7H7dWC+dGqGf6DpQIDqZjbmbpRbNZ5T/vpF0bQIp2cZL9+U y7HzdEtOKaDxwGGbOuoh/P01hWnjkuBZNqR0wwO3lyPVu1ZBOJ6Ls23UyUlc2+A/ AelrHYWUxI8cz0+AVoimc+pNT/f3BibGDnCZ4jA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:in-reply-to:sender :list-id; s=arctest; t=1517318726; bh=23JB5pB58tbwfAA8zMfzgmp0jv heEBeY2X8+DXp0qkU=; b=Ef6GXnzChlHpPzFSHxj7jg7SQxKxg8UCAU7DG4xpqI gOUhkzT0gorS13POlq7F7igzZHrN4GMM3liDn+tIxodYOISdrRljiTJD5yVgHCMf kFPnGcSJG6yUgQeisDa6o82BsRMU47KFxUKxRnwk7ymVOFWlq2WWyw2OShIYu4gz yLy7HaXyOrRmx9NrnRpyUUC4UPwm1ku0+teyRSpBS5mPjGmvRAX+uQHWHpn2zTSw g9XcJhcJfneEFpVYBW6POF0/Is+Xc4In/GpMucb8DRWJ7y9XzA/Gtku9uHACkgKy Zsr/KMm1ge1tiRf5GxG9n4kKLq7VeeOAXennZ0omzPUA== ARC-Authentication-Results: i=1; mx5.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linux.intel.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-usb-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=linux.intel.com header.result=pass header_org.domain=intel.com header_org.result=pass header_is_org_domain=no Authentication-Results: mx5.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linux.intel.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-usb-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=linux.intel.com header.result=pass header_org.domain=intel.com header_org.result=pass header_is_org_domain=no Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752293AbeA3NZL (ORCPT ); Tue, 30 Jan 2018 08:25:11 -0500 Received: from mga18.intel.com ([134.134.136.126]:26787 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751569AbeA3NZK (ORCPT ); Tue, 30 Jan 2018 08:25:10 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,435,1511856000"; d="scan'208";a="26626480" Date: Tue, 30 Jan 2018 15:25:04 +0200 From: Heikki Krogerus To: Adam Thomson Cc: Guenter Roeck , Greg Kroah-Hartman , Sebastian Reichel , Hans de Goede , Yueyao Zhu , Rui Miguel Silva , linux-usb@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, support.opensource@diasemi.com Subject: Re: [PATCH v4 0/7] typec: tcpm: Add sink side support for PPS Message-ID: <20180130132504.GH14922@kuha.fi.intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-usb-owner@vger.kernel.org X-Mailing-List: linux-usb@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Tue, Jan 02, 2018 at 03:50:48PM +0000, Adam Thomson wrote: > This patch set adds sink side support for the PPS feature introduced in the > USB PD 3.0 specification. > > The source PPS supply is represented using the Power Supply framework to provide > access and control APIs for dealing with it's operating voltage and current, > and switching between a standard PDO and PPS APDO operation. During standard PDO > operation the voltage and current is read-only, but for APDO PPS these are > writable as well to allow for control. > > It should be noted that the keepalive for PPS is not handled within TCPM. The > expectation is that the external user will be required to ensure re-requests > occur regularly to ensure PPS remains and the source does not hard reset. Sorry for the late reply. I don't have any major problems with these other than with 6/7. The documentation should be for the psy class, not tcpm. I'm also not comfortable with the "select POWER_SUPPLY", but if Guenter does not think it's a problem, I'm fine with it. I guess we can always, for example, introduce stubs for the power_supply* functions, and drop the dependency later. But as usual with tcpm.c, Guenter needs to give his ACK. Oh yes, and Sebastian needs to ACK the power_supply changes or course. Thanks, -- heikki