From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x2277v8i5vCAUVjZor7m4pM4T+NMhWfKwH2tlz44rHdOWgWyFLv3NgQwc5IG9F3jIpA9Azgb3 ARC-Seal: i=1; a=rsa-sha256; t=1517325107; cv=none; d=google.com; s=arc-20160816; b=vBeKnRfKg7seuB5WuR3fjd9P+KnzBLbelQILl2KjBis8TmFk0XpXXYHzXOUJfsAHus CafSbHDHks3Yh0j1GehsO7epG+25E60klqmUdpzoB+9icgEYm8je7BIR1G0Fa3eWfdCn 7rrN7Mp2LqRjspsNqYo5p6hjEW7Uk2ghG3z8ksRTRV1SDLFn7PczZwe6pHUZMcE5YgwY 21BP3jiLKz3rVG74fxdgCnYb9ROCZXEPx5DxILzCakyJiVPf9ykZ4vuuEm59WVeP89Gb KQswmnQipoEqykNdpodNr109FqXFVEUk+p1uEvMJXYPSai3maVtgAmcTFWgwMrRtlATj pJCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:arc-authentication-results; bh=DN4Ojr79ET8HNcjbLHL+JvDGmXXNT7W3Nb/Ya47ik/4=; b=Cq4nFYqBWTrUjm0GzDS2nyg0QQWGE1i6hu3rWEOtlS5h+Ze9mhMb8mIGWZ7Z/YoG8r VfuLgslMYUeETVDWEv7d0p9DRadHo8HvflHTMb1wo6kMFjNh3rWf8UQegSJ9mKT9IqB7 uMHL+1cBGkqDqZkAys2iqgMfBG8J0xP/V+L8BTpdFhNBlnsEKuTuCum2O8+78nRga0cu IFPV6Z5GUzomyjDMGh63DMpqXxowdZdq+XAYXmRxcwcVxLi/pDgxVcNXgwkM2yT+R51J Bg5qywLQ0O218F0bkyTsmNVvJ1jeNmDVH2eOrROY/Ukf/wk7ta1x6OI3MTu7XDsdBjIw roIA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of colin.king@canonical.com designates 91.189.89.112 as permitted sender) smtp.mailfrom=colin.king@canonical.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of colin.king@canonical.com designates 91.189.89.112 as permitted sender) smtp.mailfrom=colin.king@canonical.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com From: Colin King To: Frederic Barrat , Andrew Donnellan , Arnd Bergmann , Greg Kroah-Hartman , linuxppc-dev@lists.ozlabs.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] ocxl: fix signed comparison with less than zero Date: Tue, 30 Jan 2018 15:11:44 +0000 Message-Id: <20180130151144.32544-1-colin.king@canonical.com> X-Mailer: git-send-email 2.15.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1591030691319252976?= X-GMAIL-MSGID: =?utf-8?q?1591030691319252976?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: From: Colin Ian King Currently the comparison of used < 0 is always false because uses is a size_t. Fix this by making used a ssize_t type. Detected by Coccinelle: drivers/misc/ocxl/file.c:320:6-10: WARNING: Unsigned expression compared with zero: used < 0 Fixes: 5ef3166e8a32 ("ocxl: Driver code for 'generic' opencapi devices") Signed-off-by: Colin Ian King --- drivers/misc/ocxl/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/ocxl/file.c b/drivers/misc/ocxl/file.c index c90c1a578d2f..1287e4430e6b 100644 --- a/drivers/misc/ocxl/file.c +++ b/drivers/misc/ocxl/file.c @@ -277,7 +277,7 @@ static ssize_t afu_read(struct file *file, char __user *buf, size_t count, struct ocxl_context *ctx = file->private_data; struct ocxl_kernel_event_header header; ssize_t rc; - size_t used = 0; + ssize_t used = 0; DEFINE_WAIT(event_wait); memset(&header, 0, sizeof(header)); -- 2.15.1