From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x226funTVbR7TShBEzIxzQBMMFifKBa8TiAjmZD8zd1p3R4foJ+y91GEgI2mJrLU4IrW1ChR6 ARC-Seal: i=1; a=rsa-sha256; t=1517329732; cv=none; d=google.com; s=arc-20160816; b=KS8nHhn4sjKt6hW0mAGGDQqBkBd8FTw+DjRsaRSIfk0QhFuiaG6bs3aj4m4aW1G+WK dZZ+NdFCRF0zOQ9E85F2tDe/4jpJxb+vbeLqHGytSQL8QZXfwilFZxN0hjxzJvCUgGZF LbKYr/1uCzYMmP61HVkIPYNMKZVmkOmxXNQk+rvGXxJ2gS6+wJ6GRlNEvYkir8zX3lL3 gkulsEDF5vhs88HU/maASqdQnrtxWyoyNTyN3KRKDNUgunOqUAtrAWNMcw0IWeYId14g gFtS2Vx/3zA5tRxfVFBg98AZ3WE6WuPZlICK9BzYrpHCTDfQ2cx9CUdBl6XNQVQqW5Uu +mYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:user-agent:in-reply-to :content-disposition:mime-version:references:reply-to:subject:cc:to :from:date:arc-authentication-results; bh=6FE4iGHccZ1Q+u06g2wikp9FGwdE491b0BV+gKzkaqs=; b=zYZV91BeqXa/YvlimBBGID3UBbRTQ0I0ursNTtykiey8O/VfVhRSMl88RuaOVGMj73 AclLZ+wZ1hjfxf7EWAKzY0SZiNVGmKiFQpS5cMuZa0wkZHRZthCFdzQ/R6sgL2DPHfeW bWxVE2Hbb1GYecauMvmmwB62FwtRl/pg2zAuoydD0Rav6AVnCBRNiyVAdD90BaP68d7Y MD8KX+SaenUcVDt30c+qfQRv/Kp/UyncTeOSTWnX4gbHlStxMyyDqtncgmKa48tbImCg QruNbNaDfma4RxwYTq+JONuZh1D4XgzGdZZcyLsLJ+COoGMaEh3MAERP3Xu5mMyceo/9 42Ag== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kselftest-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kselftest-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kselftest-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kselftest-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752794AbeA3Q2w (ORCPT ); Tue, 30 Jan 2018 11:28:52 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:41330 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751986AbeA3Q2v (ORCPT ); Tue, 30 Jan 2018 11:28:51 -0500 Date: Tue, 30 Jan 2018 08:28:34 -0800 From: Ram Pai To: Michal Hocko Cc: mpe@ellerman.id.au, mingo@redhat.com, akpm@linux-foundation.org, corbet@lwn.net, arnd@arndb.de, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, x86@kernel.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, dave.hansen@intel.com, benh@kernel.crashing.org, paulus@samba.org, khandual@linux.vnet.ibm.com, aneesh.kumar@linux.vnet.ibm.com, bsingharora@gmail.com, hbabu@us.ibm.com, bauerman@linux.vnet.ibm.com, ebiederm@xmission.com Subject: Re: [PATCH v10 27/27] mm: display pkey in smaps if arch_pkeys_enabled() is true Reply-To: Ram Pai References: <1516326648-22775-1-git-send-email-linuxram@us.ibm.com> <1516326648-22775-28-git-send-email-linuxram@us.ibm.com> <20180130121611.GC26445@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180130121611.GC26445@dhcp22.suse.cz> User-Agent: Mutt/1.5.20 (2009-12-10) X-TM-AS-GCONF: 00 x-cbid: 18013016-0016-0000-0000-0000051D8336 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18013016-0017-0000-0000-0000285A2041 Message-Id: <20180130162834.GB5411@ram.oc3035372033.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-01-30_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1801300205 Sender: linux-kselftest-owner@vger.kernel.org X-Mailing-List: linux-kselftest@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1589983964716042571?= X-GMAIL-MSGID: =?utf-8?q?1591035541661149011?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Tue, Jan 30, 2018 at 01:16:11PM +0100, Michal Hocko wrote: > On Thu 18-01-18 17:50:48, Ram Pai wrote: > [...] > > @@ -851,9 +848,13 @@ static int show_smap(struct seq_file *m, void *v, int is_pid) > > (unsigned long)(mss->pss >> (10 + PSS_SHIFT))); > > > > if (!rollup_mode) { > > - arch_show_smap(m, vma); > > +#ifdef CONFIG_ARCH_HAS_PKEYS > > + if (arch_pkeys_enabled()) > > + seq_printf(m, "ProtectionKey: %8u\n", vma_pkey(vma)); > > +#endif > > show_smap_vma_flags(m, vma); > > } > > + > > Why do you need to add ifdef here? The previous patch should make > arch_pkeys_enabled == F when CONFIG_ARCH_HAS_PKEYS=n. You are right. it need not be wrapped in CONFIG_ARCH_HAS_PKEYS. I had to do it because vma_pkey(vma) is not defined in some architectures. I will provide a generic vma_pkey() definition for architectures that do not support PKEYS. > Btw. could you > merge those two patches into one. It is usually much easier to review a > new helper function if it is added along with a user. ok. Thanks, RP