From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751693AbeA3U1S (ORCPT ); Tue, 30 Jan 2018 15:27:18 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:34635 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751296AbeA3U1R (ORCPT ); Tue, 30 Jan 2018 15:27:17 -0500 X-Google-Smtp-Source: AH8x225LumfBbeiYIHJWdBIXOZcd1sLmjNv+LS/M3TEzMfTv5Gcj1aPSu3S/2JAsdd9n0aFEscthRg== From: Nicholas Brown X-Google-Original-From: Nicholas Brown To: apw@canonical.com, joe@perches.com Cc: linux-kernel@vger.kernel.org, Nicholas Brown Subject: [PATCH] checkpatch: warn if changed lines exceeds a maximum size Date: Tue, 30 Jan 2018 20:26:55 +0000 Message-Id: <20180130202655.22990-1-nick.brown@att.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <1517343904.3063.33.camel@intl.att.com> References: <1517343904.3063.33.camel@intl.att.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Changed lines is the total of inserted and deleted lines. By default there is no limit, --max-changed-lines may be used to set a value. Some users may wish to encourage that patches are split into smaller parts using this. See Documentation/process/submitting-patches.rst#split-changes Signed-off-by: Nicholas Brown --- scripts/checkpatch.pl | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 31031f10fe56..a71bc4f15ce7 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -49,6 +49,7 @@ my @ignore = (); my $help = 0; my $configuration_file = ".checkpatch.conf"; my $max_line_length = 80; +my $max_changed_lines; # undef = no max my $ignore_perl_version = 0; my $minimum_perl_version = 5.10.0; my $min_conf_desc_length = 4; @@ -92,6 +93,8 @@ Options: --ignore TYPE(,TYPE2...) ignore various comma separated message types --show-types show the specific message type in the output --max-line-length=n set the maximum line length, if exceeded, warn + --max-changed-lines=n set the maximum number of changed lines allowed, + if exceeded, warn. (insertions + deletions) --min-conf-desc-length=n set the min description length, if shorter, warn --root=PATH PATH to the kernel tree root --no-summary suppress the per-file summary @@ -209,6 +212,7 @@ GetOptions( 'show-types!' => \$show_types, 'list-types!' => \$list_types, 'max-line-length=i' => \$max_line_length, + 'max-changed-lines=i' => \$max_changed_lines, 'min-conf-desc-length=i' => \$min_conf_desc_length, 'root=s' => \$root, 'summary!' => \$summary, @@ -2165,6 +2169,8 @@ sub process { my $filename = shift; my $linenr=0; + my $inserted_lines_total=0; + my $deleted_lines_total=0; my $prevline=""; my $prevrawline=""; my $stashline=""; @@ -2233,6 +2239,14 @@ sub process { push(@fixed, $rawline) if ($fix); + if ($rawline=~/^\+/ && $rawline!~/^\+\+\+/) { + $inserted_lines_total++ + } + + if ($rawline=~/^-/ && $rawline!~/^---/) { + $deleted_lines_total++; + } + if ($rawline=~/^\+\+\+\s+(\S+)/) { $setup_docs = 0; if ($1 =~ m@Documentation/admin-guide/kernel-parameters.rst$@) { @@ -2306,6 +2320,13 @@ sub process { $prefix = ''; + #print "inserted: $inserted_lines_total\n"; + #print "deleted: $deleted_lines_total\n"; + if (defined $max_changed_lines && + ($inserted_lines_total+$deleted_lines_total > $max_changed_lines)) { + WARN("MAX_CHANGED_LINES", "please split the change into smaller parts\n"); + } + $realcnt = 0; $linenr = 0; $fixlinenr = -1; -- 2.14.1