From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-212041-1517387920-2-10623679284974965890 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.001, RCVD_IN_DNSWL_MED -2.3, SPF_PASS -0.001, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='140.211.166.138', Host='smtp1.osuosl.org', Country='US', FromHeader='org', MailFrom='org' X-Spam-charsets: plain='iso-8859-1' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: driverdev-devel-bounces@linuxdriverproject.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1517387919; b=IBLNGDHZ0f/wA0HR523Mi+m4K6UGHgyXUTNNsoFK8YRaR9k 7NdlyOn9noi+w3Qa01t8tm10gqemcriJN0Ct9Onf81aiOsZggdodlGdk8uRV0ZTJ 558vSwhe9GRhdUTPaVAbfpJac+/OTJ9HOJMVY05Jrw9xzwNiKbARcg5OkRH0m8wg UMyFLMpqFXS6aqC8AdQ2O0p/MGgTD2JCer8ytIRTKRsJVsKA1zagfYLeO1DZOLhL Esgt+a58/B4wYM4eFC/ojDyMeHTNZSJYkC631aJg7ErZ7FmWMv7Y5T+4+SXitD6V 28wOhzMpyGZFo1zu4MUnMSi0baF3H+Bc2FCQMqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:subject:message-id :references:mime-version:in-reply-to:list-id:list-unsubscribe :list-archive:list-post:list-help:list-subscribe:cc:content-type :content-transfer-encoding:sender; s=arctest; t=1517387919; bh=u MKDujUNttT9S4l2pvzYlNgJ8LOu/BCijXQCyblWeBs=; b=lqAdR5SLrKg3YDXJt YpfVj/5ydJRAQ+UnBs9fwxgCTOPFcJxp+IhoRNbvX5fR7W0LdgwFBLxeuqHWOQIU tS+xEsRchLqp3pqid6VxgHZozVT9FTfVhcAsW8feVOzOMDCuzq40Q3QBhny1iSQn 7F7Ygakk1y3LkJ5Gm8QbYmOGcvQ0FVBiPSbCTjlwfbR3fiMf6VSao5ho4f/EOYeo rpEPa3MMPxzvXNumeNVE+O0FFXtsu40yAcz1CWhCQhOuViaMEdi5BUDMkFtIqDu8 E2nseaoUpglqvOCKsXPyMuh3J/jCVL2bjL22p4skqRQk4TcS0+c97TBHvzEmgTOr WYg7A== ARC-Authentication-Results: i=1; mx6.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linuxfoundation.org; iprev=pass policy.iprev=140.211.166.138 (smtp1.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=whitealder.osuosl.org; x-aligned-from=fail; x-ptr=fail x-ptr-helo=whitealder.osuosl.org x-ptr-lookup=smtp1.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=linuxfoundation.org header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128 Authentication-Results: mx6.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linuxfoundation.org; iprev=pass policy.iprev=140.211.166.138 (smtp1.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=whitealder.osuosl.org; x-aligned-from=fail; x-ptr=fail x-ptr-helo=whitealder.osuosl.org x-ptr-lookup=smtp1.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=linuxfoundation.org header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128 X-Remote-Delivered-To: driverdev-devel@osuosl.org Date: Wed, 31 Jan 2018 09:38:27 +0100 From: Greg KH To: alexey Subject: Re: [PATCH v2] staging: android: ion: Add implementation of dma_buf_vmap and dma_buf_vunmap Message-ID: <20180131083827.GB32583@kroah.com> References: <1517344753-29021-1-git-send-email-alexey.skidanov@intel.com> <20180130221501.GA6717@kroah.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.3 (2018-01-21) X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.24 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Wed, Jan 31, 2018 at 01:44:47AM +0200, alexey wrote: > = > = > On 01/31/2018 12:15 AM, Greg KH wrote: > > On Tue, Jan 30, 2018 at 10:39:13PM +0200, Alexey Skidanov wrote: > > > dma_buf_vmap and dma_buf_vunmap allow drivers to access buffers, crea= ted by ion. > > But why would anyone ever want to do that? What is wrong with the > > existing interfaces that drivers use to access buffers created by ion? > Any driver, sharing the buffers, created by ion, through dma-buf, may get > back the > sgtable describing the buffer for device DMA=A0 and may call dma_buf_vmap= to > get back > the kernel virtual address of the buffer to get access to it. Currently, = the > second > option is missing. Actually, the buffer already mapped by ion > implementation. Very odd formatting :( Anyway, as Dan said, this needs to be put in the changelog text itself. I know Intel has documentation and training for how to submit patches to the kernel properly. Please use that resource and get your patch submission reviewed by someone from the Linux kernel team at Intel before resending this. Don't force the community to help you learn this when you have people whose job it is to help out with this at your company :) thanks, greg k-h _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel