From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-209784-1517388399-2-11935596819823891486 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no ("Email failed DMARC policy for domain") X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.001, RCVD_IN_DNSWL_MED -2.3, SPF_PASS -0.001, UNPARSEABLE_RELAY 0.001, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='140.211.166.136', Host='smtp3.osuosl.org', Country='US', FromHeader='com', MailFrom='org' X-Spam-charsets: plain='us-ascii' X-IgnoreVacation: yes ("Email failed DMARC policy for domain") X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: driverdev-devel-bounces@linuxdriverproject.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1517388398; b=UNmuARN25iGfQoY4DzJziM6h3EkBPizeucKaIhciMOwyLv/ gk7vWu3xT+bR7rwi62BK77iofFc6ru28iFrqa7b+l72uhTd7I84Y1YUJ3ts1jZUO 5bvGnZU4QGHJoPAbSXswanA/J3MwXP+y4wTI3FVVpHOnXru09nE+93513F/R+5+E jgBs45xB/I+nem9eTFiNWh8+cdj0famFCN6N2Xg5asxxpXed+Ic+iNnWLW07js/V kDrNRbok5It+IulAUXc+nRYa+Ov1xb9n97A2Vr0kL6LZOX3QxLCbahwCs4/K0YQR c3f7jssDg0rfidOCqxOrCLkbGO+8QOA76jrhgRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:subject:message-id :references:mime-version:in-reply-to:list-id:list-unsubscribe :list-archive:list-post:list-help:list-subscribe:cc:content-type :content-transfer-encoding:sender; s=arctest; t=1517388398; bh=s mw2I2UNB7SPBa4h7IDKoEfoE0RoMkHsGxaL39mceWs=; b=xCxSY65MFCutVJH/m 17FPbuma+fqoZg3W/4uD2Ab7G9LYwBrK/ELDDxazhbWlb4vQiur2Lgw+a8f6V14k BR0CdbbDWkcrczVZtLXJD0ZvfFV5C+DClUdEFHaQodnf+rvGAFIk9R0r3urIek5e uwgfDSkQkmq3ze70UTvQf4GQ1XvzNq1ULwmeTGa7Owhueg2skhcH18+nVoOjhMUC H9chSxpX6VeiB7BVa+oVaVzuTG1I0YUVhdufywrONTjjAlu9NvvXle5gX1D/x0Cc Rb1MwD4IPp5A6eqa0sl7ihI+bc9MrbDsOvvZuQcrx80eo3beZXun/HOjD1Zpvz3E 1Ucpg== ARC-Authentication-Results: i=1; mx6.messagingengine.com; arc=none (no signatures found); dkim=fail (message has been altered; 2048-bit rsa key sha256) header.d=oracle.com header.i=@oracle.com header.b=Gfu1yCQR x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=corp-2017-10-26; dmarc=fail (p=none,has-list-id=yes,d=none) header.from=oracle.com; iprev=pass policy.iprev=140.211.166.136 (smtp3.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=silver.osuosl.org; x-aligned-from=fail; x-ptr=fail x-ptr-helo=silver.osuosl.org x-ptr-lookup=smtp3.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=oracle.com header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128 Authentication-Results: mx6.messagingengine.com; arc=none (no signatures found); dkim=fail (message has been altered; 2048-bit rsa key sha256) header.d=oracle.com header.i=@oracle.com header.b=Gfu1yCQR x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=corp-2017-10-26; dmarc=fail (p=none,has-list-id=yes,d=none) header.from=oracle.com; iprev=pass policy.iprev=140.211.166.136 (smtp3.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=silver.osuosl.org; x-aligned-from=fail; x-ptr=fail x-ptr-helo=silver.osuosl.org x-ptr-lookup=smtp3.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=oracle.com header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128 X-Remote-Delivered-To: driverdev-devel@osuosl.org Date: Wed, 31 Jan 2018 11:46:20 +0300 From: Dan Carpenter To: Ulf Magnusson Subject: Re: [PATCH 05/10] Staging: rtl8192e: kconfig: Remove empty help text Message-ID: <20180131084620.kkok5rpfbqakhyps@mwanda> References: <20180130190555.6577-1-ulfalizer@gmail.com> <20180130190555.6577-6-ulfalizer@gmail.com> <20180131080622.z6yf2h27m4ea3fkx@mwanda> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8790 signatures=668657 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=3 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=837 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1801310115 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.24 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Linux Kbuild mailing list , Greg Kroah-Hartman , Linux Kernel Mailing List , Masahiro Yamada , "Luis R . Rodriguez" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Wed, Jan 31, 2018 at 09:41:24AM +0100, Ulf Magnusson wrote: > On Wed, Jan 31, 2018 at 9:06 AM, Dan Carpenter wrote: > > On Tue, Jan 30, 2018 at 08:05:27PM +0100, Ulf Magnusson wrote: > >> In preparation for adding a warning ("kconfig: Warn if help text is > >> blank"): https://lkml.org/lkml/2018/1/30/516 > >> > > > > Please don't start the boddy of the email in the middle of a sentence. > > > > It looks like this: > > > > https://marc.info/?l=linux-driver-devel&m=151733925532413&w=2 > > > > Notice how the subject is up above the From, Date, and Message-id email > > headers? It's totally disconnected from the body of the email. > > > > regards, > > dan carpenter > > The 'this is in...' was implied. I'll try to be less of a sloppy bastard. > I do feel that patch descriptions should say what the patch does as well as why. Right now the subject says what but I normally read either the body or the subject but not both. regards, dan carpenter _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel