From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-806700-1517406364-2-1758116470092721534 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no ("Email failed DMARC policy for domain") X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.001, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES unknown, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='com', MailFrom='org' X-Spam-charsets: X-IgnoreVacation: yes ("Email failed DMARC policy for domain") X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: linux-usb-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1517406363; b=vlyytwY4Mob5aZuV66HSlED9APalUXy/ucxIa4u3e/iA9DP zjAZeyiUIaxbckQ2eeFX+Msk/k744acHrd5Uqr2VfIJxkXfVBuxHWg4KdaqcVDGs Kpb0SwCuUQnUS1El2Uoq1F8EK52qmG2PPXkhcoVrqyPzHyU3Iz3QZuFixp1WJYny TijDeeBtIekKjqdED0a+m9GpgKJGw7zxIQ5AVl6NVnbAfzSSx5tmMV1lNzWg+PdC lUWI126G9yiJl5mYqGlFecGazT7Bm3u3TC+a4E4dW9IdEeKHfZDMe4zX5y37WpRq JZ+E2tIY+DtLrAYNnZSey8aQToH7t4PSbeVCMyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:sender:list-id; s=arctest; t=1517406363; bh=WLWq/1qJ/YHSqmp0xA8uOAE/86vu+dGZ6A6RK1Pq9WI=; b=YEfO262Zl5zE rAE3/UZqbyXWJGlrc4/ob2dGIozJqkbm122SjEwp2Wd2qeHUkqhMvxx/imCE9plu 9IsSJdiAk0zNk0YiympUoNxb5jIJl3eGXevixw6Tr9GTwv+sASABpGTov501uS/V zUWhBf3ONLQrGuXSrHQfaXscpsX2ecifU69vSQ01jf6SekQcUOxHRRBQkNFpOQaC 8vFcN/bhLoPPo34C9qWOAjYLlFABh9YmKdxdzKz3Oa0nIQRwZ7Ne8DPUcUcJcPwM 7Sx4Ol5079Xsp6cAFKFM70hB3U6HhI0j22lSGTL0NsVLNntE5d/efec0U3wbs5Os 3gzBLaN6qg== ARC-Authentication-Results: i=1; mx2.messagingengine.com; arc=none (no signatures found); dkim=fail (body has been altered; 1024-bit rsa key sha256) header.d=samsung.com header.i=@samsung.com header.b=tv3k24+C x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=mail20170921; dmarc=fail (p=none,has-list-id=yes,d=none) header.from=samsung.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-usb-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=samsung.com header.result=pass header_is_org_domain=yes Authentication-Results: mx2.messagingengine.com; arc=none (no signatures found); dkim=fail (body has been altered; 1024-bit rsa key sha256) header.d=samsung.com header.i=@samsung.com header.b=tv3k24+C x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=mail20170921; dmarc=fail (p=none,has-list-id=yes,d=none) header.from=samsung.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-usb-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=samsung.com header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753557AbeAaNpq (ORCPT ); Wed, 31 Jan 2018 08:45:46 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:33891 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752858AbeAaNpE (ORCPT ); Wed, 31 Jan 2018 08:45:04 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20180131134501euoutp02e6b88c141d7ba016f2383121d54d2aa6~O6P3yAyNF1413014130euoutp02r X-AuditID: cbfec7f4-f790c6d0000075d3-a1-5a71c85c4d58 From: Andrzej Hajda To: devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , dri-devel@lists.freedesktop.org, Inki Dae , Rob Herring , Mark Rutland , Krzysztof Kozlowski , Chanwoo Choi , Archit Taneja , Laurent Pinchart , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-usb@vger.kernel.org Subject: [RFC PATCH v2 4/5] extcon: add possibility to get extcon device by OF node Date: Wed, 31 Jan 2018 14:44:34 +0100 Message-id: <20180131134435.12216-5-a.hajda@samsung.com> X-Mailer: git-send-email 2.15.1 In-reply-to: <20180131134435.12216-1-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAAzWSbUhTURzGO9t9m215uYqd1IomfihKE/xwrIyEPlx6gQwNHEaOdlHxbe46 URESU5mv6TLTJvm+TCxzioZp0DRnaM2lKEkpISgpmU4rK7Pc7vz2+z//5+F/HjiUmPmNeVPx yWmcJlmZKCfcsJ7hX9YT0SOpipOzNhmaefoOR7m6rzjqrO7A0fTGIo7qhna0ye/fCKSfK8eQ 1fqMRIUVzSQyzU/haKKvlkDV1pci1GjMF6MnQ59I1DJtE6H8gSHyHM22P2wH7ERZqYg16Gpw 1tRWSLBzxRYR29V8iy3rbgPsuunQFUrhdkbFJcanc5rAszFucQuTa4R63TtjwY7nAItXEZBQ kA6G/V/ukQJ7wfHZDqIIuFEM3QLgysycSBjWAWysK8Z3E136QVJYGAFcrZlzLhj6H4C1nayD Cfoo/Nv1gXCwJ30drrzvEzsCYnocg+OjS857HnQkrLytwxyM0f5wzPjHGZDRCJa0mUTCtcOw vDvX6ZHQIXC2td/5PkgvEtC60ioWTOfhg9xNVwkPuGTpdrEvLNS9EgmBYgDtd0ZIYagEcHu1 2pU+DQctNmcHMb0P6nvu7+jUji6DugJGsLBwoiqPEDgM3v1ocPUvAbC+2I6VA596sKcNeHJa PimW44MDeGUSr02ODbiZkmQCOz9idNuy8Rw0DZ8yA5oCcqksJkutYHBlOp+ZZAaQEss9ZT+i UxWMTKXMzOI0KTc02kSONwMfCpPvl4UqCqIYOlaZxiVwnJrT7G5FlMQ7B5QekSD7ZnavbMC/ IfOn1Mj1Xqp6u7zsxxyPagiM2CLfRISr+JLskQuh2pzPBuVU/j6Qr6noCtWk9S3bShu0HTFB IeHk5RdhTO2BESJ6GC3qm7bWmjquStWGnoPuS/TAvPvjSMUjc9pr/7y4CEWCRbrX7+K1Rd+x iZqMpkyVHOPjlEHHxBpe+R+5g5f0DQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrHLMWRmVeSWpSXmKPExsVy+t/xy7rRJwqjDA7dFLa4te4cq0VTx1tW i40z1rNaXP/ynNVi/hGg2JWv79ksJt2fwGJx/vwGdovOiUvYLTY9vsZqcXnXHDaLGef3MVks WtbKbLH2yF12i6XXLzJZtO49wu4g4LFm3hpGj8t9vUwesztmsnpsWtXJ5nG/+ziTx+Yl9R59 W1YxenzeJBfAEcVlk5Kak1mWWqRvl8CV8ezKR7aCz1IVzz6xNjAeF+ti5OSQEDCR2DzpMDuE LSZx4d56ti5GLg4hgSWMEreO/IFyGpkkLp/azQpSxSagKfF38002EFtEIFbi7anPzCBFzAIX WCR+T5wJNkpYIFRie9syZhCbRUBV4syy32ANvAIWEj2rNjFBrJOXmLCliQXE5hSwlLi3Yg9Y jRBQzb9NDWwTGHkXMDKsYhRJLS3OTc8tNtQrTswtLs1L10vOz93ECAzlbcd+bt7BeGlj8CFG AQ5GJR7ehKqCKCHWxLLiytxDjBIczEoivN9iCqOEeFMSK6tSi/Lji0pzUosPMUpzsCiJ8/bu WR0pJJCeWJKanZpakFoEk2Xi4JRqYHQ1MvoWcFyzbemhHww+Py88fCFcX6D9l8NBNv63WjrX eaPD34/2dL7vKr2tslFX8LLB5lW7jbgqZ7RH6SqFqV/2N95xZELG2YU7HR9nbTwxU2zu1W8R DOU8rFM4J8/uDVx06nV++gO7aVfmle5WOGX0QvHPvAdLdA9nMv23rGduY7+vfVn6aqUSS3FG oqEWc1FxIgCvIZkeYQIAAA== X-CMS-MailID: 20180131134459eucas1p15c0dd76f5173816b949e72cde93c0a6c X-Msg-Generator: CA CMS-TYPE: 201P X-CMS-RootMailID: 20180131134459eucas1p15c0dd76f5173816b949e72cde93c0a6c X-RootMTR: 20180131134459eucas1p15c0dd76f5173816b949e72cde93c0a6c References: <20180131134435.12216-1-a.hajda@samsung.com> Sender: linux-usb-owner@vger.kernel.org X-Mailing-List: linux-usb@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: Since extcon property is not allowed in DT, extcon subsystem requires another way to get extcon device. Lets try the simplest approach - get edev by of_node. Signed-off-by: Andrzej Hajda Acked-by: Chanwoo Choi --- v2: changed label to follow local convention (Chanwoo) --- drivers/extcon/extcon.c | 44 ++++++++++++++++++++++++++++++++++---------- include/linux/extcon.h | 6 ++++++ 2 files changed, 40 insertions(+), 10 deletions(-) diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c index cb38c2747684..c4972c4cb3bd 100644 --- a/drivers/extcon/extcon.c +++ b/drivers/extcon/extcon.c @@ -1336,6 +1336,28 @@ void extcon_dev_unregister(struct extcon_dev *edev) EXPORT_SYMBOL_GPL(extcon_dev_unregister); #ifdef CONFIG_OF + +/* + * extcon_get_edev_by_of_node - Get the extcon device from devicetree. + * @node : OF node identyfying edev + * + * Return the pointer of extcon device if success or ERR_PTR(err) if fail. + */ +struct extcon_dev *extcon_get_edev_by_of_node(struct device_node *node) +{ + struct extcon_dev *edev; + + mutex_lock(&extcon_dev_list_lock); + list_for_each_entry(edev, &extcon_dev_list, entry) + if (edev->dev.parent && edev->dev.parent->of_node == node) + goto out; + edev = ERR_PTR(-EPROBE_DEFER); +out: + mutex_unlock(&extcon_dev_list_lock); + + return edev; +} + /* * extcon_get_edev_by_phandle - Get the extcon device from devicetree. * @dev : the instance to the given device @@ -1363,25 +1385,27 @@ struct extcon_dev *extcon_get_edev_by_phandle(struct device *dev, int index) return ERR_PTR(-ENODEV); } - mutex_lock(&extcon_dev_list_lock); - list_for_each_entry(edev, &extcon_dev_list, entry) { - if (edev->dev.parent && edev->dev.parent->of_node == node) { - mutex_unlock(&extcon_dev_list_lock); - of_node_put(node); - return edev; - } - } - mutex_unlock(&extcon_dev_list_lock); + edev = extcon_get_edev_by_of_node(node); of_node_put(node); - return ERR_PTR(-EPROBE_DEFER); + return edev; } + #else + +struct extcon_dev *extcon_get_edev_by_of_node(struct device_node *node) +{ + return ERR_PTR(-ENOSYS); +} + struct extcon_dev *extcon_get_edev_by_phandle(struct device *dev, int index) { return ERR_PTR(-ENOSYS); } + #endif /* CONFIG_OF */ + +EXPORT_SYMBOL_GPL(extcon_get_edev_by_of_node); EXPORT_SYMBOL_GPL(extcon_get_edev_by_phandle); /** diff --git a/include/linux/extcon.h b/include/linux/extcon.h index 6d94e82c8ad9..b47e0c7f01fe 100644 --- a/include/linux/extcon.h +++ b/include/linux/extcon.h @@ -230,6 +230,7 @@ extern void devm_extcon_unregister_notifier_all(struct device *dev, * Following APIs get the extcon_dev from devicetree or by through extcon name. */ extern struct extcon_dev *extcon_get_extcon_dev(const char *extcon_name); +extern struct extcon_dev *extcon_get_edev_by_of_node(struct device_node *node); extern struct extcon_dev *extcon_get_edev_by_phandle(struct device *dev, int index); @@ -283,6 +284,11 @@ static inline struct extcon_dev *extcon_get_extcon_dev(const char *extcon_name) return ERR_PTR(-ENODEV); } +static inline struct extcon_dev *extcon_get_edev_by_of_node(struct device_node *node) +{ + return ERR_PTR(-ENODEV); +} + static inline struct extcon_dev *extcon_get_edev_by_phandle(struct device *dev, int index) { -- 2.15.1