From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753930AbeAaQUy (ORCPT <rfc822;w@1wt.eu>);
        Wed, 31 Jan 2018 11:20:54 -0500
Received: from youngberry.canonical.com ([91.189.89.112]:49564 "EHLO
        youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753356AbeAaQUw (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 31 Jan 2018 11:20:52 -0500
X-Google-Smtp-Source: AH8x224YOh57VKw0QzvU2GV6aaFf2rj8xNvHv5ytEiySk1QVKDT+rpQD/yzSxUOugDAPY/UiUUjWsg==
Date: Wed, 31 Jan 2018 17:20:49 +0100
From: Christian Brauner <christian.brauner@canonical.com>
To: David Miller <davem@davemloft.net>
Cc: christian.brauner@ubuntu.com, netdev@vger.kernel.org,
        ebiederm@xmission.com, dsahern@gmail.com, fw@strlen.de,
        daniel@iogearbox.net, lucien.xin@gmail.com,
        mschiffer@universe-factory.net, jakub.kicinski@netronome.com,
        vyasevich@gmail.com, linux-kernel@vger.kernel.org, jbenc@redhat.com,
        w.bumiller@proxmox.com, nicolas.dichtel@6wind.com
Subject: Re: [PATCH net-next 1/1] rtnetlink: enable IFLA_IF_NETNSID for
 RTM_NEWLINK
Message-ID: <20180131162048.iy67tccusgceajgw@gmail.com>
References: <20180129170720.29724-1-christian.brauner@ubuntu.com>
 <20180129170720.29724-2-christian.brauner@ubuntu.com>
 <20180131.103044.1805785714040464628.davem@davemloft.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20180131.103044.1805785714040464628.davem@davemloft.net>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jan 31, 2018 at 10:30:44AM -0500, David Miller wrote:
> From: Christian Brauner <christian.brauner@ubuntu.com>
> Date: Mon, 29 Jan 2018 18:07:20 +0100
> 
> > - Backwards Compatibility:
> >   If userspace wants to determine whether RTM_NEWLINK supports the
> >   IFLA_IF_NETNSID property they should first send an RTM_GETLINK request
> >   with IFLA_IF_NETNSID on lo. If either EACCESS is returned or the reply
> >   does not include IFLA_IF_NETNSID userspace should assume that
> >   IFLA_IF_NETNSID is not supported on this kernel.
> >   If the reply does contain an IFLA_IF_NETNSID property userspace
> >   can send an RTM_NEWLINK with a IFLA_IF_NETNSID property. If they receive
> >   EOPNOTSUPP then the kernel does not support the IFLA_IF_NETNSID property
> >   with RTM_NEWLINK. Userpace should then fallback to other means.
> > 
> > - Security:
> >   Callers must have CAP_NET_ADMIN in the owning user namespace of the
> >   target network namespace.
> > 
> > Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
> 
> Applied.

Thanks!