From: David Miller <davem@davemloft.net>
To: gustavo@embeddedor.com
Cc: hswong3i@gmail.com, hlhung3i@gmail.com, kuznet@ms2.inr.ac.ru,
yoshfuji@linux-ipv6.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, garsilva@embeddedor.com
Subject: Re: [PATCH] tcp_lp: use 64-bit arithmetic instead of 32-bit
Date: Thu, 01 Feb 2018 09:45:31 -0500 (EST) [thread overview]
Message-ID: <20180201.094531.310132736141169083.davem@davemloft.net> (raw)
In-Reply-To: <20180201002407.GA1608@embeddedgus>
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Date: Wed, 31 Jan 2018 18:24:07 -0600
> Cast to s64 some variables and a macro in order to give the
> compiler complete information about the proper arithmetic to
> use. Notice that these elements are used in contexts that
> expect expressions of type s64 (64 bits, signed).
>
> Currently such expression are being evaluated using 32-bit
> arithmetic.
>
> Addresses-Coverity-ID: 200687
> Addresses-Coverity-ID: 200688
> Addresses-Coverity-ID: 200689
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Sorry, I'm not applying this, the domain of the input values
means that the calculation cannot overflow.
next prev parent reply other threads:[~2018-02-01 14:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-01 0:24 Gustavo A. R. Silva
2018-02-01 0:32 ` Alan Cox
2018-02-01 1:07 ` Gustavo A. R. Silva
2018-02-01 1:51 ` Andrew Lunn
2018-02-02 2:32 ` Gustavo A. R. Silva
2018-02-01 10:14 ` David Laight
2018-02-02 2:33 ` Gustavo A. R. Silva
2018-02-01 14:45 ` David Miller [this message]
2018-02-02 2:38 ` Gustavo A. R. Silva
2018-02-02 9:32 ` kbuild test robot
2018-02-02 10:44 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180201.094531.310132736141169083.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=garsilva@embeddedor.com \
--cc=gustavo@embeddedor.com \
--cc=hlhung3i@gmail.com \
--cc=hswong3i@gmail.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®