From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x224gZwIdnu6JqcSOhalM7amxJGgKNxVo1X3o60WGxBN4h0zEj111bWX6pypQpRGDnGFSTMaj ARC-Seal: i=1; a=rsa-sha256; t=1517517547; cv=none; d=google.com; s=arc-20160816; b=fab25yoe7I1dXeIyCMRd5ojy8gCBhjlmbKgXwSIXtf7/V42Dwi/R4QivYQMkAyaHjZ KozNLfAfTNlzMS0D4ILDLmYMBwP6NH8DKKTZkAnG8115s0DIhvpPwXrgSsGeImIDvFjK fj5Mp7LkirFxbnKxKT51FOPV5vcOk8f0/EvnUrSg/CjASKfUW5pP95oNwu9bPbdJC0It h+fkWEoCxq+J0YPPPJxIHvzuLwBqgVbHMmoOC4//Lrhsc9UijpROPVxhHC4wCUTD4Pr6 J1tP/aBaBsUKEGo039BLTE7/js9RF56vD+KZFounCo8cBalPOHXgL7xz2fU1kaT5lZW8 XONg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to:from :subject:cc:to:message-id:date:arc-authentication-results; bh=J5sQSUxIFNvFaFqCriEABvF6d9SeicjGnfPlmrchiCo=; b=bQTr5xCacGu70COr9O8cS5YMQq+HJdP+7i6eZWvsozQWBaMWrb2IHZpJqtnuyOYu08 hIIEOFiIZm5Ikep3lL5OQZBusfL55hvXw6DSFGZsqIKhOu+smGeonaPnaigNsP+sWX7L f4OhRvE5HtZm/cFrHPrGQKaozgkio16OPe5EKU7b2zfHfWNcf3PJSAl6JG+fjZXZ6NWe F5t+l7NpDsFN66cbQu66utO9j7GzVB/qjqnHVVe7Q3idCm9GER+Q2Ow8VR4cdRJQQZDH TGa/4sUj+JJxZrZXnKNBzB4drTn2feOWzk6FJkfcOxsH9FacZXJafuYWzcfO1Pdl4w1o EI2w== ARC-Authentication-Results: i=1; mx.google.com; spf=neutral (google.com: 184.105.139.130 is neither permitted nor denied by best guess record for domain of davem@davemloft.net) smtp.mailfrom=davem@davemloft.net Authentication-Results: mx.google.com; spf=neutral (google.com: 184.105.139.130 is neither permitted nor denied by best guess record for domain of davem@davemloft.net) smtp.mailfrom=davem@davemloft.net Date: Thu, 01 Feb 2018 15:39:03 -0500 (EST) Message-Id: <20180201.153903.1719756519690647679.davem@davemloft.net> To: joe@perches.com Cc: khalid.aziz@oracle.com, dave.hansen@linux.intel.com, mhocko@suse.com, mingo@kernel.org, gregkh@linuxfoundation.org, glx@linutronix.de, kstewart@linuxfoundation.org, vijay.ac.kumar@oracle.com, kirill.shutemov@linux.intel.com, nitin.m.gupta@oracle.com, tom.hromatka@oracle.com, allen.pais@oracle.com, rob.gardner@oracle.com, david.j.aldridge@oracle.com, babu.moger@oracle.com, bob.picco@oracle.com, steven.sistare@oracle.com, pasha.tatashin@oracle.com, vegard.nossum@oracle.com, pombredanne@nexb.com, jane.chu@oracle.com, anthony.yznaga@oracle.com, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, khalid@gonehiking.org Subject: Re: [PATCH v11 03/10] sparc64: Add support for ADI register fields, ASIs and traps From: David Miller In-Reply-To: <1517517122.7489.47.camel@perches.com> References: <1517517122.7489.47.camel@perches.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1591222601953119188?= X-GMAIL-MSGID: =?utf-8?q?1591232480320051753?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: From: Joe Perches Date: Thu, 01 Feb 2018 12:32:02 -0800 >> diff --git a/arch/sparc/include/asm/ttable.h b/arch/sparc/include/asm/ttable.h > [] >> @@ -219,6 +219,16 @@ >> nop; \ >> nop; >> >> +#define SUN4V_MCD_PRECISE \ >> + ldxa [%g0] ASI_SCRATCHPAD, %g2; \ >> + ldx [%g2 + HV_FAULT_D_ADDR_OFFSET], %g4; \ >> + ldx [%g2 + HV_FAULT_D_CTX_OFFSET], %g5; \ >> + ba,pt %xcc, etrap; \ >> + rd %pc, %g7; \ >> + ba,pt %xcc, sun4v_mcd_detect_precise; \ >> + nop; \ >> + nop; > > and here and elsewhere. Joe, this is intentional in Sparc assembler. Branches on sparc have delay slots, and this is annotated by indenting the delay slot instruction one space more than the branch preceeding it. Please make more constructive review comments than whitespace as these patches have been under review for more than half a year. Thank you very much.